* [PATCH] staging: ccree: remove unused pointer cc_base
@ 2017-11-09 8:13 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2017-11-09 8:13 UTC (permalink / raw)
To: Gilad Ben-Yossef, Greg Kroah-Hartman, linux-crypto,
driverdev-devel, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer cc_base is being assigned but is never read, hence it is
redundant and can be removed. Cleans up clang warning:
drivers/staging/ccree/ssi_driver.c:235:2: warning: Value stored to
'cc_base' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/ccree/ssi_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c
index 1a3c481fa92a..f4c0af8047e4 100644
--- a/drivers/staging/ccree/ssi_driver.c
+++ b/drivers/staging/ccree/ssi_driver.c
@@ -199,7 +199,6 @@ int init_cc_regs(struct ssi_drvdata *drvdata, bool is_probe)
static int init_cc_resources(struct platform_device *plat_dev)
{
struct resource *req_mem_cc_regs = NULL;
- void __iomem *cc_base = NULL;
struct ssi_drvdata *new_drvdata;
struct device *dev = &plat_dev->dev;
struct device_node *np = dev->of_node;
@@ -232,8 +231,6 @@ static int init_cc_resources(struct platform_device *plat_dev)
dev_dbg(dev, "CC registers mapped from %pa to 0x%p\n",
&req_mem_cc_regs->start, new_drvdata->cc_base);
- cc_base = new_drvdata->cc_base;
-
/* Then IRQ */
new_drvdata->irq = platform_get_irq(plat_dev, 0);
if (new_drvdata->irq < 0) {
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] staging: ccree: remove unused pointer cc_base
@ 2017-11-09 8:13 ` Colin King
0 siblings, 0 replies; 5+ messages in thread
From: Colin King @ 2017-11-09 8:13 UTC (permalink / raw)
To: Gilad Ben-Yossef, Greg Kroah-Hartman, linux-crypto,
driverdev-devel, devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Pointer cc_base is being assigned but is never read, hence it is
redundant and can be removed. Cleans up clang warning:
drivers/staging/ccree/ssi_driver.c:235:2: warning: Value stored to
'cc_base' is never read
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/ccree/ssi_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c
index 1a3c481fa92a..f4c0af8047e4 100644
--- a/drivers/staging/ccree/ssi_driver.c
+++ b/drivers/staging/ccree/ssi_driver.c
@@ -199,7 +199,6 @@ int init_cc_regs(struct ssi_drvdata *drvdata, bool is_probe)
static int init_cc_resources(struct platform_device *plat_dev)
{
struct resource *req_mem_cc_regs = NULL;
- void __iomem *cc_base = NULL;
struct ssi_drvdata *new_drvdata;
struct device *dev = &plat_dev->dev;
struct device_node *np = dev->of_node;
@@ -232,8 +231,6 @@ static int init_cc_resources(struct platform_device *plat_dev)
dev_dbg(dev, "CC registers mapped from %pa to 0x%p\n",
&req_mem_cc_regs->start, new_drvdata->cc_base);
- cc_base = new_drvdata->cc_base;
-
/* Then IRQ */
new_drvdata->irq = platform_get_irq(plat_dev, 0);
if (new_drvdata->irq < 0) {
--
2.14.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: ccree: remove unused pointer cc_base
2017-11-09 8:13 ` Colin King
(?)
@ 2017-11-09 9:21 ` Gilad Ben-Yossef
-1 siblings, 0 replies; 5+ messages in thread
From: Gilad Ben-Yossef @ 2017-11-09 9:21 UTC (permalink / raw)
To: Colin King
Cc: Greg Kroah-Hartman, Linux Crypto Mailing List, driverdev-devel,
devel, kernel-janitors, Linux kernel mailing list
Hi Colin,
Thank you very much for your patch.
On Thu, Nov 9, 2017 at 10:13 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer cc_base is being assigned but is never read, hence it is
> redundant and can be removed. Cleans up clang warning:
>
> drivers/staging/ccree/ssi_driver.c:235:2: warning: Value stored to
> 'cc_base' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/ccree/ssi_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
Your patch is perfectly fine but I just happened to send a patch
series that includes
this fix but also deals with other occurrences of the same now
no-longer needed cc_base
variable just a second ago before checking my email...
Sorry about that and thanks again.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: ccree: remove unused pointer cc_base
@ 2017-11-09 9:21 ` Gilad Ben-Yossef
0 siblings, 0 replies; 5+ messages in thread
From: Gilad Ben-Yossef @ 2017-11-09 9:21 UTC (permalink / raw)
To: Colin King
Cc: devel, Greg Kroah-Hartman, driverdev-devel, kernel-janitors,
Linux kernel mailing list, Linux Crypto Mailing List
Hi Colin,
Thank you very much for your patch.
On Thu, Nov 9, 2017 at 10:13 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer cc_base is being assigned but is never read, hence it is
> redundant and can be removed. Cleans up clang warning:
>
> drivers/staging/ccree/ssi_driver.c:235:2: warning: Value stored to
> 'cc_base' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/ccree/ssi_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
Your patch is perfectly fine but I just happened to send a patch
series that includes
this fix but also deals with other occurrences of the same now
no-longer needed cc_base
variable just a second ago before checking my email...
Sorry about that and thanks again.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: ccree: remove unused pointer cc_base
@ 2017-11-09 9:21 ` Gilad Ben-Yossef
0 siblings, 0 replies; 5+ messages in thread
From: Gilad Ben-Yossef @ 2017-11-09 9:21 UTC (permalink / raw)
To: Colin King
Cc: devel, Greg Kroah-Hartman, driverdev-devel, kernel-janitors,
Linux kernel mailing list, Linux Crypto Mailing List
Hi Colin,
Thank you very much for your patch.
On Thu, Nov 9, 2017 at 10:13 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer cc_base is being assigned but is never read, hence it is
> redundant and can be removed. Cleans up clang warning:
>
> drivers/staging/ccree/ssi_driver.c:235:2: warning: Value stored to
> 'cc_base' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/ccree/ssi_driver.c | 3 ---
> 1 file changed, 3 deletions(-)
Your patch is perfectly fine but I just happened to send a patch
series that includes
this fix but also deals with other occurrences of the same now
no-longer needed cc_base
variable just a second ago before checking my email...
Sorry about that and thanks again.
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-09 9:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 8:13 [PATCH] staging: ccree: remove unused pointer cc_base Colin King
2017-11-09 8:13 ` Colin King
2017-11-09 9:21 ` Gilad Ben-Yossef
2017-11-09 9:21 ` Gilad Ben-Yossef
2017-11-09 9:21 ` Gilad Ben-Yossef
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.