* [PATCH] perf buildid-cache: update help text for purge command
@ 2017-11-07 14:48 Thomas Richter
2017-11-09 19:16 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Richter @ 2017-11-07 14:48 UTC (permalink / raw)
To: acme, mhiramat, linux-perf-users; +Cc: brueckner, schwidefsky, tmricht
From: tmricht <tmricht@linux.vnet.ibm.com>
Clarify the perf buildid-cache help text for the purge operation.
The purge subcommand takes a list of files (binaries) as
option parameter. Make the wording the same as for the add
and remove operation.
Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
---
tools/perf/builtin-buildid-cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
index 9eba7f1add1f..ee4fdb458e26 100644
--- a/tools/perf/builtin-buildid-cache.c
+++ b/tools/perf/builtin-buildid-cache.c
@@ -307,8 +307,8 @@ int cmd_buildid_cache(int argc, const char **argv)
"file", "kcore file to add"),
OPT_STRING('r', "remove", &remove_name_list_str, "file list",
"file(s) to remove"),
- OPT_STRING('p', "purge", &purge_name_list_str, "path list",
- "path(s) to remove (remove old caches too)"),
+ OPT_STRING('p', "purge", &purge_name_list_str, "file list",
+ "file(s) to remove (remove old caches too)"),
OPT_STRING('M', "missing", &missing_filename, "file",
"to find missing build ids in the cache"),
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
--
2.13.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] perf buildid-cache: update help text for purge command
2017-11-07 14:48 [PATCH] perf buildid-cache: update help text for purge command Thomas Richter
@ 2017-11-09 19:16 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-11-09 19:16 UTC (permalink / raw)
To: Thomas Richter; +Cc: mhiramat, linux-perf-users, brueckner, schwidefsky
Em Tue, Nov 07, 2017 at 03:48:53PM +0100, Thomas Richter escreveu:
> From: tmricht <tmricht@linux.vnet.ibm.com>
>
> Clarify the perf buildid-cache help text for the purge operation.
> The purge subcommand takes a list of files (binaries) as
> option parameter. Make the wording the same as for the add
> and remove operation.
Thanks, applied.
- Arnaldo
> Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> Reviewed-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/perf/builtin-buildid-cache.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
> index 9eba7f1add1f..ee4fdb458e26 100644
> --- a/tools/perf/builtin-buildid-cache.c
> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -307,8 +307,8 @@ int cmd_buildid_cache(int argc, const char **argv)
> "file", "kcore file to add"),
> OPT_STRING('r', "remove", &remove_name_list_str, "file list",
> "file(s) to remove"),
> - OPT_STRING('p', "purge", &purge_name_list_str, "path list",
> - "path(s) to remove (remove old caches too)"),
> + OPT_STRING('p', "purge", &purge_name_list_str, "file list",
> + "file(s) to remove (remove old caches too)"),
> OPT_STRING('M', "missing", &missing_filename, "file",
> "to find missing build ids in the cache"),
> OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
> --
> 2.13.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] perf buildid-cache: update help text for purge command
2017-10-27 11:01 Thomas Richter
@ 2017-10-28 16:15 ` Masami Hiramatsu
0 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2017-10-28 16:15 UTC (permalink / raw)
To: Thomas Richter; +Cc: acme, linux-perf-users, brueckner
On Fri, 27 Oct 2017 13:01:26 +0200
Thomas Richter <tmricht@linux.vnet.ibm.com> wrote:
> Clarify the perf buildid-cache help text for the purge operation.
> The purge subcommand takes a list of files (binaries) as
> option parameter. Make the wording the same as for the add
> and remove operation.
>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
> Reviewed-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
> ---
> tools/perf/builtin-buildid-cache.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
> index bcd2b0e..04164d5 100644
> --- a/tools/perf/builtin-buildid-cache.c
> +++ b/tools/perf/builtin-buildid-cache.c
> @@ -336,8 +336,8 @@ int cmd_buildid_cache(int argc, const char **argv)
> "file", "kcore file to add"),
> OPT_STRING('r', "remove", &remove_name_list_str, "file list",
> "file(s) to remove"),
> - OPT_STRING('p', "purge", &purge_name_list_str, "path list",
> - "path(s) to remove (remove old caches too)"),
> + OPT_STRING('p', "purge", &purge_name_list_str, "file list",
> + "file(s) to remove (remove old caches too)"),
> OPT_STRING('M', "missing", &missing_filename, "file",
> "to find missing build ids in the cache"),
> OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
> --
> 2.9.4
>
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] perf buildid-cache: update help text for purge command
@ 2017-10-27 11:01 Thomas Richter
2017-10-28 16:15 ` Masami Hiramatsu
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Richter @ 2017-10-27 11:01 UTC (permalink / raw)
To: acme, linux-perf-users, mhiramat; +Cc: brueckner, Thomas Richter
Clarify the perf buildid-cache help text for the purge operation.
The purge subcommand takes a list of files (binaries) as
option parameter. Make the wording the same as for the add
and remove operation.
Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
---
tools/perf/builtin-buildid-cache.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-buildid-cache.c b/tools/perf/builtin-buildid-cache.c
index bcd2b0e..04164d5 100644
--- a/tools/perf/builtin-buildid-cache.c
+++ b/tools/perf/builtin-buildid-cache.c
@@ -336,8 +336,8 @@ int cmd_buildid_cache(int argc, const char **argv)
"file", "kcore file to add"),
OPT_STRING('r', "remove", &remove_name_list_str, "file list",
"file(s) to remove"),
- OPT_STRING('p', "purge", &purge_name_list_str, "path list",
- "path(s) to remove (remove old caches too)"),
+ OPT_STRING('p', "purge", &purge_name_list_str, "file list",
+ "file(s) to remove (remove old caches too)"),
OPT_STRING('M', "missing", &missing_filename, "file",
"to find missing build ids in the cache"),
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-09 19:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 14:48 [PATCH] perf buildid-cache: update help text for purge command Thomas Richter
2017-11-09 19:16 ` Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2017-10-27 11:01 Thomas Richter
2017-10-28 16:15 ` Masami Hiramatsu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.