* [PATCH v2] ath10k: Re-enable TXQs for all devices
@ 2017-11-10 0:48 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 8+ messages in thread
From: Toke Høiland-Jørgensen @ 2017-11-10 0:48 UTC (permalink / raw)
To: make-wifi-fast, linux-wireless, ath10k; +Cc: Toke Høiland-Jørgensen
Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the
mac80211 TXQs for some devices because of a theoretical throughput
regression. The original regression report[1] was related to fq_codel
qdisc drop performance, which was fixed in
9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen
the TXQ-related regression, so it should be safe to re-enable TXQs.
[1] http://lists.infradead.org/pipermail/ath10k/2016-April/007266.html
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
---
This has been in LEDE trunk for a couple of months now with good
results.
Changes since v1:
- Update commit message to refer to original report and the fix for it.
- Add ath10k list to cc
drivers/net/wireless/ath/ath10k/mac.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 0a947eef348d..ca596ecd2d64 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -8329,15 +8329,6 @@ int ath10k_mac_register(struct ath10k *ar)
ath10k_warn(ar, "failed to initialise DFS pattern detector\n");
}
- /* Current wake_tx_queue implementation imposes a significant
- * performance penalty in some setups. The tx scheduling code needs
- * more work anyway so disable the wake_tx_queue unless firmware
- * supports the pull-push mechanism.
- */
- if (!test_bit(ATH10K_FW_FEATURE_PEER_FLOW_CONTROL,
- ar->running_fw->fw_file.fw_features))
- ar->ops->wake_tx_queue = NULL;
-
ret = ath10k_mac_init_rd(ar);
if (ret) {
ath10k_err(ar, "failed to derive regdom: %d\n", ret);
--
2.15.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2] ath10k: Re-enable TXQs for all devices
@ 2017-11-10 0:48 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 8+ messages in thread
From: Toke Høiland-Jørgensen @ 2017-11-10 0:48 UTC (permalink / raw)
To: make-wifi-fast, linux-wireless, ath10k; +Cc: Toke Høiland-Jørgensen
Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the
mac80211 TXQs for some devices because of a theoretical throughput
regression. The original regression report[1] was related to fq_codel
qdisc drop performance, which was fixed in
9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen
the TXQ-related regression, so it should be safe to re-enable TXQs.
[1] http://lists.infradead.org/pipermail/ath10k/2016-April/007266.html
Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
---
This has been in LEDE trunk for a couple of months now with good
results.
Changes since v1:
- Update commit message to refer to original report and the fix for it.
- Add ath10k list to cc
drivers/net/wireless/ath/ath10k/mac.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 0a947eef348d..ca596ecd2d64 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -8329,15 +8329,6 @@ int ath10k_mac_register(struct ath10k *ar)
ath10k_warn(ar, "failed to initialise DFS pattern detector\n");
}
- /* Current wake_tx_queue implementation imposes a significant
- * performance penalty in some setups. The tx scheduling code needs
- * more work anyway so disable the wake_tx_queue unless firmware
- * supports the pull-push mechanism.
- */
- if (!test_bit(ATH10K_FW_FEATURE_PEER_FLOW_CONTROL,
- ar->running_fw->fw_file.fw_features))
- ar->ops->wake_tx_queue = NULL;
-
ret = ath10k_mac_init_rd(ar);
if (ret) {
ath10k_err(ar, "failed to derive regdom: %d\n", ret);
--
2.15.0
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ath10k: Re-enable TXQs for all devices
2017-11-10 0:48 ` Toke Høiland-Jørgensen
@ 2017-11-11 13:38 ` Felix Fietkau
-1 siblings, 0 replies; 8+ messages in thread
From: Felix Fietkau @ 2017-11-11 13:38 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, make-wifi-fast, linux-wireless, ath10k
On 2017-11-10 01:48, Toke Høiland-Jørgensen wrote:
> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the
> mac80211 TXQs for some devices because of a theoretical throughput
> regression. The original regression report[1] was related to fq_codel
> qdisc drop performance, which was fixed in
> 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen
> the TXQ-related regression, so it should be safe to re-enable TXQs.
That commit is unrelated to the fq/codel implementations in mac80211,
since mac80211 with txq does not use qdisc.
- Felix
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ath10k: Re-enable TXQs for all devices
@ 2017-11-11 13:38 ` Felix Fietkau
0 siblings, 0 replies; 8+ messages in thread
From: Felix Fietkau @ 2017-11-11 13:38 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, make-wifi-fast, linux-wireless, ath10k
On 2017-11-10 01:48, Toke Høiland-Jørgensen wrote:
> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the
> mac80211 TXQs for some devices because of a theoretical throughput
> regression. The original regression report[1] was related to fq_codel
> qdisc drop performance, which was fixed in
> 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen
> the TXQ-related regression, so it should be safe to re-enable TXQs.
That commit is unrelated to the fq/codel implementations in mac80211,
since mac80211 with txq does not use qdisc.
- Felix
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ath10k: Re-enable TXQs for all devices
2017-11-11 13:38 ` Felix Fietkau
@ 2017-11-12 14:40 ` Toke Høiland-Jørgensen
-1 siblings, 0 replies; 8+ messages in thread
From: Toke Høiland-Jørgensen @ 2017-11-12 14:40 UTC (permalink / raw)
To: Felix Fietkau, make-wifi-fast, linux-wireless, ath10k
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-11-10 01:48, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the
>> mac80211 TXQs for some devices because of a theoretical throughput
>> regression. The original regression report[1] was related to fq_codel
>> qdisc drop performance, which was fixed in
>> 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen
>> the TXQ-related regression, so it should be safe to re-enable TXQs.
> That commit is unrelated to the fq/codel implementations in mac80211,
> since mac80211 with txq does not use qdisc.
Yup. Which is why it's odd that the initial bug report referred to this;
that would indicate that the regression had nothing to do with TXQs in
the first place, and we could have merged this ages ago?
-Toke
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] ath10k: Re-enable TXQs for all devices
@ 2017-11-12 14:40 ` Toke Høiland-Jørgensen
0 siblings, 0 replies; 8+ messages in thread
From: Toke Høiland-Jørgensen @ 2017-11-12 14:40 UTC (permalink / raw)
To: Felix Fietkau, make-wifi-fast, linux-wireless, ath10k
Felix Fietkau <nbd@nbd.name> writes:
> On 2017-11-10 01:48, Toke Høiland-Jørgensen wrote:
>> Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the
>> mac80211 TXQs for some devices because of a theoretical throughput
>> regression. The original regression report[1] was related to fq_codel
>> qdisc drop performance, which was fixed in
>> 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen
>> the TXQ-related regression, so it should be safe to re-enable TXQs.
> That commit is unrelated to the fq/codel implementations in mac80211,
> since mac80211 with txq does not use qdisc.
Yup. Which is why it's odd that the initial bug report referred to this;
that would indicate that the regression had nothing to do with TXQs in
the first place, and we could have merged this ages ago?
-Toke
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v2] ath10k: Re-enable TXQs for all devices
2017-11-10 0:48 ` Toke Høiland-Jørgensen
@ 2017-12-02 14:14 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2017-12-02 14:14 UTC (permalink / raw)
To: Toke Høiland-Jørgensen
Cc: make-wifi-fast, linux-wireless, ath10k, Toke Høiland-Jørgensen
Toke Høiland-Jørgensen wrote:
> Commit 4ca1807815aa ("ath10k: disable wake_tx_queue for older devices")
> disables the use of the mac80211 TXQs for some devices because of a theoretical
> throughput regression. The original regression report[1] was related to
> fq_codel qdisc drop performance, which was fixed in commit 9d18562a2278
> ("fq_codel: add batch ability to fq_codel_drop()"). Since then, we have not
> seen the TXQ-related regression, so it should be safe to re-enable TXQs.
>
> [1] http://lists.infradead.org/pipermail/ath10k/2016-April/007266.html
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
170e8e6176d4 ath10k: re-enable TXQs for all devices
--
https://patchwork.kernel.org/patch/10052197/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [v2] ath10k: Re-enable TXQs for all devices
@ 2017-12-02 14:14 ` Kalle Valo
0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2017-12-02 14:14 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: make-wifi-fast, linux-wireless, ath10k
Toke Høiland-Jørgensen wrote:
> Commit 4ca1807815aa ("ath10k: disable wake_tx_queue for older devices")
> disables the use of the mac80211 TXQs for some devices because of a theoretical
> throughput regression. The original regression report[1] was related to
> fq_codel qdisc drop performance, which was fixed in commit 9d18562a2278
> ("fq_codel: add batch ability to fq_codel_drop()"). Since then, we have not
> seen the TXQ-related regression, so it should be safe to re-enable TXQs.
>
> [1] http://lists.infradead.org/pipermail/ath10k/2016-April/007266.html
>
> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
Patch applied to ath-next branch of ath.git, thanks.
170e8e6176d4 ath10k: re-enable TXQs for all devices
--
https://patchwork.kernel.org/patch/10052197/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-12-02 14:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-10 0:48 [PATCH v2] ath10k: Re-enable TXQs for all devices Toke Høiland-Jørgensen
2017-11-10 0:48 ` Toke Høiland-Jørgensen
2017-11-11 13:38 ` Felix Fietkau
2017-11-11 13:38 ` Felix Fietkau
2017-11-12 14:40 ` Toke Høiland-Jørgensen
2017-11-12 14:40 ` Toke Høiland-Jørgensen
2017-12-02 14:14 ` [v2] " Kalle Valo
2017-12-02 14:14 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.