Patches for rdma-core stable-v15

Patches for rdma-core stable-v15

[Nicolas Morey-Chaisemartin]

Hi all,

After looking into the ML, here are the candidates for the stable-v15 branch.
Can the authors please confirm that they should be applied there ?

Please let me know if I missed any.

Nicolas

---

Devesh Sharma (1):
      bnxt_re/lib: increment psn in case of 0 length packets

Hal Rosenstock (1):
      libibumad/umad.c: In get_port, ignore sysfs rate file errors

Jason Gunthorpe (1):
      verbs: Do not block QP attr_masks used by older kernels

Michael J. Ruhl (2):
      ibacm: Incorrect usage of BE byte order of MLID attach/detach_mcast()
      ibacm: Incorrect list used for subnet list causes a segfault

Ram Amrani (1):
      libqedr: fix inline data copy


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 2014 bytes --]

On Mon, Nov 13, 2017 at 04:02:26PM +0100, Nicolas Morey-Chaisemartin wrote:
> Hi all,
>
> After looking into the ML, here are the candidates for the stable-v15 branch.
> Can the authors please confirm that they should be applied there ?
>
> Please let me know if I missed any.

In addition to the your list, I would like to see the following patches too:
commit dbf7bd2151815a12428caef6874149523c0bda8e
Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date:   Wed Oct 25 12:04:53 2017 +0300

    verbs: Fix declaration of C++ include file in C-block

commit 6a74285158a146f23cbf8a804fd9de32df0d5ed2
Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date:   Mon Oct 9 10:56:21 2017 +0300

    verbs: Fix C++ compilation break

commit 983f80191923c082324295ea68ac91d34daaa4c8
Author: Nelio Laranjeiro <nelio.laranjeiro-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Date:   Tue Sep 26 16:05:11 2017 +0200

    verbs: fix compilation error with ICC

commit bf03566e0aa976afc5dfbf917296280e9fa55bb8
Author: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Date:   Mon Oct 2 04:17:09 2017 +0800

    hns: Fix create QP structure layout


Thanks

>
> Nicolas
>
> ---
>
> Devesh Sharma (1):
>       bnxt_re/lib: increment psn in case of 0 length packets
>
> Hal Rosenstock (1):
>       libibumad/umad.c: In get_port, ignore sysfs rate file errors
>
> Jason Gunthorpe (1):
>       verbs: Do not block QP attr_masks used by older kernels
>
> Michael J. Ruhl (2):
>       ibacm: Incorrect usage of BE byte order of MLID attach/detach_mcast()
>       ibacm: Incorrect list used for subnet list causes a segfault
>
> Ram Amrani (1):
>       libqedr: fix inline data copy
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Patches for rdma-core stable-v15

[Nicolas Morey-Chaisemartin]

Le 13/11/2017 à 16:14, Leon Romanovsky a écrit :
> On Mon, Nov 13, 2017 at 04:02:26PM +0100, Nicolas Morey-Chaisemartin wrote:
>> Hi all,
>>
>> After looking into the ML, here are the candidates for the stable-v15 branch.
>> Can the authors please confirm that they should be applied there ?
>>
>> Please let me know if I missed any.
> In addition to the your list, I would like to see the following patches too:
> commit dbf7bd2151815a12428caef6874149523c0bda8e
> Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date:   Wed Oct 25 12:04:53 2017 +0300
>
>     verbs: Fix declaration of C++ include file in C-block
>
> commit 6a74285158a146f23cbf8a804fd9de32df0d5ed2
> Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date:   Mon Oct 9 10:56:21 2017 +0300
>
>     verbs: Fix C++ compilation break
>
> commit 983f80191923c082324295ea68ac91d34daaa4c8
> Author: Nelio Laranjeiro <nelio.laranjeiro-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> Date:   Tue Sep 26 16:05:11 2017 +0200
>
>     verbs: fix compilation error with ICC
>
> commit bf03566e0aa976afc5dfbf917296280e9fa55bb8
> Author: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> Date:   Mon Oct 2 04:17:09 2017 +0800
>
>     hns: Fix create QP structure layout
>
>
> Thanks
>
>

Added to the list.
Should we backport the changes done for travis validation ?
It doesn't impact the code per say but it'd be nice to have the same validation running in the stable branch.

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1831 bytes --]

On Mon, Nov 13, 2017 at 05:19:46PM +0100, Nicolas Morey-Chaisemartin wrote:
>
>
> Le 13/11/2017 à 16:14, Leon Romanovsky a écrit :
> > On Mon, Nov 13, 2017 at 04:02:26PM +0100, Nicolas Morey-Chaisemartin wrote:
> >> Hi all,
> >>
> >> After looking into the ML, here are the candidates for the stable-v15 branch.
> >> Can the authors please confirm that they should be applied there ?
> >>
> >> Please let me know if I missed any.
> > In addition to the your list, I would like to see the following patches too:
> > commit dbf7bd2151815a12428caef6874149523c0bda8e
> > Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Date:   Wed Oct 25 12:04:53 2017 +0300
> >
> >     verbs: Fix declaration of C++ include file in C-block
> >
> > commit 6a74285158a146f23cbf8a804fd9de32df0d5ed2
> > Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Date:   Mon Oct 9 10:56:21 2017 +0300
> >
> >     verbs: Fix C++ compilation break
> >
> > commit 983f80191923c082324295ea68ac91d34daaa4c8
> > Author: Nelio Laranjeiro <nelio.laranjeiro-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> > Date:   Tue Sep 26 16:05:11 2017 +0200
> >
> >     verbs: fix compilation error with ICC
> >
> > commit bf03566e0aa976afc5dfbf917296280e9fa55bb8
> > Author: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> > Date:   Mon Oct 2 04:17:09 2017 +0800
> >
> >     hns: Fix create QP structure layout
> >
> >
> > Thanks
> >
> >
>
> Added to the list.
> Should we backport the changes done for travis validation ?
> It doesn't impact the code per say but it'd be nice to have the same validation running in the stable branch.

It depends on the easiest path: backport CI to stable, or teach main CI
to run for stable too.

Thanks

>
> Nicolas
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Patches for rdma-core stable-v15

[Devesh Sharma]

Hi Nicolas,

Please include following patch as well along with the one you have
listed already

bnxt_re/lib: fix the memory barrier call during poll-cq
commit-id: f4e67f1027011a6f9081b6239b866f27f750f678

-Regards
Devesh

On Mon, Nov 13, 2017 at 10:08 PM, Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Mon, Nov 13, 2017 at 05:19:46PM +0100, Nicolas Morey-Chaisemartin wrote:
>>
>>
>> Le 13/11/2017 à 16:14, Leon Romanovsky a écrit :
>> > On Mon, Nov 13, 2017 at 04:02:26PM +0100, Nicolas Morey-Chaisemartin wrote:
>> >> Hi all,
>> >>
>> >> After looking into the ML, here are the candidates for the stable-v15 branch.
>> >> Can the authors please confirm that they should be applied there ?
>> >>
>> >> Please let me know if I missed any.
>> > In addition to the your list, I would like to see the following patches too:
>> > commit dbf7bd2151815a12428caef6874149523c0bda8e
>> > Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> > Date:   Wed Oct 25 12:04:53 2017 +0300
>> >
>> >     verbs: Fix declaration of C++ include file in C-block
>> >
>> > commit 6a74285158a146f23cbf8a804fd9de32df0d5ed2
>> > Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> > Date:   Mon Oct 9 10:56:21 2017 +0300
>> >
>> >     verbs: Fix C++ compilation break
>> >
>> > commit 983f80191923c082324295ea68ac91d34daaa4c8
>> > Author: Nelio Laranjeiro <nelio.laranjeiro-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
>> > Date:   Tue Sep 26 16:05:11 2017 +0200
>> >
>> >     verbs: fix compilation error with ICC
>> >
>> > commit bf03566e0aa976afc5dfbf917296280e9fa55bb8
>> > Author: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>> > Date:   Mon Oct 2 04:17:09 2017 +0800
>> >
>> >     hns: Fix create QP structure layout
>> >
>> >
>> > Thanks
>> >
>> >
>>
>> Added to the list.
>> Should we backport the changes done for travis validation ?
>> It doesn't impact the code per say but it'd be nice to have the same validation running in the stable branch.
>
> It depends on the easiest path: backport CI to stable, or teach main CI
> to run for stable too.
>
> Thanks
>
>>
>> Nicolas
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Nicolas Morey-Chaisemartin]

Le 13/11/2017 à 18:02, Devesh Sharma a écrit :
> Hi Nicolas,
>
> Please include following patch as well along with the one you have
> listed already
>
> bnxt_re/lib: fix the memory barrier call during poll-cq
> commit-id: f4e67f1027011a6f9081b6239b866f27f750f678
>
> -Regards
> Devesh

Hi,

I saw some concern from Jason (didn't follow up the thread yet) about the barrier (even though it was in master already).
Did you come to an agreement on the current patch ?
If yes, I'll add it to the list.

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Devesh Sharma]

Yeah,

Jason is asking for further amendments to the barrier mechanism we
have today in rdma-core. That can be handled in a separate patch
series.
For now this should be good to go unless Jason suggests otherwise.

On Mon, Nov 13, 2017 at 10:36 PM, Nicolas Morey-Chaisemartin
<NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org> wrote:
>
>
> Le 13/11/2017 à 18:02, Devesh Sharma a écrit :
>> Hi Nicolas,
>>
>> Please include following patch as well along with the one you have
>> listed already
>>
>> bnxt_re/lib: fix the memory barrier call during poll-cq
>> commit-id: f4e67f1027011a6f9081b6239b866f27f750f678
>>
>> -Regards
>> Devesh
>
> Hi,
>
> I saw some concern from Jason (didn't follow up the thread yet) about the barrier (even though it was in master already).
> Did you come to an agreement on the current patch ?
> If yes, I'll add it to the list.
>
> Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Nicolas Morey-Chaisemartin]

Le 13/11/2017 à 17:38, Leon Romanovsky a écrit :
> On Mon, Nov 13, 2017 at 05:19:46PM +0100, Nicolas Morey-Chaisemartin wrote:
>> Added to the list.
>> Should we backport the changes done for travis validation ?
>> It doesn't impact the code per say but it'd be nice to have the same validation running in the stable branch.
> It depends on the easiest path: backport CI to stable, or teach main CI
> to run for stable too.
>
> Thanks

I've backported all the patches to run docker for centos and tumbleweed and it seems to work out of the box :)
https://travis-ci.org/nmorey/rdma-core/builds/301507907

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Jason Gunthorpe]

On Mon, Nov 13, 2017 at 10:56:44PM +0530, Devesh Sharma wrote:
> Yeah,
> 
> Jason is asking for further amendments to the barrier mechanism we
> have today in rdma-core. That can be handled in a separate patch
> series.  For now this should be good to go unless Jason suggests
> otherwise.

It should be fine as is. This is just something we should fix in
mainline to ensure we don't get burned by a newer compiler or
something.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Jason Gunthorpe]

On Mon, Nov 13, 2017 at 05:14:37PM +0200, Leon Romanovsky wrote:
> On Mon, Nov 13, 2017 at 04:02:26PM +0100, Nicolas Morey-Chaisemartin wrote:
> > Hi all,
> >
> > After looking into the ML, here are the candidates for the stable-v15 branch.
> > Can the authors please confirm that they should be applied there ?
> >
> > Please let me know if I missed any.
> 
> In addition to the your list, I would like to see the following patches too:
> commit dbf7bd2151815a12428caef6874149523c0bda8e
> Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date:   Wed Oct 25 12:04:53 2017 +0300
> 
>     verbs: Fix declaration of C++ include file in C-block
> 
> commit 6a74285158a146f23cbf8a804fd9de32df0d5ed2
> Author: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date:   Mon Oct 9 10:56:21 2017 +0300
> 
>     verbs: Fix C++ compilation break
> 
> commit 983f80191923c082324295ea68ac91d34daaa4c8
> Author: Nelio Laranjeiro <nelio.laranjeiro-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
> Date:   Tue Sep 26 16:05:11 2017 +0200
> 
>     verbs: fix compilation error with ICC
> 
> commit bf03566e0aa976afc5dfbf917296280e9fa55bb8
> Author: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> Date:   Mon Oct 2 04:17:09 2017 +0800
> 
>     hns: Fix create QP structure layout
> 
> 
> Thanks
> 
> >
> > Nicolas
> >
> >
> > Devesh Sharma (1):
> >       bnxt_re/lib: increment psn in case of 0 length packets
> >
> > Hal Rosenstock (1):
> >       libibumad/umad.c: In get_port, ignore sysfs rate file errors
> >
> > Jason Gunthorpe (1):
> >       verbs: Do not block QP attr_masks used by older kernels
> >
> > Michael J. Ruhl (2):
> >       ibacm: Incorrect usage of BE byte order of MLID attach/detach_mcast()
> >       ibacm: Incorrect list used for subnet list causes a segfault
> >
> > Ram Amrani (1):
> >       libqedr: fix inline data copy
> >

These all look sensible to me..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Patches for rdma-core stable-v15

[Amrani, Ram]

> Hi all,
> 
> After looking into the ML, here are the candidates for the stable-v15 branch.
> Can the authors please confirm that they should be applied there ?
> 
> Please let me know if I missed any.
> 
> Nicolas
> 
> ---

...

> Ram Amrani (1):
>       libqedr: fix inline data copy
> 


ACK

Thanks,
Ram

Re: Patches for rdma-core stable-v15

[Devesh Sharma]

Ack'ing following two patches :

> > Devesh Sharma (1):
> >       bnxt_re/lib: increment psn in case of 0 length packets

And

> Yeah,
>
> Jason is asking for further amendments to the barrier mechanism we
> have today in rdma-core. That can be handled in a separate patch
> series.  For now this should be good to go unless Jason suggests
> otherwise.

It should be fine as is. This is just something we should fix in
mainline to ensure we don't get burned by a newer compiler or
something.

bnxt_re/lib: fix the memory barrier call during poll-cq
commit-id: f4e67f1027011a6f9081b6239b866f27f750f678

On Tue, Nov 14, 2017 at 7:45 PM, Amrani, Ram <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org> wrote:
>> Hi all,
>>
>> After looking into the ML, here are the candidates for the stable-v15 branch.
>> Can the authors please confirm that they should be applied there ?
>>
>> Please let me know if I missed any.
>>
>> Nicolas
>>
>> ---
>
> ...
>
>> Ram Amrani (1):
>>       libqedr: fix inline data copy
>>
>
>
> ACK
>
> Thanks,
> Ram
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Nicolas Morey-Chaisemartin]

Le 14/11/2017 à 15:29, Devesh Sharma a écrit :
> Ack'ing following two patches :
>
>>> Devesh Sharma (1):
>>>       bnxt_re/lib: increment psn in case of 0 length packets
> And
>
>> Yeah,
>>
>> Jason is asking for further amendments to the barrier mechanism we
>> have today in rdma-core. That can be handled in a separate patch
>> series.  For now this should be good to go unless Jason suggests
>> otherwise.
> It should be fine as is. This is just something we should fix in
> mainline to ensure we don't get burned by a newer compiler or
> something.
>
> bnxt_re/lib: fix the memory barrier call during poll-cq
> commit-id: f4e67f1027011a6f9081b6239b866f27f750f678
>

Both picked in stable-v15.

Nicolas

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: Patches for rdma-core stable-v15

[Davis, Arlin R]

> I've backported all the patches to run docker for centos and tumbleweed and
> it seems to work out of the box :)
> https://travis-ci.org/nmorey/rdma-core/builds/301507907
> 

Are we ready for our first rdma-core stable-branch release? All fixes needed for OFED are now in stable-v15 so we are ready to wrap up the OFED 4.8-1 release.

Arlin

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Patches for rdma-core stable-v15

[Nicolas Morey-Chaisemartin]

Le 16/11/2017 à 22:57, Davis, Arlin R a écrit :
>> I've backported all the patches to run docker for centos and tumbleweed and
>> it seems to work out of the box :)
>> https://travis-ci.org/nmorey/rdma-core/builds/301507907
>>
> Are we ready for our first rdma-core stable-branch release? All fixes needed for OFED are now in stable-v15 so we are ready to wrap up the OFED 4.8-1 release.
>
> Arlin
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

The fix patches are all there.
I'd like to add the abi checks to the branch as soon as they are merged to master.
I've a branch ready to push changes to the buildlib/redhat/suse dir for validation in Travis.

Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html