From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: linux-kernel@vger.kernel.org, kan.liang@intel.com,
jolsa@redhat.com, namhyung@kernel.org
Subject: Re: [PATCH 5/7] perf tests: Set evlist of test__task_exit() to !overwrite
Date: Mon, 13 Nov 2017 15:32:28 -0300 [thread overview]
Message-ID: <20171113183228.GE8836@kernel.org> (raw)
In-Reply-To: <20171113013809.212417-6-wangnan0@huawei.com>
Em Mon, Nov 13, 2017 at 01:38:07AM +0000, Wang Nan escreveu:
> Changing ringbuffer to !overwrite in this task is harmless because
> this test uses a very low frequency (1) and using a very simple
> program (true). There should have only 3 events in the whole test.
> Overwriting is impossible to happen.
applied
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> ---
> tools/perf/tests/task-exit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/tests/task-exit.c b/tools/perf/tests/task-exit.c
> index f0881d0..4fb6609 100644
> --- a/tools/perf/tests/task-exit.c
> +++ b/tools/perf/tests/task-exit.c
> @@ -96,7 +96,7 @@ int test__task_exit(struct test *test __maybe_unused, int subtest __maybe_unused
> goto out_delete_evlist;
> }
>
> - if (perf_evlist__mmap(evlist, 128, true) < 0) {
> + if (perf_evlist__mmap(evlist, 128, false) < 0) {
> pr_debug("failed to mmap events: %d (%s)\n", errno,
> str_error_r(errno, sbuf, sizeof(sbuf)));
> goto out_delete_evlist;
> --
> 2.10.1
next prev parent reply other threads:[~2017-11-13 18:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 1:38 [PATCH 0/7] perf tools: Clarify overwrite and backward, bugfix Wang Nan
2017-11-13 1:38 ` [PATCH 1/7] perf mmap: Fix perf backward recording Wang Nan
2017-11-13 1:38 ` [PATCH 2/7] perf tests: Set evlist of test__backward_ring_buffer() to !overwrite Wang Nan
2017-11-13 18:30 ` Arnaldo Carvalho de Melo
2017-11-18 8:30 ` [tip:perf/core] " tip-bot for Wang Nan
2017-11-13 1:38 ` [PATCH 3/7] perf tests: Set evlist of test__sw_clock_freq() " Wang Nan
2017-11-13 18:31 ` Arnaldo Carvalho de Melo
2017-11-18 8:30 ` [tip:perf/core] " tip-bot for Wang Nan
2017-11-13 1:38 ` [PATCH 4/7] perf tests: Set evlist of test__basic_mmap() " Wang Nan
2017-11-13 18:31 ` Arnaldo Carvalho de Melo
2017-11-18 8:31 ` [tip:perf/core] " tip-bot for Wang Nan
2017-11-13 1:38 ` [PATCH 5/7] perf tests: Set evlist of test__task_exit() " Wang Nan
2017-11-13 18:32 ` Arnaldo Carvalho de Melo [this message]
2017-11-18 8:31 ` [tip:perf/core] " tip-bot for Wang Nan
2017-11-13 1:38 ` [PATCH 6/7] perf tools: Remove 'overwrite' concept from code level Wang Nan
2017-11-13 11:52 ` Jiri Olsa
2017-11-13 15:07 ` Liang, Kan
2017-11-13 1:38 ` [PATCH 7/7] perf tools: Remove prot field in mmap param Wang Nan
2017-11-13 11:52 ` Jiri Olsa
2017-11-13 11:52 ` Jiri Olsa
2017-11-13 14:49 ` [PATCH 0/7] perf tools: Clarify overwrite and backward, bugfix Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171113183228.GE8836@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.