* [PATCH V2] kdump: print a message in case parse_crashkernel_mem resulted in zero bytes
@ 2017-11-14 8:01 ` Dave Young
0 siblings, 0 replies; 2+ messages in thread
From: Dave Young @ 2017-11-14 8:01 UTC (permalink / raw)
To: kexec, linux-kernel; +Cc: akpm, bhe, vgoyal, bhsharma
In parse_crashkernel_mem, it silently return in case we get zero
bytes in the parsing function. It is useful for debugging for
adding a message especially sometimes kernel can not boot
up correctly.
Add a pr_info instead of pr_warn because it is expected behavior for
size = 0, eg. crashkernel=2G-4G:128M, size will be 0 in case system
memory is less than 2G.
Signed-off-by: Dave Young <dyoung@redhat.com>
---
[v1 -> v2]: bhsharma: pr_warn looks confusing because of return 0
kernel/crash_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-x86.orig/kernel/crash_core.c
+++ linux-x86/kernel/crash_core.c
@@ -108,7 +108,8 @@ static int __init parse_crashkernel_mem(
return -EINVAL;
}
}
- }
+ } else
+ pr_info("crashkernel size resulted in zero bytes\n");
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH V2] kdump: print a message in case parse_crashkernel_mem resulted in zero bytes
@ 2017-11-14 8:01 ` Dave Young
0 siblings, 0 replies; 2+ messages in thread
From: Dave Young @ 2017-11-14 8:01 UTC (permalink / raw)
To: kexec, linux-kernel; +Cc: akpm, bhsharma, vgoyal, bhe
In parse_crashkernel_mem, it silently return in case we get zero
bytes in the parsing function. It is useful for debugging for
adding a message especially sometimes kernel can not boot
up correctly.
Add a pr_info instead of pr_warn because it is expected behavior for
size = 0, eg. crashkernel=2G-4G:128M, size will be 0 in case system
memory is less than 2G.
Signed-off-by: Dave Young <dyoung@redhat.com>
---
[v1 -> v2]: bhsharma: pr_warn looks confusing because of return 0
kernel/crash_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- linux-x86.orig/kernel/crash_core.c
+++ linux-x86/kernel/crash_core.c
@@ -108,7 +108,8 @@ static int __init parse_crashkernel_mem(
return -EINVAL;
}
}
- }
+ } else
+ pr_info("crashkernel size resulted in zero bytes\n");
return 0;
}
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-14 8:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-14 8:01 [PATCH V2] kdump: print a message in case parse_crashkernel_mem resulted in zero bytes Dave Young
2017-11-14 8:01 ` Dave Young
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.