[PATCH rdma-core 0/3] Debian packaging fixes

[PATCH rdma-core 0/3] Debian packaging fixes

[Benjamin Drung]

rdma-core 15-1 was accepted in Debian unstable and it failed to build on some
architectures:
https://buildd.debian.org/status/package.php?p=rdma-core

This series tries to address some.


-- 
Benjamin Drung
System Developer
Debian & Ubuntu Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Email: benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org
URL: https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 1/3] debian: Do not build ibacm for non-Linux architectures

[Benjamin Drung]

rdma-core is tied to the Linux kernel. Thus we do not want to build it
on non-Linux architectures (like hurd-i386, kfreebsd-amd64, and
kfreebsd-i386). The build was tried on the non-Linux architectures,
because ibacm was marked to build on any architecture. Therefore also
mark ibacm as linux-any.
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index fef59ad5..5fee479c 100644
--- a/debian/control
+++ b/debian/control
@@ -44,7 +44,7 @@ Description: RDMA core userspace infrastructure and documentation
     standard socket interface.
 
 Package: ibacm
-Architecture: any
+Architecture: linux-any
 Depends: lsb-base (>= 3.2-14~),
          rdma-core (>= 15),
          ${misc:Depends},
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 2/3] debian: Do not require valgrind if not available

[Benjamin Drung]

valgrind is not available for all architectures. Since valgrind is an
optional build dependency, do not require it for those architectures.
---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index 5fee479c..c5f7a052 100644
--- a/debian/control
+++ b/debian/control
@@ -15,7 +15,7 @@ Build-Depends: cmake (>= 2.8.11),
                ninja-build,
                pkg-config,
                python,
-               valgrind
+               valgrind [!alpha !armel !hppa !m68k !powerpcspe !sh4 !sparc64]
 Standards-Version: 4.1.0
 Vcs-Git: https://github.com/linux-rdma/rdma-core.git
 Vcs-Browser: https://github.com/linux-rdma/rdma-core
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH rdma-core 3/3] debian: Update changelog to include Debian upload

[Benjamin Drung]

rdma-core 15-1 was accepted in Debian. Include the changelog from that
upload.
---
 debian/changelog | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 9ee7fe16..10ee3c7d 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,7 +1,14 @@
 rdma-core (16-1) unstable; urgency=low
 
-  * New version.
-  * Adding debian/copyright.
-  * Close ITP (Closes: #848971).
+  * New upstream release.
 
- -- Jason Gunthorpe <jgg-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>  Mon, 12 Sep 2016 13:44:24 -0600
+ -- Jason Gunthorpe <jgg-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>  Tue, 14 Nov 2017 12:24:09 +0100
+
+rdma-core (15-1) unstable; urgency=medium
+
+  * New upstream version. ibverbs-providers combines the source packages
+    libcxgb3, libipathverbs, libmlx4, libmlx5, libmthca, and libnes.
+    rdma-core also combines the source packages ibacm, libibcm, libibumad,
+    libibverbs, librdmacm, and srptools (Closes: #848971)
+
+ -- Benjamin Drung <benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>  Mon, 18 Sep 2017 11:00:39 +0200
-- 
2.14.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 0/3] Debian packaging fixes

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

On Tue, Nov 14, 2017 at 12:33:27PM +0100, Benjamin Drung wrote:
> rdma-core 15-1 was accepted in Debian unstable and it failed to build on some
> architectures:
> https://buildd.debian.org/status/package.php?p=rdma-core
>
> This series tries to address some.
>

Thanks, applied

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core 3/3] debian: Update changelog to include Debian upload

[Jason Gunthorpe]

On Tue, Nov 14, 2017 at 12:33:30PM +0100, Benjamin Drung wrote:
> rdma-core 15-1 was accepted in Debian. Include the changelog from that
> upload.

I was thinking we'd keep the distro changelogs some place else? We are
not going to try and store RH or suse changelogs for instance.

Not a big deal for this one, obviously.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/3] debian: Update changelog to include Debian upload

[Benjamin Drung]

Am Dienstag, den 14.11.2017, 13:28 -0700 schrieb Jason Gunthorpe:
> On Tue, Nov 14, 2017 at 12:33:30PM +0100, Benjamin Drung wrote:
> > rdma-core 15-1 was accepted in Debian. Include the changelog from
> > that
> > upload.
> 
> I was thinking we'd keep the distro changelogs some place else? We
> are
> not going to try and store RH or suse changelogs for instance.
> 
> Not a big deal for this one, obviously.

The advantage to include the changelog entries from Debian in the
master tree is that users can see that the packaging is the same and
that it is up-to-date. And user can see which version Debian package
version corresponds to the version from the master branch.

I can often find debian packaging from upstream projects that either
use their complete own packaging or a very outdated fork of the
packaging from Debian.

-- 
Benjamin Drung
System Developer
Debian & Ubuntu Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Email: benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org
URL: https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/3] debian: Update changelog to include Debian upload

[Jason Gunthorpe]

On Tue, Nov 14, 2017 at 09:34:06PM +0100, Benjamin Drung wrote:

> I can often find debian packaging from upstream projects that either
> use their complete own packaging or a very outdated fork of the
> packaging from Debian.

But it creates a technical problem, eg now that you are going to make
a -2, where will the changelog commit go?

Ideally the changelog commit should match the actual git tree that was
used to produce the debian source tar ball. Otherwise things start to
get very confusing :)

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/3] debian: Update changelog to include Debian upload

[Benjamin Drung]

Am Dienstag, den 14.11.2017, 13:42 -0700 schrieb Jason Gunthorpe:
> On Tue, Nov 14, 2017 at 09:34:06PM +0100, Benjamin Drung wrote:
> 
> > I can often find debian packaging from upstream projects that
> > either
> > use their complete own packaging or a very outdated fork of the
> > packaging from Debian.
> 
> But it creates a technical problem, eg now that you are going to make
> a -2, where will the changelog commit go?

When all commits for -2 are accepted in the master branch, I would
update debian/changelog to have the 15-2 entry between 15-1 and 16-1.

An alternative would be to just have one changelog entry in the master
branch and document the basis, e.g.:

rdma-core (16-1) unstable; urgency=low

  * New upstream release.
  * Packaging is based on rdma-core 15-2 from Debian
  * Downgrade debhelper to >= 9 to support Debian 7 & 8

 -- Jason Gunthorpe <jgg-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>  Tue, 14 Nov 2017 12:24:09 +0100

> Ideally the changelog commit should match the actual git tree that
> was
> used to produce the debian source tar ball. Otherwise things start to
> get very confusing :)
> 
> Jason
-- 
Benjamin Drung
System Developer
Debian & Ubuntu Developer

ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin

Email: benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org
URL: https://www.profitbricks.de

Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core 3/3] debian: Update changelog to include Debian upload

[Jason Gunthorpe]

On Wed, Nov 15, 2017 at 10:23:51AM +0100, Benjamin Drung wrote:

> When all commits for -2 are accepted in the master branch, I would
> update debian/changelog to have the 15-2 entry between 15-1 and 16-1.

Ok, lets try it like that

> An alternative would be to just have one changelog entry in the master
> branch and document the basis, e.g.:

This is closer to what I was originally thinking

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html