[PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels

[PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels

[Nicolas Morey-Chaisemartin]

At least the RDMA CM in 4.3 will give user space structs with these bits
set. Those kernels require user space to pass those set bits back to the
kernel. Blocking them causes RDMA CM to be unusable on older kernels.

Stable-fix: Drop changes to verbs.h of the original fix,
 that are not needed for the fix itself.

Fixes: 3ca7a1031486 ("ibverbs: Add support for packet pacing")
Commit-id: ce88cef301b ("verbs: Do not block QP attr_masks used by older kernels")
Reported-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Signed-off-by: Jason Gunthorpe <jgunthorpe-uk2M96/98Pc@public.gmane.org>
---

Backport from Jason's patch without the verbs.h changes to not modify the API.

 libibverbs/cmd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libibverbs/cmd.c b/libibverbs/cmd.c
index 9d2140fb..77aba334 100644
--- a/libibverbs/cmd.c
+++ b/libibverbs/cmd.c
@@ -1154,10 +1154,10 @@ int ibv_cmd_query_qp(struct ibv_qp *qp, struct ibv_qp_attr *attr,
 	struct ibv_query_qp_resp resp;
 
 	/*
-	 * Masks over IBV_QP_DEST_QPN are not supported by
-	 * that not extended command.
+	 * Starting with IBV_QP_RATE_LIMIT the attribute must go through the
+	 * _ex path.
 	 */
-	if (attr_mask & ~((IBV_QP_DEST_QPN << 1) - 1))
+	if (attr_mask & ~(IBV_QP_RATE_LIMIT - 1))
 		return EOPNOTSUPP;
 
 	IBV_INIT_CMD_RESP(cmd, cmd_size, QUERY_QP, &resp, sizeof resp);
@@ -1324,10 +1324,10 @@ int ibv_cmd_modify_qp(struct ibv_qp *qp, struct ibv_qp_attr *attr,
 		      struct ibv_modify_qp *cmd, size_t cmd_size)
 {
 	/*
-	 * Masks over IBV_QP_DEST_QPN are only supported by
-	 * ibv_cmd_modify_qp_ex.
+	 * Starting with IBV_QP_RATE_LIMIT the attribute must go through the
+	 * _ex path.
 	 */
-	if (attr_mask & ~((IBV_QP_DEST_QPN << 1) - 1))
+	if (attr_mask & ~(IBV_QP_RATE_LIMIT - 1))
 		return EOPNOTSUPP;
 
 	IBV_INIT_CMD(cmd, cmd_size, MODIFY_QP);
-- 
2.15.0.169.g3d3eebb67.dirty

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

On Tue, Nov 14, 2017 at 03:40:25PM +0100, Nicolas Morey-Chaisemartin wrote:
> At least the RDMA CM in 4.3 will give user space structs with these bits
> set. Those kernels require user space to pass those set bits back to the
> kernel. Blocking them causes RDMA CM to be unusable on older kernels.
>
> Stable-fix: Drop changes to verbs.h of the original fix,
>  that are not needed for the fix itself.
>
> Fixes: 3ca7a1031486 ("ibverbs: Add support for packet pacing")
> Commit-id: ce88cef301b ("verbs: Do not block QP attr_masks used by older kernels")
> Reported-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Jason Gunthorpe <jgunthorpe-uk2M96/98Pc@public.gmane.org>
> ---
>

You need to add your Signed-off-by.

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels

[Jason Gunthorpe]

On Tue, Nov 14, 2017 at 08:04:51PM +0200, Leon Romanovsky wrote:
> On Tue, Nov 14, 2017 at 03:40:25PM +0100, Nicolas Morey-Chaisemartin wrote:
> > At least the RDMA CM in 4.3 will give user space structs with these bits
> > set. Those kernels require user space to pass those set bits back to the
> > kernel. Blocking them causes RDMA CM to be unusable on older kernels.
> >
> > Stable-fix: Drop changes to verbs.h of the original fix,
> >  that are not needed for the fix itself.
> >
> > Fixes: 3ca7a1031486 ("ibverbs: Add support for packet pacing")
> > Commit-id: ce88cef301b ("verbs: Do not block QP attr_masks used by older kernels")
> > Reported-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> > Signed-off-by: Jason Gunthorpe <jgunthorpe-uk2M96/98Pc@public.gmane.org>
> >
> 
> You need to add your Signed-off-by.

And please add something like

    commit 9276717b9e297a62d1151a43d1cd286213f68eb7 upstream.

after the subject line for all patches ...

Edits look fine to me

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels

[Nicolas Morey-Chaisemartin]

Le 14/11/2017 à 19:49, Jason Gunthorpe a écrit :
> On Tue, Nov 14, 2017 at 08:04:51PM +0200, Leon Romanovsky wrote:
>> On Tue, Nov 14, 2017 at 03:40:25PM +0100, Nicolas Morey-Chaisemartin wrote:
>>> At least the RDMA CM in 4.3 will give user space structs with these bits
>>> set. Those kernels require user space to pass those set bits back to the
>>> kernel. Blocking them causes RDMA CM to be unusable on older kernels.
>>>
>>> Stable-fix: Drop changes to verbs.h of the original fix,
>>>  that are not needed for the fix itself.
>>>
>>> Fixes: 3ca7a1031486 ("ibverbs: Add support for packet pacing")
>>> Commit-id: ce88cef301b ("verbs: Do not block QP attr_masks used by older kernels")
>>> Reported-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
>>> Signed-off-by: Jason Gunthorpe <jgunthorpe-uk2M96/98Pc@public.gmane.org>
>>>
>> You need to add your Signed-off-by.
Yep. Will do when applying.

> And please add something like
>
>     commit 9276717b9e297a62d1151a43d1cd286213f68eb7 upstream.
>
> after the subject line for all patches ...

That's what the Commit-id is for :)
Do you prefer Upstream-commit-id ?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels

[Jason Gunthorpe]

On Tue, Nov 14, 2017 at 07:50:45PM +0100, Nicolas Morey-Chaisemartin wrote:
> 
> 
> Le 14/11/2017 à 19:49, Jason Gunthorpe a écrit :
> > On Tue, Nov 14, 2017 at 08:04:51PM +0200, Leon Romanovsky wrote:
> >> On Tue, Nov 14, 2017 at 03:40:25PM +0100, Nicolas Morey-Chaisemartin wrote:
> >>> At least the RDMA CM in 4.3 will give user space structs with these bits
> >>> set. Those kernels require user space to pass those set bits back to the
> >>> kernel. Blocking them causes RDMA CM to be unusable on older kernels.
> >>>
> >>> Stable-fix: Drop changes to verbs.h of the original fix,
> >>>  that are not needed for the fix itself.
> >>>
> >>> Fixes: 3ca7a1031486 ("ibverbs: Add support for packet pacing")
> >>> Commit-id: ce88cef301b ("verbs: Do not block QP attr_masks used by older kernels")
> >>> Reported-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> >>> Signed-off-by: Jason Gunthorpe <jgunthorpe-uk2M96/98Pc@public.gmane.org>
> >>>
> >> You need to add your Signed-off-by.
> Yep. Will do when applying.
> 
> > And please add something like
> >
> >     commit 9276717b9e297a62d1151a43d1cd286213f68eb7 upstream.
> >
> > after the subject line for all patches ...
> 
> That's what the Commit-id is for :)
> Do you prefer Upstream-commit-id ?

Oh! Yes, that seems fine as is then

Jason


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html