From: David Sterba <dsterba@suse.cz>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Cc: terrelln@fb.com
Subject: Re: Read before you deploy btrfs + zstd
Date: Wed, 15 Nov 2017 15:39:06 +0100 [thread overview]
Message-ID: <20171115143906.GM28899@twin.jikos.cz> (raw)
In-Reply-To: <20171114185331.GJ28899@twin.jikos.cz>
On Tue, Nov 14, 2017 at 07:53:31PM +0100, David Sterba wrote:
> On Mon, Nov 13, 2017 at 11:50:46PM +0100, David Sterba wrote:
> > Up to now, there are no bootloaders supporting ZSTD.
>
> I've tried to implement the support to GRUB, still incomplete and hacky
> but most of the code is there. The ZSTD implementation is copied from
> kernel. The allocators need to be properly set up, as it needs to use
> grub_malloc/grub_free for the workspace thats called from some ZSTD_*
> functions.
>
> https://github.com/kdave/grub/tree/btrfs-zstd
The branch is now in a state that can be tested. Turns out the memory
requirements are too much for grub, so the boot fails with "not enough
memory". The calculated value
ZSTD_BTRFS_MAX_INPUT: 131072
ZSTD_DStreamWorkspaceBound with ZSTD_BTRFS_MAX_INPUT: 549424
This is not something I could fix easily, we'd probalby need a tuned
version of ZSTD for grub constraints. Adding Nick to CC.
next prev parent reply other threads:[~2017-11-15 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 22:50 Read before you deploy btrfs + zstd David Sterba
2017-11-14 7:34 ` Martin Steigerwald
2017-11-14 9:45 ` Paul Jones
2017-11-14 12:38 ` Austin S. Hemmelgarn
2017-11-15 20:23 ` Duncan
2017-11-16 14:31 ` Dmitrii Tcvetkov
2017-11-14 18:49 ` David Sterba
2017-11-14 19:43 ` Martin Steigerwald
2017-11-14 18:53 ` David Sterba
2017-11-15 14:39 ` David Sterba [this message]
2017-11-15 16:22 ` Martin Steigerwald
2017-11-15 18:16 ` Imran Geriskovan
2017-11-15 20:06 ` Duncan
2017-11-15 20:09 ` Nick Terrell
2017-11-21 16:22 ` David Sterba
2017-11-28 21:31 ` Nick Terrell
2017-11-28 23:49 ` David Sterba
2017-11-29 0:44 ` Nick Terrell
2017-12-05 15:54 ` David Sterba
2017-12-05 20:36 ` Nick Terrell
2017-11-29 13:24 ` Austin S. Hemmelgarn
2017-11-29 19:29 ` Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115143906.GM28899@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=terrelln@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.