All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Nick Terrell <terrelln@fb.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
	Martin Steigerwald <martin@lichtvoll.de>,
	Imran Geriskovan <imran.geriskovan@gmail.com>
Subject: Re: Read before you deploy btrfs + zstd
Date: Tue, 21 Nov 2017 17:22:39 +0100	[thread overview]
Message-ID: <20171121162239.GO3553@suse.cz> (raw)
In-Reply-To: <E55ED8F2-8D16-4B58-9EC3-8DE41E7BE5A2@fb.com>

On Wed, Nov 15, 2017 at 08:09:15PM +0000, Nick Terrell wrote:
> On 11/15/17, 6:41 AM, "David Sterba" <dsterba@suse.cz> wrote:
> > The branch is now in a state that can be tested. Turns out the memory
> > requirements are too much for grub, so the boot fails with "not enough
> > memory". The calculated value
> >
> > ZSTD_BTRFS_MAX_INPUT: 131072
> > ZSTD_DStreamWorkspaceBound with ZSTD_BTRFS_MAX_INPUT: 549424
> >
> > This is not something I could fix easily, we'd probalby need a tuned
> > version of ZSTD for grub constraints. Adding Nick to CC.
> 
> If I understand the grub code correctly, we only need to read, and we have
> the entire input and output buffer in one segment. In that case you can use
> ZSTD_initDCtx(), and ZSTD_decompressDCtx(). ZSTD_DCtxWorkspaceBound() is
> only 155984. See decompress_single() in
> https://patchwork.kernel.org/patch/9997909/ for an example.

Does not help, still ENOMEM.

  reply	other threads:[~2017-11-21 16:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 22:50 Read before you deploy btrfs + zstd David Sterba
2017-11-14  7:34 ` Martin Steigerwald
2017-11-14  9:45   ` Paul Jones
2017-11-14 12:38   ` Austin S. Hemmelgarn
2017-11-15 20:23     ` Duncan
2017-11-16 14:31       ` Dmitrii Tcvetkov
2017-11-14 18:49   ` David Sterba
2017-11-14 19:43     ` Martin Steigerwald
2017-11-14 18:53 ` David Sterba
2017-11-15 14:39   ` David Sterba
2017-11-15 16:22     ` Martin Steigerwald
2017-11-15 18:16       ` Imran Geriskovan
2017-11-15 20:06         ` Duncan
2017-11-15 20:09     ` Nick Terrell
2017-11-21 16:22       ` David Sterba [this message]
2017-11-28 21:31         ` Nick Terrell
2017-11-28 23:49           ` David Sterba
2017-11-29  0:44             ` Nick Terrell
2017-12-05 15:54               ` David Sterba
2017-12-05 20:36                 ` Nick Terrell
2017-11-29 13:24             ` Austin S. Hemmelgarn
2017-11-29 19:29               ` Andrei Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171121162239.GO3553@suse.cz \
    --to=dsterba@suse.cz \
    --cc=imran.geriskovan@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=martin@lichtvoll.de \
    --cc=terrelln@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.