All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@caviumnetworks.com>
To: Sami Tolvanen <samitolvanen@google.com>
Cc: Alex Matveev <alxmtvv@gmail.com>, Andi Kleen <ak@linux.intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Greg Hackmann <ghackmann@google.com>,
	Kees Cook <keescook@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v2 00/18] Add support for clang LTO
Date: Thu, 16 Nov 2017 23:53:00 +0300	[thread overview]
Message-ID: <20171116205300.5p3vjjqouw3prr3t@yury-thinkpad> (raw)
In-Reply-To: <20171115213428.22559-1-samitolvanen@google.com>

On Wed, Nov 15, 2017 at 01:34:10PM -0800, Sami Tolvanen wrote:
> This series adds build system support for compiling the kernel with clang
> Link Time Optimization (LTO), using GNU gold with the LLVMgold plug-in
> for linking. Some background for clang's LTO support is available here:
> 
>   https://llvm.org/docs/LinkTimeOptimization.html
> 
> With -flto, clang produces LLVM bitcode instead of object files, and
> the compilation to native code happens at link time. In addition, clang
> cannot use an external assembler for inline assembly when LTO is enabled,
> which causes further compatibility issues.
> 
> The patches in this series remove intermediate linking steps when LTO is
> used, postpone processing done on object files until after the LTO link
> step, add workarounds for GNU gold incompatibilities, and address inline
> assembly incompatibilities for arm64.
> 
> These changes allow arm64 defconfig to be compiled with LTO, but other
> architectures are not enabled until compatibility issues have been
> addressed. In particular, x86 inline assembly doesn't currently compile
> with clang's integrated assembler due to this LLVM bug:
> 
>   https://bugs.llvm.org/show_bug.cgi?id=24487
> 
> Due to recent bug fixes in the toolchain, it's recommended to use clang
> 5.0 or later, and GNU gold from binutils 2.27 or later, although older
> versions may also work depending on your kernel configuration.

So, you don't guarantee that kernel will work with old compiler and
toolchain? If so, I would suggest you to add the patch that checks
their versions and disables LTO if needed.

Yury

WARNING: multiple messages have this Message-ID (diff)
From: ynorov@caviumnetworks.com (Yury Norov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/18] Add support for clang LTO
Date: Thu, 16 Nov 2017 23:53:00 +0300	[thread overview]
Message-ID: <20171116205300.5p3vjjqouw3prr3t@yury-thinkpad> (raw)
In-Reply-To: <20171115213428.22559-1-samitolvanen@google.com>

On Wed, Nov 15, 2017 at 01:34:10PM -0800, Sami Tolvanen wrote:
> This series adds build system support for compiling the kernel with clang
> Link Time Optimization (LTO), using GNU gold with the LLVMgold plug-in
> for linking. Some background for clang's LTO support is available here:
> 
>   https://llvm.org/docs/LinkTimeOptimization.html
> 
> With -flto, clang produces LLVM bitcode instead of object files, and
> the compilation to native code happens at link time. In addition, clang
> cannot use an external assembler for inline assembly when LTO is enabled,
> which causes further compatibility issues.
> 
> The patches in this series remove intermediate linking steps when LTO is
> used, postpone processing done on object files until after the LTO link
> step, add workarounds for GNU gold incompatibilities, and address inline
> assembly incompatibilities for arm64.
> 
> These changes allow arm64 defconfig to be compiled with LTO, but other
> architectures are not enabled until compatibility issues have been
> addressed. In particular, x86 inline assembly doesn't currently compile
> with clang's integrated assembler due to this LLVM bug:
> 
>   https://bugs.llvm.org/show_bug.cgi?id=24487
> 
> Due to recent bug fixes in the toolchain, it's recommended to use clang
> 5.0 or later, and GNU gold from binutils 2.27 or later, although older
> versions may also work depending on your kernel configuration.

So, you don't guarantee that kernel will work with old compiler and
toolchain? If so, I would suggest you to add the patch that checks
their versions and disables LTO if needed.

Yury

  parent reply	other threads:[~2017-11-16 20:53 UTC|newest]

Thread overview: 226+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-15 21:34 [PATCH v2 00/18] Add support for clang LTO Sami Tolvanen
2017-11-15 21:34 ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 01/18] kbuild: add ld-name macro and support for GNU gold Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:53   ` Kees Cook
2017-11-15 21:53     ` Kees Cook
2017-11-15 21:34 ` [PATCH v2 02/18] kbuild: fix LD_DEAD_CODE_DATA_ELIMINATION with " Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 03/18] kbuild: move gcc-version.sh to cc-version.sh and add clang support Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:48   ` Kees Cook
2017-11-15 21:48     ` Kees Cook
2017-11-15 22:06     ` Sami Tolvanen
2017-11-15 22:06       ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 04/18] arm64: use -mno-implicit-float instead of -mgeneral-regs-only Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 05/18] arm64: fix -m for GNU gold Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-16 10:55   ` Yury Norov
2017-11-16 10:55     ` Yury Norov
2017-11-16 16:55     ` Nick Desaulniers
2017-11-16 16:55       ` Nick Desaulniers
2017-11-15 21:34 ` [PATCH v2 06/18] arm64: kvm: use -fno-jump-tables with clang Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-16 11:46   ` Will Deacon
2017-11-16 11:46     ` Will Deacon
2017-11-16 16:25     ` Sami Tolvanen
2017-11-16 16:25       ` Sami Tolvanen
2017-11-20 14:41   ` Mark Rutland
2017-11-20 14:41     ` Mark Rutland
2017-11-20 14:43     ` Mark Rutland
2017-11-20 14:43       ` Mark Rutland
2017-11-20 14:47       ` Ard Biesheuvel
2017-11-20 14:47         ` Ard Biesheuvel
2017-11-20 14:47         ` Ard Biesheuvel
2017-11-15 21:34 ` [PATCH v2 07/18] arm64: keep .altinstructions and .altinstr_replacement Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 08/18] arm64: don't disable ADR_PREL_PG_HI21* with ARM64_ERRATUM_843419 Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 22:29   ` Ard Biesheuvel
2017-11-15 22:29     ` Ard Biesheuvel
2017-11-15 22:29     ` Ard Biesheuvel
2017-11-16 11:44     ` Will Deacon
2017-11-16 11:44       ` Will Deacon
2017-11-16 11:44       ` Will Deacon
2017-11-16 16:32       ` Sami Tolvanen
2017-11-16 16:32         ` Sami Tolvanen
2017-11-16 16:32         ` Sami Tolvanen
2017-11-16 16:34         ` Ard Biesheuvel
2017-11-16 16:34           ` Ard Biesheuvel
2017-11-16 16:34           ` Ard Biesheuvel
2017-11-16 21:37           ` Sami Tolvanen
2017-11-16 21:37             ` Sami Tolvanen
2017-11-16 21:37             ` Sami Tolvanen
2017-11-16 22:14             ` Ard Biesheuvel
2017-11-16 22:14               ` Ard Biesheuvel
2017-11-16 22:14               ` Ard Biesheuvel
2017-11-16 22:25               ` Ard Biesheuvel
2017-11-16 22:25                 ` Ard Biesheuvel
2017-11-16 22:25                 ` Ard Biesheuvel
2017-11-16 23:09               ` Sami Tolvanen
2017-11-16 23:09                 ` Sami Tolvanen
2017-11-16 23:09                 ` Sami Tolvanen
2017-11-16 23:20                 ` Ard Biesheuvel
2017-11-16 23:20                   ` Ard Biesheuvel
2017-11-16 23:20                   ` Ard Biesheuvel
2017-11-16 23:50                   ` Sami Tolvanen
2017-11-16 23:50                     ` Sami Tolvanen
2017-11-16 23:50                     ` Sami Tolvanen
2017-11-17  9:54                     ` Ard Biesheuvel
2017-11-17  9:54                       ` Ard Biesheuvel
2017-11-17  9:54                       ` Ard Biesheuvel
2017-11-17 18:49                       ` Sami Tolvanen
2017-11-17 18:49                         ` Sami Tolvanen
2017-11-17 18:49                         ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 09/18] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-16 11:47   ` Will Deacon
2017-11-16 11:47     ` Will Deacon
2017-11-16 16:35     ` Sami Tolvanen
2017-11-16 16:35       ` Sami Tolvanen
2017-11-20 14:47       ` Mark Rutland
2017-11-20 14:47         ` Mark Rutland
2017-11-20 20:35         ` Sami Tolvanen
2017-11-20 20:35           ` Sami Tolvanen
2017-11-21 11:15           ` Mark Rutland
2017-11-21 11:15             ` Mark Rutland
2017-11-15 21:34 ` [PATCH v2 10/18] arm64: add a workaround for GNU gold with ARM64_MODULE_PLTS Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-16 11:50   ` Will Deacon
2017-11-16 11:50     ` Will Deacon
2017-11-16 16:41     ` Sami Tolvanen
2017-11-16 16:41       ` Sami Tolvanen
2017-11-16 18:47       ` Will Deacon
2017-11-16 18:47         ` Will Deacon
2017-11-15 21:34 ` [PATCH v2 11/18] arm64: make mrs_s and msr_s macros work with LTO Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-16 11:54   ` Will Deacon
2017-11-16 11:54     ` Will Deacon
2017-11-16 13:07     ` Yury Norov
2017-11-16 13:07       ` Yury Norov
2017-11-16 13:55       ` Robin Murphy
2017-11-16 13:55         ` Robin Murphy
2017-11-16 21:29         ` Yury Norov
2017-11-16 21:29           ` Yury Norov
2017-11-16 22:54           ` Alex Matveev
2017-11-16 22:54             ` Alex Matveev
2017-12-04 17:34             ` Nick Desaulniers
2017-12-04 17:34               ` Nick Desaulniers
2017-11-16 13:56       ` Segher Boessenkool
2017-11-16 13:56         ` Segher Boessenkool
2017-11-16 16:46         ` Sami Tolvanen
2017-11-16 16:46           ` Sami Tolvanen
2017-11-16 17:01           ` Segher Boessenkool
2017-11-16 17:01             ` Segher Boessenkool
2017-11-16 17:11             ` Sami Tolvanen
2017-11-16 17:11               ` Sami Tolvanen
2017-11-16 16:43     ` Sami Tolvanen
2017-11-16 16:43       ` Sami Tolvanen
2017-11-16 16:44       ` Nick Desaulniers
2017-11-16 16:44         ` Nick Desaulniers
2017-11-16 18:14     ` Alex Matveev
2017-11-16 18:14       ` Alex Matveev
2017-11-15 21:34 ` [PATCH v2 12/18] kbuild: add support for clang LTO Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 22:06   ` Kees Cook
2017-11-15 22:06     ` Kees Cook
2017-11-18  3:21   ` [v2,12/18] " Nicholas Piggin
2017-11-18  3:21     ` Nicholas Piggin
2017-11-20 20:21     ` Sami Tolvanen
2017-11-20 20:21       ` Sami Tolvanen
2017-11-21  1:01       ` Nicholas Piggin
2017-11-21  1:01         ` Nicholas Piggin
2017-11-29 23:30         ` Sami Tolvanen
2017-11-29 23:30           ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 13/18] kbuild: fix dynamic ftrace with " Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 14/18] scripts/mod: disable LTO for empty.c Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 15/18] efi/libstub: disable LTO Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 16/18] arm64: crypto: disable LTO for aes-ce-cipher.c Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-20 15:20   ` Mark Rutland
2017-11-20 15:20     ` Mark Rutland
2017-11-20 15:25     ` Ard Biesheuvel
2017-11-20 15:25       ` Ard Biesheuvel
2017-11-20 15:25       ` Ard Biesheuvel
2017-11-20 21:01       ` Sami Tolvanen
2017-11-20 21:01         ` Sami Tolvanen
2017-11-20 21:01         ` Sami Tolvanen
2017-11-21 11:47         ` Mark Rutland
2017-11-21 11:47           ` Mark Rutland
2017-11-21 11:47           ` Mark Rutland
2017-11-20 20:51     ` Sami Tolvanen
2017-11-20 20:51       ` Sami Tolvanen
2017-11-20 21:29     ` Alex Matveev
2017-11-20 21:29       ` Alex Matveev
2017-11-20 21:31       ` Ard Biesheuvel
2017-11-20 21:31         ` Ard Biesheuvel
2017-11-20 21:31         ` Ard Biesheuvel
2017-11-20 22:03         ` Alex Matveev
2017-11-20 22:03           ` Alex Matveev
2017-11-20 22:03           ` Alex Matveev
2017-11-15 21:34 ` [PATCH v2 17/18] arm64: disable RANDOMIZE_MODULE_REGION_FULL with LTO_CLANG Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-15 21:34 ` [PATCH v2 18/18] arm64: select ARCH_SUPPORTS_LTO_CLANG Sami Tolvanen
2017-11-15 21:34   ` Sami Tolvanen
2017-11-16 11:58   ` Will Deacon
2017-11-16 11:58     ` Will Deacon
2017-11-16 16:17     ` Sami Tolvanen
2017-11-16 16:17       ` Sami Tolvanen
2017-11-16 16:30       ` Peter Zijlstra
2017-11-16 16:30         ` Peter Zijlstra
2017-11-16 16:50         ` Nick Desaulniers
2017-11-16 16:50           ` Nick Desaulniers
2017-11-16 16:59           ` Peter Zijlstra
2017-11-16 16:59             ` Peter Zijlstra
2017-11-16 17:16             ` Nick Desaulniers
2017-11-16 17:16               ` Nick Desaulniers
2017-11-16 17:34               ` Peter Zijlstra
2017-11-16 17:34                 ` Peter Zijlstra
2017-11-16 17:48                 ` Paul E. McKenney
2017-11-16 17:48                   ` Paul E. McKenney
2017-11-16 18:16                   ` Nick Desaulniers
2017-11-16 18:16                     ` Nick Desaulniers
2017-11-16 18:39                     ` Paul E. McKenney
2017-11-16 18:39                       ` Paul E. McKenney
2017-11-16 18:45                       ` Will Deacon
2017-11-16 18:45                         ` Will Deacon
2017-11-16 19:13                         ` Paul E. McKenney
2017-11-16 19:13                           ` Paul E. McKenney
2017-11-16 20:17                           ` Sami Tolvanen
2017-11-16 20:17                             ` Sami Tolvanen
2017-11-20 18:05                             ` Will Deacon
2017-11-20 18:05                               ` Will Deacon
2017-11-20 19:25                               ` Peter Zijlstra
2017-11-20 19:25                                 ` Peter Zijlstra
2017-11-20 19:28                               ` Peter Zijlstra
2017-11-20 19:28                                 ` Peter Zijlstra
2017-11-20 20:52                                 ` Paul E. McKenney
2017-11-20 20:52                                   ` Paul E. McKenney
2017-11-20 19:32                               ` Peter Zijlstra
2017-11-20 19:32                                 ` Peter Zijlstra
2017-11-20 20:53                                 ` Paul E. McKenney
2017-11-20 20:53                                   ` Paul E. McKenney
2017-11-21 17:23                                   ` David Laight
2017-11-21 17:23                                     ` David Laight
2017-11-21 17:23                                     ` David Laight
2017-11-21 18:51                                     ` Paul E. McKenney
2017-11-21 18:51                                       ` Paul E. McKenney
2017-11-21 18:51                                       ` Paul E. McKenney
2017-11-23 13:42                     ` Alexander Potapenko
2017-11-23 13:42                       ` Alexander Potapenko
2017-11-24  7:52                       ` Dmitry Vyukov
2017-11-24  7:52                         ` Dmitry Vyukov
2017-11-16 20:53 ` Yury Norov [this message]
2017-11-16 20:53   ` [PATCH v2 00/18] Add support for clang LTO Yury Norov
2017-11-16 21:38   ` Sami Tolvanen
2017-11-16 21:38     ` Sami Tolvanen
2017-11-20 15:21 ` Mark Rutland
2017-11-20 15:21   ` Mark Rutland
2017-11-20 21:04   ` Sami Tolvanen
2017-11-20 21:04     ` Sami Tolvanen
2017-11-21 11:53     ` Mark Rutland
2017-11-21 11:53       ` Mark Rutland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116205300.5p3vjjqouw3prr3t@yury-thinkpad \
    --to=ynorov@caviumnetworks.com \
    --cc=ak@linux.intel.com \
    --cc=alxmtvv@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=ghackmann@google.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=michal.lkml@markovi.net \
    --cc=mka@chromium.org \
    --cc=ndesaulniers@google.com \
    --cc=samitolvanen@google.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.