All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, matthias.bgg@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5 v2] ASoC: nuc900: Fix platform_get_irq's error checking
Date: Sat, 18 Nov 2017 08:18:25 +0000	[thread overview]
Message-ID: <20171118081825.GU31757@n2100.armlinux.org.uk> (raw)
In-Reply-To: <19f8c64a4720118a6d6c4fedd5f8defa6938d1db.1510982440.git.arvind.yadav.cs@gmail.com>

On Sat, Nov 18, 2017 at 10:57:53AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.

IRQ 0 is not a valid interrupt.  The correct test here is <= 0.
Please rework your patches for this.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	tiwai@suse.com, lgirdwood@gmail.com, broonie@kernel.org,
	linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
	perex@perex.cz, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5 v2] ASoC: nuc900: Fix platform_get_irq's error checking
Date: Sat, 18 Nov 2017 08:18:25 +0000	[thread overview]
Message-ID: <20171118081825.GU31757@n2100.armlinux.org.uk> (raw)
In-Reply-To: <19f8c64a4720118a6d6c4fedd5f8defa6938d1db.1510982440.git.arvind.yadav.cs@gmail.com>

On Sat, Nov 18, 2017 at 10:57:53AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.

IRQ 0 is not a valid interrupt.  The correct test here is <= 0.
Please rework your patches for this.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5 v2] ASoC: nuc900: Fix platform_get_irq's error checking
Date: Sat, 18 Nov 2017 08:18:25 +0000	[thread overview]
Message-ID: <20171118081825.GU31757@n2100.armlinux.org.uk> (raw)
In-Reply-To: <19f8c64a4720118a6d6c4fedd5f8defa6938d1db.1510982440.git.arvind.yadav.cs@gmail.com>

On Sat, Nov 18, 2017 at 10:57:53AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.

IRQ 0 is not a valid interrupt.  The correct test here is <= 0.
Please rework your patches for this.

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync@8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

  reply	other threads:[~2017-11-18  8:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-18  5:27 [PATCH 1/5 v2] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking Arvind Yadav
2017-11-18  5:27 ` Arvind Yadav
2017-11-18  5:27 ` Arvind Yadav
2017-11-18  5:27 ` [PATCH 2/5 v2] ASoC: mt8173: " Arvind Yadav
2017-11-18  5:27   ` Arvind Yadav
2017-11-18  5:27   ` Arvind Yadav
2017-11-18  8:18   ` Russell King - ARM Linux
2017-11-18  8:18     ` Russell King - ARM Linux
2017-11-18  8:18     ` Russell King - ARM Linux
2017-11-18  5:27 ` [PATCH 3/5 v2] ASoC: nuc900: " Arvind Yadav
2017-11-18  5:27   ` Arvind Yadav
2017-11-18  5:27   ` Arvind Yadav
2017-11-18  8:18   ` Russell King - ARM Linux [this message]
2017-11-18  8:18     ` Russell King - ARM Linux
2017-11-18  8:18     ` Russell King - ARM Linux
2017-11-18  8:17 ` [PATCH 1/5 v2] ASoC: ep93xx-ac97: " Russell King - ARM Linux
2017-11-18  8:17   ` Russell King - ARM Linux
2017-11-18  8:17   ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171118081825.GU31757@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=alsa-devel@alsa-project.org \
    --cc=arvind.yadav.cs@gmail.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.