* [PATCH] e1000: Fix off-by-one in debug message
@ 2017-11-18 20:53 ` Ahmad Fatoum
0 siblings, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2017-11-18 20:53 UTC (permalink / raw)
To: jeffrey.t.kirsher; +Cc: intel-wired-lan, netdev, Ahmad Fatoum
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c
index 8172cf08cc33..ba04a65d8500 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_hw.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c
@@ -4307,8 +4307,8 @@ static void e1000_init_rx_addrs(struct e1000_hw *hw)
rar_num = E1000_RAR_ENTRIES;
- /* Zero out the other 15 receive addresses. */
- e_dbg("Clearing RAR[1-15]\n");
+ /* Zero out the following 14 receive addresses. RAR[15] is for manageability */
+ e_dbg("Clearing RAR[1-14]\n");
for (i = 1; i < rar_num; i++) {
E1000_WRITE_REG_ARRAY(hw, RA, (i << 1), 0);
E1000_WRITE_FLUSH();
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] e1000: Fix off-by-one in debug message
@ 2017-11-18 20:53 ` Ahmad Fatoum
0 siblings, 0 replies; 4+ messages in thread
From: Ahmad Fatoum @ 2017-11-18 20:53 UTC (permalink / raw)
To: intel-wired-lan
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
drivers/net/ethernet/intel/e1000/e1000_hw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c
index 8172cf08cc33..ba04a65d8500 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_hw.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c
@@ -4307,8 +4307,8 @@ static void e1000_init_rx_addrs(struct e1000_hw *hw)
rar_num = E1000_RAR_ENTRIES;
- /* Zero out the other 15 receive addresses. */
- e_dbg("Clearing RAR[1-15]\n");
+ /* Zero out the following 14 receive addresses. RAR[15] is for manageability */
+ e_dbg("Clearing RAR[1-14]\n");
for (i = 1; i < rar_num; i++) {
E1000_WRITE_REG_ARRAY(hw, RA, (i << 1), 0);
E1000_WRITE_FLUSH();
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] e1000: Fix off-by-one in debug message
2017-11-18 20:53 ` [Intel-wired-lan] " Ahmad Fatoum
@ 2017-11-28 1:28 ` Brown, Aaron F
-1 siblings, 0 replies; 4+ messages in thread
From: Brown, Aaron F @ 2017-11-28 1:28 UTC (permalink / raw)
To: Ahmad Fatoum, Kirsher, Jeffrey T; +Cc: intel-wired-lan, netdev
> From: netdev-owner@vger.kernel.org [mailto:netdev-
> owner@vger.kernel.org] On Behalf Of Ahmad Fatoum
> Sent: Saturday, November 18, 2017 12:54 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org; netdev@vger.kernel.org; Ahmad
> Fatoum <ahmad@a3f.at>
> Subject: [PATCH] e1000: Fix off-by-one in debug message
>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> drivers/net/ethernet/intel/e1000/e1000_hw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] e1000: Fix off-by-one in debug message
@ 2017-11-28 1:28 ` Brown, Aaron F
0 siblings, 0 replies; 4+ messages in thread
From: Brown, Aaron F @ 2017-11-28 1:28 UTC (permalink / raw)
To: intel-wired-lan
> From: netdev-owner at vger.kernel.org [mailto:netdev-
> owner at vger.kernel.org] On Behalf Of Ahmad Fatoum
> Sent: Saturday, November 18, 2017 12:54 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
> Cc: intel-wired-lan at lists.osuosl.org; netdev at vger.kernel.org; Ahmad
> Fatoum <ahmad@a3f.at>
> Subject: [PATCH] e1000: Fix off-by-one in debug message
>
> Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
> ---
> drivers/net/ethernet/intel/e1000/e1000_hw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-28 1:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-18 20:53 [PATCH] e1000: Fix off-by-one in debug message Ahmad Fatoum
2017-11-18 20:53 ` [Intel-wired-lan] " Ahmad Fatoum
2017-11-28 1:28 ` Brown, Aaron F
2017-11-28 1:28 ` [Intel-wired-lan] " Brown, Aaron F
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.