From: Lukasz Majewski <lukma@denx.de> To: Alexander Sverdlin <alexander.sverdlin@gmail.com> Cc: Hartley Sweeten <hsweeten@visionengravers.com>, Arnd Bergmann <arnd@arndb.de>, arndbergmann@gmail.com, Russell King <linux@armlinux.org.uk>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Olof Johansson <olof@lixom.net>, Linus Walleij <linus.walleij@linaro.org> Subject: Re: [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board Date: Mon, 20 Nov 2017 00:23:07 +0100 [thread overview] Message-ID: <20171120002307.0694ed35@jawa> (raw) In-Reply-To: <0041277a-f580-1c35-7a6b-5154e676e82f@gmail.com> [-- Attachment #1: Type: text/plain, Size: 1714 bytes --] Hi Alexander, > Hello Lukasz! > > On 17/11/17 00:22, Lukasz Majewski wrote: > > This patch series adds support for Liebherr's BK3 board, being > > a derivative of TS72XX design. > > > > This patchset consists of following patches: > > > > - ts72xx.[c|h] cosmetic cleanup/improvement > > - Move the common code for ts72xx and BK3 to ts72xx-common.c - this > > code can be reused by other designs build around ts72xx > > - The Liebherr's BK3 board has been added with re-using code of > > ts72xx.c > > > > Lukasz Majewski (4): > > ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable > > The patch 3/4 deletes everything added by patch 1/4, so I don't > really see the point of it. I wanted to first clean up things. > > > ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file > > ARM: ep93xx: ts72xx: Exclude reusable part of the ts72xx board > > ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx > > derivative > > I tend to agree with Hartley, if you'd just add all BK3-related > extras to ts72xx.c it would be less than 60 LoCs, you probably even > do not need new Kconfig options. Some Kconfig option would be welcome (MACH_BK3 ?) if it turns out that I do need to adjust some things later (like change HAMMING NAND ECC to BCH for plat_nand driver). The separate bk3.c file is more appealing (for me) in terms of extending the code latter. > > Alex. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: lukma@denx.de (Lukasz Majewski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board Date: Mon, 20 Nov 2017 00:23:07 +0100 [thread overview] Message-ID: <20171120002307.0694ed35@jawa> (raw) In-Reply-To: <0041277a-f580-1c35-7a6b-5154e676e82f@gmail.com> Hi Alexander, > Hello Lukasz! > > On 17/11/17 00:22, Lukasz Majewski wrote: > > This patch series adds support for Liebherr's BK3 board, being > > a derivative of TS72XX design. > > > > This patchset consists of following patches: > > > > - ts72xx.[c|h] cosmetic cleanup/improvement > > - Move the common code for ts72xx and BK3 to ts72xx-common.c - this > > code can be reused by other designs build around ts72xx > > - The Liebherr's BK3 board has been added with re-using code of > > ts72xx.c > > > > Lukasz Majewski (4): > > ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable > > The patch 3/4 deletes everything added by patch 1/4, so I don't > really see the point of it. I wanted to first clean up things. > > > ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file > > ARM: ep93xx: ts72xx: Exclude reusable part of the ts72xx board > > ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx > > derivative > > I tend to agree with Hartley, if you'd just add all BK3-related > extras to ts72xx.c it would be less than 60 LoCs, you probably even > do not need new Kconfig options. Some Kconfig option would be welcome (MACH_BK3 ?) if it turns out that I do need to adjust some things later (like change HAMMING NAND ECC to BCH for plat_nand driver). The separate bk3.c file is more appealing (for me) in terms of extending the code latter. > > Alex. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20171120/d0ce35fc/attachment.sig>
next prev parent reply other threads:[~2017-11-19 23:23 UTC|newest] Thread overview: 159+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-16 23:22 [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board Lukasz Majewski 2017-11-16 23:22 ` Lukasz Majewski 2017-11-16 23:22 ` [PATCH 1/4] ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable Lukasz Majewski 2017-11-16 23:22 ` Lukasz Majewski 2017-11-16 23:22 ` [PATCH 2/4] ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file Lukasz Majewski 2017-11-16 23:22 ` Lukasz Majewski 2017-11-16 23:22 ` [PATCH 3/4] ARM: ep93xx: ts72xx: Exclude reusable part of the ts72xx board Lukasz Majewski 2017-11-16 23:22 ` Lukasz Majewski 2017-11-16 23:22 ` [PATCH 4/4] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Lukasz Majewski 2017-11-16 23:22 ` Lukasz Majewski 2017-11-19 21:28 ` [PATCH 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board Alexander Sverdlin 2017-11-19 21:28 ` Alexander Sverdlin 2017-11-19 23:23 ` Lukasz Majewski [this message] 2017-11-19 23:23 ` Lukasz Majewski 2017-11-20 13:23 ` Arnd Bergmann 2017-11-20 13:23 ` Arnd Bergmann 2017-11-20 14:44 ` Lukasz Majewski 2017-11-20 14:44 ` Lukasz Majewski 2017-11-21 14:31 ` [PATCH v2 0/6] " Lukasz Majewski 2017-11-21 14:31 ` Lukasz Majewski 2017-11-21 14:31 ` [PATCH v2 1/6] ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable Lukasz Majewski 2017-11-21 14:31 ` Lukasz Majewski 2017-11-29 20:33 ` Alexander Sverdlin 2017-11-29 20:33 ` Alexander Sverdlin 2017-11-21 14:32 ` [PATCH v2 2/6] ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file Lukasz Majewski 2017-11-21 14:32 ` Lukasz Majewski 2017-11-29 20:34 ` Alexander Sverdlin 2017-11-29 20:34 ` Alexander Sverdlin 2017-11-21 14:32 ` [PATCH v2 3/6] ARM: ep93xx: ts72xx: Rewrite ts72xx_register_flash() to accept parameters Lukasz Majewski 2017-11-21 14:32 ` Lukasz Majewski 2017-11-29 20:54 ` Alexander Sverdlin 2017-11-29 20:54 ` Alexander Sverdlin 2017-11-21 14:32 ` [PATCH v2 4/6] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable Lukasz Majewski 2017-11-21 14:32 ` Lukasz Majewski 2017-11-29 20:36 ` Alexander Sverdlin 2017-11-29 20:36 ` Alexander Sverdlin 2017-11-21 14:32 ` [PATCH v2 5/6] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code Lukasz Majewski 2017-11-21 14:32 ` Lukasz Majewski 2017-11-21 14:32 ` [PATCH v2 6/6] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Lukasz Majewski 2017-11-21 14:32 ` Lukasz Majewski 2017-11-29 20:48 ` Alexander Sverdlin 2017-11-29 20:48 ` Alexander Sverdlin 2017-11-29 22:07 ` Lukasz Majewski 2017-11-29 22:07 ` Lukasz Majewski 2017-11-30 0:26 ` Lukasz Majewski 2017-11-30 0:26 ` Lukasz Majewski 2017-11-30 7:07 ` Alexander Sverdlin 2017-11-30 7:07 ` Alexander Sverdlin 2017-11-29 9:45 ` [PATCH v2 0/6] ARM: ep93xx: ts72xx: Add support for BK3 board Lukasz Majewski 2017-11-29 9:45 ` Lukasz Majewski 2017-11-29 12:48 ` Arnd Bergmann 2017-11-29 12:48 ` Arnd Bergmann 2017-11-30 0:45 ` [PATCH v3 " Lukasz Majewski 2017-11-30 0:45 ` Lukasz Majewski 2017-11-30 0:45 ` [PATCH v3 1/6] ARM: ep93xx: ts72xx: Use DEFINE_RES_MEM macros where applicable Lukasz Majewski 2017-11-30 0:45 ` Lukasz Majewski 2017-11-30 16:59 ` Hartley Sweeten 2017-11-30 16:59 ` Hartley Sweeten 2017-11-30 0:45 ` [PATCH v3 2/6] ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file Lukasz Majewski 2017-11-30 0:45 ` Lukasz Majewski 2017-11-30 0:45 ` [PATCH v3 3/6] ARM: ep93xx: ts72xx: Rewrite ts72xx_register_flash() to accept parameters Lukasz Majewski 2017-11-30 0:45 ` Lukasz Majewski 2017-11-30 17:07 ` Hartley Sweeten 2017-11-30 17:07 ` Hartley Sweeten 2017-11-30 0:45 ` [PATCH v3 4/6] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable Lukasz Majewski 2017-11-30 0:45 ` Lukasz Majewski 2017-11-30 17:11 ` Hartley Sweeten 2017-11-30 17:11 ` Hartley Sweeten 2017-11-30 0:45 ` [PATCH v3 5/6] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code Lukasz Majewski 2017-11-30 0:45 ` Lukasz Majewski 2017-11-30 17:23 ` Hartley Sweeten 2017-11-30 17:23 ` Hartley Sweeten 2017-11-30 20:01 ` Alexander Sverdlin 2017-11-30 20:01 ` Alexander Sverdlin 2017-11-30 0:45 ` [PATCH v3 6/6] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Lukasz Majewski 2017-11-30 0:45 ` Lukasz Majewski 2017-11-30 9:02 ` [PATCH v3 0/6] ARM: ep93xx: ts72xx: Add support for BK3 board Arnd Bergmann 2017-11-30 9:02 ` Arnd Bergmann 2017-11-30 9:57 ` Alexander Sverdlin 2017-11-30 10:44 ` Arnd Bergmann 2017-11-30 10:44 ` Arnd Bergmann 2017-11-30 23:51 ` [PATCH v4 0/5] " Lukasz Majewski 2017-11-30 23:51 ` Lukasz Majewski 2017-11-30 23:51 ` [PATCH v4 1/5] ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file Lukasz Majewski 2017-11-30 23:51 ` Lukasz Majewski 2017-11-30 23:51 ` [PATCH v4 2/5] ARM: ep93xx: ts72xx: Rewrite ts72xx_register_flash() to accept parameters Lukasz Majewski 2017-11-30 23:51 ` Lukasz Majewski 2017-11-30 23:51 ` [PATCH v4 3/5] ARM: ep93xx: ts72xx: Rewrite map IO code to be reusable Lukasz Majewski 2017-11-30 23:51 ` Lukasz Majewski 2017-11-30 23:51 ` [PATCH v4 4/5] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code Lukasz Majewski 2017-11-30 23:51 ` Lukasz Majewski 2017-11-30 23:51 ` [PATCH v4 5/5] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Lukasz Majewski 2017-11-30 23:51 ` Lukasz Majewski 2017-12-11 17:17 ` Hartley Sweeten 2017-12-11 17:17 ` Hartley Sweeten 2017-12-11 21:39 ` Lukasz Majewski 2017-12-11 21:39 ` Lukasz Majewski 2017-12-11 22:28 ` Hartley Sweeten 2017-12-11 22:28 ` Hartley Sweeten 2017-12-11 22:46 ` Lukasz Majewski 2017-12-11 22:46 ` Lukasz Majewski 2017-12-05 18:14 ` [PATCH v4 0/5] ARM: ep93xx: ts72xx: Add support for BK3 board Hartley Sweeten 2017-12-05 18:14 ` Hartley Sweeten 2017-12-06 17:46 ` Alexander Sverdlin 2017-12-06 17:46 ` Alexander Sverdlin 2017-12-11 23:36 ` [PATCH v5 0/4] " Lukasz Majewski 2017-12-11 23:36 ` Lukasz Majewski 2017-12-11 23:36 ` [PATCH v5 1/4] ARM: ep93xx: ts72xx: Provide include guards for ts72xx.h file Lukasz Majewski 2017-12-11 23:36 ` Lukasz Majewski 2017-12-11 23:36 ` [PATCH v5 2/4] ARM: ep93xx: ts72xx: Rewrite ts72xx_register_flash() to accept parameters Lukasz Majewski 2017-12-11 23:36 ` Lukasz Majewski 2017-12-11 23:36 ` [PATCH v5 3/4] ARM: ep93xx: ts72xx: cosmetic: Add some description to ts72xx code Lukasz Majewski 2017-12-11 23:36 ` Lukasz Majewski 2017-12-11 23:36 ` [PATCH v5 4/4] ARM: ep93xx: ts72xx: Add support for BK3 board - ts72xx derivative Lukasz Majewski 2017-12-11 23:36 ` Lukasz Majewski 2017-12-11 23:43 ` [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board Hartley Sweeten 2017-12-11 23:43 ` Hartley Sweeten 2017-12-13 7:34 ` Linus Walleij 2017-12-13 7:34 ` Linus Walleij 2017-12-13 8:26 ` Alexander Sverdlin 2017-12-13 8:26 ` Alexander Sverdlin 2017-12-13 8:52 ` Lukasz Majewski 2017-12-13 8:52 ` Lukasz Majewski 2017-12-20 12:33 ` Linus Walleij 2017-12-20 12:33 ` Linus Walleij 2017-12-20 12:50 ` Arnd Bergmann 2017-12-20 12:50 ` Arnd Bergmann 2017-12-20 13:00 ` Alexander Sverdlin 2017-12-20 13:00 ` Alexander Sverdlin 2017-12-20 13:14 ` Arnd Bergmann 2017-12-20 13:14 ` Arnd Bergmann 2017-12-20 13:39 ` Alexander Sverdlin 2017-12-20 13:39 ` Alexander Sverdlin 2017-12-20 13:14 ` Lukasz Majewski 2017-12-20 13:14 ` Lukasz Majewski 2017-12-20 13:18 ` Lukasz Majewski 2017-12-20 13:18 ` Lukasz Majewski 2017-12-13 10:11 ` Arnd Bergmann 2017-12-13 10:11 ` Arnd Bergmann 2017-12-17 19:41 ` Lukasz Majewski 2017-12-17 19:41 ` Lukasz Majewski 2017-12-17 20:07 ` Arnd Bergmann 2017-12-17 20:07 ` Arnd Bergmann 2017-12-17 21:28 ` Lukasz Majewski 2017-12-17 21:28 ` Lukasz Majewski 2017-12-18 11:55 ` Arnd Bergmann 2017-12-18 11:55 ` Arnd Bergmann 2017-12-18 12:03 ` Alexander Sverdlin 2017-12-18 12:03 ` Alexander Sverdlin 2017-12-19 21:36 ` Lukasz Majewski 2017-12-19 21:36 ` Lukasz Majewski 2017-12-20 8:11 ` Arnd Bergmann 2017-12-20 8:11 ` Arnd Bergmann 2017-12-20 8:53 ` Lukasz Majewski 2017-12-20 8:53 ` Lukasz Majewski 2017-12-20 12:48 ` Linus Walleij 2017-12-20 12:48 ` Linus Walleij 2017-12-20 12:59 ` Arnd Bergmann 2017-12-20 12:59 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171120002307.0694ed35@jawa \ --to=lukma@denx.de \ --cc=alexander.sverdlin@gmail.com \ --cc=arnd@arndb.de \ --cc=arndbergmann@gmail.com \ --cc=hsweeten@visionengravers.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=olof@lixom.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.