All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Mel Gorman <mgorman@techsingularity.net>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/cma: fix alloc_contig_range ret code/potential leak
Date: Tue, 21 Nov 2017 14:06:52 +0100	[thread overview]
Message-ID: <20171121130652.pdgsswo63o4tfcee@dhcp22.suse.cz> (raw)
In-Reply-To: <b63d2f48-ee19-20ca-e870-76fb4cd9e09f@suse.cz>

On Tue 21-11-17 08:53:11, Vlastimil Babka wrote:
> On 11/20/2017 08:39 PM, Mike Kravetz wrote:
> > If the call __alloc_contig_migrate_range() in alloc_contig_range
> > returns -EBUSY, processing continues so that test_pages_isolated()
> > is called where there is a tracepoint to identify the busy pages.
> > However, it is possible for busy pages to become available between
> > the calls to these two routines.  In this case, the range of pages
> > may be allocated.   Unfortunately, the original return code (ret
> > == -EBUSY) is still set and returned to the caller.  Therefore,
> > the caller believes the pages were not allocated and they are leaked.
> > 
> > Update the return code with the value from test_pages_isolated().
> 
> Good catch and seems ok for a stable fix. But it's another indication
> that this area needs some larger rewrite.

Absolutely. The whole thing is subtle as hell. And shaping the code just
around the tracepoint here smells like the whole design could be thought
through much more.
-- 
Michal Hocko
SUSE Labs

WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Michal Nazarewicz <mina86@mina86.com>,
	Mel Gorman <mgorman@techsingularity.net>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/1] mm/cma: fix alloc_contig_range ret code/potential leak
Date: Tue, 21 Nov 2017 14:06:52 +0100	[thread overview]
Message-ID: <20171121130652.pdgsswo63o4tfcee@dhcp22.suse.cz> (raw)
In-Reply-To: <b63d2f48-ee19-20ca-e870-76fb4cd9e09f@suse.cz>

On Tue 21-11-17 08:53:11, Vlastimil Babka wrote:
> On 11/20/2017 08:39 PM, Mike Kravetz wrote:
> > If the call __alloc_contig_migrate_range() in alloc_contig_range
> > returns -EBUSY, processing continues so that test_pages_isolated()
> > is called where there is a tracepoint to identify the busy pages.
> > However, it is possible for busy pages to become available between
> > the calls to these two routines.  In this case, the range of pages
> > may be allocated.   Unfortunately, the original return code (ret
> > == -EBUSY) is still set and returned to the caller.  Therefore,
> > the caller believes the pages were not allocated and they are leaked.
> > 
> > Update the return code with the value from test_pages_isolated().
> 
> Good catch and seems ok for a stable fix. But it's another indication
> that this area needs some larger rewrite.

Absolutely. The whole thing is subtle as hell. And shaping the code just
around the tracepoint here smells like the whole design could be thought
through much more.
-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-11-21 13:06 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-20 19:39 [PATCH 0/1] mm/cma: fix alloc_contig_range ret code/potential leak Mike Kravetz
2017-11-20 19:39 ` Mike Kravetz
2017-11-20 19:39 ` [PATCH 1/1] " Mike Kravetz
2017-11-20 19:39   ` Mike Kravetz
2017-11-21  7:53   ` Vlastimil Babka
2017-11-21  7:53     ` Vlastimil Babka
2017-11-21 13:06     ` Michal Hocko [this message]
2017-11-21 13:06       ` Michal Hocko
2017-11-21 13:04   ` Michal Hocko
2017-11-21 13:04     ` Michal Hocko
2017-11-21 14:20   ` Michal Nazarewicz
2017-11-21 14:20     ` Michal Nazarewicz
2017-11-21 14:20     ` Michal Nazarewicz
2017-11-22 12:00   ` Johannes Weiner
2017-11-22 12:00     ` Johannes Weiner
2017-11-22 17:46     ` Mike Kravetz
2017-11-22 17:46       ` Mike Kravetz
2017-11-22 18:52       ` [PATCH v2] " Mike Kravetz
2017-11-22 18:52         ` Mike Kravetz
2017-11-23  8:05         ` Vlastimil Babka
2017-11-23  8:05           ` Vlastimil Babka
2017-11-23  9:19         ` Michal Hocko
2017-11-23  9:19           ` Michal Hocko
2017-11-27 16:59         ` Johannes Weiner
2017-11-27 16:59           ` Johannes Weiner
2017-11-29  5:38         ` Joonsoo Kim
2017-11-29  5:38           ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171121130652.pdgsswo63o4tfcee@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mike.kravetz@oracle.com \
    --cc=mina86@mina86.com \
    --cc=stable@vger.kernel.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.