* [PATCH] mm: Use vma_pages helper
@ 2017-11-22 15:26 ` Vasyl Gomonovych
0 siblings, 0 replies; 6+ messages in thread
From: Vasyl Gomonovych @ 2017-11-22 15:26 UTC (permalink / raw)
To: dledford, dave, mst, jglisse, peterz, linux-mm; +Cc: linux-kernel, gomonovych
Use vma_pages function on vma object instead of explicit computation.
mm/interval_tree.c:21:27-33: WARNING: Consider using vma_pages helper
Generated by: scripts/coccinelle/api/vma_pages.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
mm/interval_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/interval_tree.c b/mm/interval_tree.c
index b47664358796..27ddfd29112a 100644
--- a/mm/interval_tree.c
+++ b/mm/interval_tree.c
@@ -18,7 +18,7 @@ static inline unsigned long vma_start_pgoff(struct vm_area_struct *v)
static inline unsigned long vma_last_pgoff(struct vm_area_struct *v)
{
- return v->vm_pgoff + ((v->vm_end - v->vm_start) >> PAGE_SHIFT) - 1;
+ return v->vm_pgoff + vma_pages(v) - 1;
}
INTERVAL_TREE_DEFINE(struct vm_area_struct, shared.rb,
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mm: Use vma_pages helper
@ 2017-11-22 15:26 ` Vasyl Gomonovych
0 siblings, 0 replies; 6+ messages in thread
From: Vasyl Gomonovych @ 2017-11-22 15:26 UTC (permalink / raw)
To: dledford, dave, mst, jglisse, peterz, linux-mm; +Cc: linux-kernel, gomonovych
Use vma_pages function on vma object instead of explicit computation.
mm/interval_tree.c:21:27-33: WARNING: Consider using vma_pages helper
Generated by: scripts/coccinelle/api/vma_pages.cocci
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
mm/interval_tree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/interval_tree.c b/mm/interval_tree.c
index b47664358796..27ddfd29112a 100644
--- a/mm/interval_tree.c
+++ b/mm/interval_tree.c
@@ -18,7 +18,7 @@ static inline unsigned long vma_start_pgoff(struct vm_area_struct *v)
static inline unsigned long vma_last_pgoff(struct vm_area_struct *v)
{
- return v->vm_pgoff + ((v->vm_end - v->vm_start) >> PAGE_SHIFT) - 1;
+ return v->vm_pgoff + vma_pages(v) - 1;
}
INTERVAL_TREE_DEFINE(struct vm_area_struct, shared.rb,
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: Use vma_pages helper
2017-11-22 15:26 ` Vasyl Gomonovych
@ 2017-11-22 15:32 ` Michael S. Tsirkin
-1 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2017-11-22 15:32 UTC (permalink / raw)
To: Vasyl Gomonovych; +Cc: dledford, dave, jglisse, peterz, linux-mm, linux-kernel
On Wed, Nov 22, 2017 at 04:26:50PM +0100, Vasyl Gomonovych wrote:
> Use vma_pages function on vma object instead of explicit computation.
> mm/interval_tree.c:21:27-33: WARNING: Consider using vma_pages helper
> Generated by: scripts/coccinelle/api/vma_pages.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> mm/interval_tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/interval_tree.c b/mm/interval_tree.c
> index b47664358796..27ddfd29112a 100644
> --- a/mm/interval_tree.c
> +++ b/mm/interval_tree.c
> @@ -18,7 +18,7 @@ static inline unsigned long vma_start_pgoff(struct vm_area_struct *v)
>
> static inline unsigned long vma_last_pgoff(struct vm_area_struct *v)
> {
> - return v->vm_pgoff + ((v->vm_end - v->vm_start) >> PAGE_SHIFT) - 1;
> + return v->vm_pgoff + vma_pages(v) - 1;
> }
>
> INTERVAL_TREE_DEFINE(struct vm_area_struct, shared.rb,
> --
> 1.9.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: Use vma_pages helper
@ 2017-11-22 15:32 ` Michael S. Tsirkin
0 siblings, 0 replies; 6+ messages in thread
From: Michael S. Tsirkin @ 2017-11-22 15:32 UTC (permalink / raw)
To: Vasyl Gomonovych; +Cc: dledford, dave, jglisse, peterz, linux-mm, linux-kernel
On Wed, Nov 22, 2017 at 04:26:50PM +0100, Vasyl Gomonovych wrote:
> Use vma_pages function on vma object instead of explicit computation.
> mm/interval_tree.c:21:27-33: WARNING: Consider using vma_pages helper
> Generated by: scripts/coccinelle/api/vma_pages.cocci
>
> Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> mm/interval_tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/interval_tree.c b/mm/interval_tree.c
> index b47664358796..27ddfd29112a 100644
> --- a/mm/interval_tree.c
> +++ b/mm/interval_tree.c
> @@ -18,7 +18,7 @@ static inline unsigned long vma_start_pgoff(struct vm_area_struct *v)
>
> static inline unsigned long vma_last_pgoff(struct vm_area_struct *v)
> {
> - return v->vm_pgoff + ((v->vm_end - v->vm_start) >> PAGE_SHIFT) - 1;
> + return v->vm_pgoff + vma_pages(v) - 1;
> }
>
> INTERVAL_TREE_DEFINE(struct vm_area_struct, shared.rb,
> --
> 1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: Use vma_pages helper
2017-11-22 15:26 ` Vasyl Gomonovych
@ 2017-11-22 16:43 ` Davidlohr Bueso
-1 siblings, 0 replies; 6+ messages in thread
From: Davidlohr Bueso @ 2017-11-22 16:43 UTC (permalink / raw)
To: Vasyl Gomonovych, akpm
Cc: dledford, mst, jglisse, peterz, linux-mm, linux-kernel
On Wed, 22 Nov 2017, Vasyl Gomonovych wrote:
>Use vma_pages function on vma object instead of explicit computation.
>mm/interval_tree.c:21:27-33: WARNING: Consider using vma_pages helper
>Generated by: scripts/coccinelle/api/vma_pages.cocci
>
>Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Acked-by: Davidlohr Bueso <dbueso@suse.de>
... but you missed akpm.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: Use vma_pages helper
@ 2017-11-22 16:43 ` Davidlohr Bueso
0 siblings, 0 replies; 6+ messages in thread
From: Davidlohr Bueso @ 2017-11-22 16:43 UTC (permalink / raw)
To: Vasyl Gomonovych, akpm
Cc: dledford, mst, jglisse, peterz, linux-mm, linux-kernel
On Wed, 22 Nov 2017, Vasyl Gomonovych wrote:
>Use vma_pages function on vma object instead of explicit computation.
>mm/interval_tree.c:21:27-33: WARNING: Consider using vma_pages helper
>Generated by: scripts/coccinelle/api/vma_pages.cocci
>
>Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Acked-by: Davidlohr Bueso <dbueso@suse.de>
... but you missed akpm.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-22 16:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-22 15:26 [PATCH] mm: Use vma_pages helper Vasyl Gomonovych
2017-11-22 15:26 ` Vasyl Gomonovych
2017-11-22 15:32 ` Michael S. Tsirkin
2017-11-22 15:32 ` Michael S. Tsirkin
2017-11-22 16:43 ` Davidlohr Bueso
2017-11-22 16:43 ` Davidlohr Bueso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.