[Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

Hello,

i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
2.9.1.

If i migrate a VM from a host running kernel 4.4 to a host running 4.12
i get:

kvm: virtio-net: saved image requires TUN_F_UFO support
kvm: Failed to load virtio-net-device:tmp
kvm: Failed to load virtio-net:virtio
kvm: error while loading state for instance 0x0 of device
'0000:00:12.0/virtio-net'
kvm: load of migration failed: Invalid argument


while migrating from 4.12 to 4.4 works fine.

Can anybody help? Is this expected?

Greets,
Stefan

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Paolo Bonzini]

On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
> Hello,
> 
> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
> 2.9.1.
> 
> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
> i get:
> 
> kvm: virtio-net: saved image requires TUN_F_UFO support
> kvm: Failed to load virtio-net-device:tmp
> kvm: Failed to load virtio-net:virtio
> kvm: error while loading state for instance 0x0 of device
> '0000:00:12.0/virtio-net'
> kvm: load of migration failed: Invalid argument
> 
> 
> while migrating from 4.12 to 4.4 works fine.
> 
> Can anybody help? Is this expected?

Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?  Also,
did this ioctl fail when the tap device was set up on the 4.12 destination?

int tap_probe_has_ufo(int fd)
{
    unsigned offload;

    offload = TUN_F_CSUM | TUN_F_UFO;

    if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
        return 0;

    return 1;
}

Thanks,

Paolo

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

Hi Paolo,

Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
>> Hello,
>>
>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
>> 2.9.1.
>>
>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
>> i get:
>>
>> kvm: virtio-net: saved image requires TUN_F_UFO support
>> kvm: Failed to load virtio-net-device:tmp
>> kvm: Failed to load virtio-net:virtio
>> kvm: error while loading state for instance 0x0 of device
>> '0000:00:12.0/virtio-net'
>> kvm: load of migration failed: Invalid argument
>>
>>
>> while migrating from 4.12 to 4.4 works fine.
>>
>> Can anybody help? Is this expected?
> 
> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?

May be - how can i archieve this? Patching the code is not a problem if
you can give me a hint.

> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
> int tap_probe_has_ufo(int fd)
> {
>     unsigned offload;
> 
>     offload = TUN_F_CSUM | TUN_F_UFO;
> 
>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
>         return 0;
> 
>     return 1;
> }

Should there be any kernel output or how can i detect / check it?

Greets,
Stefan

> Thanks,
> 
> Paolo
> 

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Paolo Bonzini]

On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
> Hi Paolo,
> 
> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
>>> Hello,
>>>
>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
>>> 2.9.1.
>>>
>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
>>> i get:
>>>
>>> kvm: virtio-net: saved image requires TUN_F_UFO support
>>> kvm: Failed to load virtio-net-device:tmp
>>> kvm: Failed to load virtio-net:virtio
>>> kvm: error while loading state for instance 0x0 of device
>>> '0000:00:12.0/virtio-net'
>>> kvm: load of migration failed: Invalid argument
>>>
>>>
>>> while migrating from 4.12 to 4.4 works fine.
>>>
>>> Can anybody help? Is this expected?
>>
>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
> 
> May be - how can i archieve this? Patching the code is not a problem if
> you can give me a hint.
> 
>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
>> int tap_probe_has_ufo(int fd)
>> {
>>     unsigned offload;
>>
>>     offload = TUN_F_CSUM | TUN_F_UFO;
>>
>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
>>         return 0;
>>
>>     return 1;
>> }
> 
> Should there be any kernel output or how can i detect / check it?

For both, the simplest answer is probably just using printf.

Paolo

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

Hi Paolo,

Am 06.11.2017 um 10:49 schrieb Paolo Bonzini:
> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
>> Hi Paolo,
>>
>> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
>>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
>>>> Hello,
>>>>
>>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
>>>> 2.9.1.
>>>>
>>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
>>>> i get:
>>>>
>>>> kvm: virtio-net: saved image requires TUN_F_UFO support
>>>> kvm: Failed to load virtio-net-device:tmp
>>>> kvm: Failed to load virtio-net:virtio
>>>> kvm: error while loading state for instance 0x0 of device
>>>> '0000:00:12.0/virtio-net'
>>>> kvm: load of migration failed: Invalid argument
>>>>
>>>>
>>>> while migrating from 4.12 to 4.4 works fine.
>>>>
>>>> Can anybody help? Is this expected?
>>>
>>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
>>
>> May be - how can i archieve this? Patching the code is not a problem if
>> you can give me a hint.
>>
>>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
>>> int tap_probe_has_ufo(int fd)
>>> {
>>>     unsigned offload;
>>>
>>>     offload = TUN_F_CSUM | TUN_F_UFO;
>>>
>>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
>>>         return 0;
>>>
>>>     return 1;
>>> }
>>
>> Should there be any kernel output or how can i detect / check it?
> 
> For both, the simplest answer is probably just using printf.

arg i missed an important part. The kernel is an opensuse SLE15 one.

I've seen it contains the following patchset:
https://www.spinics.net/lists/netdev/msg443821.html

Greets,
Stefan

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

HI Paolo,

could this patchset be related?

Greets,
Stefan

Am 06.11.2017 um 10:52 schrieb Stefan Priebe - Profihost AG:
> Hi Paolo,
> 
> Am 06.11.2017 um 10:49 schrieb Paolo Bonzini:
>> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
>>> Hi Paolo,
>>>
>>> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
>>>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
>>>>> Hello,
>>>>>
>>>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
>>>>> 2.9.1.
>>>>>
>>>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
>>>>> i get:
>>>>>
>>>>> kvm: virtio-net: saved image requires TUN_F_UFO support
>>>>> kvm: Failed to load virtio-net-device:tmp
>>>>> kvm: Failed to load virtio-net:virtio
>>>>> kvm: error while loading state for instance 0x0 of device
>>>>> '0000:00:12.0/virtio-net'
>>>>> kvm: load of migration failed: Invalid argument
>>>>>
>>>>>
>>>>> while migrating from 4.12 to 4.4 works fine.
>>>>>
>>>>> Can anybody help? Is this expected?
>>>>
>>>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
>>>
>>> May be - how can i archieve this? Patching the code is not a problem if
>>> you can give me a hint.
>>>
>>>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
>>>> int tap_probe_has_ufo(int fd)
>>>> {
>>>>     unsigned offload;
>>>>
>>>>     offload = TUN_F_CSUM | TUN_F_UFO;
>>>>
>>>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
>>>>         return 0;
>>>>
>>>>     return 1;
>>>> }
>>>
>>> Should there be any kernel output or how can i detect / check it?
>>
>> For both, the simplest answer is probably just using printf.
> 
> arg i missed an important part. The kernel is an opensuse SLE15 one.
> 
> I've seen it contains the following patchset:
> https://www.spinics.net/lists/netdev/msg443821.html
> 
> Greets,
> Stefan
> 

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Paolo Bonzini]

On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
> HI Paolo,
> 
> could this patchset be related?

Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
disable UFO in the newest machine types, but do we also have to do
(software) UFO in vhost-net and QEMU for migration compatibility?

Thanks,

Paolo

> Greets,
> Stefan
> 
> Am 06.11.2017 um 10:52 schrieb Stefan Priebe - Profihost AG:
>> Hi Paolo,
>>
>> Am 06.11.2017 um 10:49 schrieb Paolo Bonzini:
>>> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
>>>> Hi Paolo,
>>>>
>>>> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
>>>>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
>>>>>> Hello,
>>>>>>
>>>>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
>>>>>> 2.9.1.
>>>>>>
>>>>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
>>>>>> i get:
>>>>>>
>>>>>> kvm: virtio-net: saved image requires TUN_F_UFO support
>>>>>> kvm: Failed to load virtio-net-device:tmp
>>>>>> kvm: Failed to load virtio-net:virtio
>>>>>> kvm: error while loading state for instance 0x0 of device
>>>>>> '0000:00:12.0/virtio-net'
>>>>>> kvm: load of migration failed: Invalid argument
>>>>>>
>>>>>>
>>>>>> while migrating from 4.12 to 4.4 works fine.
>>>>>>
>>>>>> Can anybody help? Is this expected?
>>>>>
>>>>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
>>>>
>>>> May be - how can i archieve this? Patching the code is not a problem if
>>>> you can give me a hint.
>>>>
>>>>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
>>>>> int tap_probe_has_ufo(int fd)
>>>>> {
>>>>>     unsigned offload;
>>>>>
>>>>>     offload = TUN_F_CSUM | TUN_F_UFO;
>>>>>
>>>>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
>>>>>         return 0;
>>>>>
>>>>>     return 1;
>>>>> }
>>>>
>>>> Should there be any kernel output or how can i detect / check it?
>>>
>>> For both, the simplest answer is probably just using printf.
>>
>> arg i missed an important part. The kernel is an opensuse SLE15 one.
>>
>> I've seen it contains the following patchset:
>> https://www.spinics.net/lists/netdev/msg443821.html
>>
>> Greets,
>> Stefan
>>

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

Hi Paolo,

Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>> HI Paolo,
>>
>> could this patchset be related?
> 
> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
> disable UFO in the newest machine types, but do we also have to do
> (software) UFO in vhost-net and QEMU for migration compatibility?

Any news on this?

Greets,
Stefan


> Thanks,
> 
> Paolo
> 
>> Greets,
>> Stefan
>>
>> Am 06.11.2017 um 10:52 schrieb Stefan Priebe - Profihost AG:
>>> Hi Paolo,
>>>
>>> Am 06.11.2017 um 10:49 schrieb Paolo Bonzini:
>>>> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
>>>>> Hi Paolo,
>>>>>
>>>>> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
>>>>>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
>>>>>>> 2.9.1.
>>>>>>>
>>>>>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
>>>>>>> i get:
>>>>>>>
>>>>>>> kvm: virtio-net: saved image requires TUN_F_UFO support
>>>>>>> kvm: Failed to load virtio-net-device:tmp
>>>>>>> kvm: Failed to load virtio-net:virtio
>>>>>>> kvm: error while loading state for instance 0x0 of device
>>>>>>> '0000:00:12.0/virtio-net'
>>>>>>> kvm: load of migration failed: Invalid argument
>>>>>>>
>>>>>>>
>>>>>>> while migrating from 4.12 to 4.4 works fine.
>>>>>>>
>>>>>>> Can anybody help? Is this expected?
>>>>>>
>>>>>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
>>>>>
>>>>> May be - how can i archieve this? Patching the code is not a problem if
>>>>> you can give me a hint.
>>>>>
>>>>>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
>>>>>> int tap_probe_has_ufo(int fd)
>>>>>> {
>>>>>>     unsigned offload;
>>>>>>
>>>>>>     offload = TUN_F_CSUM | TUN_F_UFO;
>>>>>>
>>>>>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
>>>>>>         return 0;
>>>>>>
>>>>>>     return 1;
>>>>>> }
>>>>>
>>>>> Should there be any kernel output or how can i detect / check it?
>>>>
>>>> For both, the simplest answer is probably just using printf.
>>>
>>> arg i missed an important part. The kernel is an opensuse SLE15 one.
>>>
>>> I've seen it contains the following patchset:
>>> https://www.spinics.net/lists/netdev/msg443821.html
>>>
>>> Greets,
>>> Stefan
>>>
> 

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Jason Wang]

On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
> Hi Paolo,
>
> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>> HI Paolo,
>>>
>>> could this patchset be related?
>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
>> disable UFO in the newest machine types, but do we also have to do
>> (software) UFO in vhost-net and QEMU for migration compatibility?
> Any news on this?
>
> Greets,

Since we probe UFO support, it will be disabled automatically on device 
startup.

For the issue of migration, I think the only way is trying to fix it in 
kernel.

Thanks

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

Am 08.11.2017 um 08:54 schrieb Jason Wang:
> 
> 
> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
>> Hi Paolo,
>>
>> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>>> HI Paolo,
>>>>
>>>> could this patchset be related?
>>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
>>> disable UFO in the newest machine types, but do we also have to do
>>> (software) UFO in vhost-net and QEMU for migration compatibility?
>> Any news on this?
>>
>> Greets,
> 
> Since we probe UFO support, it will be disabled automatically on device
> startup.
> 
> For the issue of migration, I think the only way is trying to fix it in
> kernel.

But 4.14 is around the corner and the patchset is already included.
Shouldn't this get fixed before 4.14 is released?

Stefan
> 
> Thanks

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Jason Wang]

On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote:
> Am 08.11.2017 um 08:54 schrieb Jason Wang:
>>
>> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
>>> Hi Paolo,
>>>
>>> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>>>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>>>> HI Paolo,
>>>>>
>>>>> could this patchset be related?
>>>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
>>>> disable UFO in the newest machine types, but do we also have to do
>>>> (software) UFO in vhost-net and QEMU for migration compatibility?
>>> Any news on this?
>>>
>>> Greets,
>> Since we probe UFO support, it will be disabled automatically on device
>> startup.
>>
>> For the issue of migration, I think the only way is trying to fix it in
>> kernel.
> But 4.14 is around the corner and the patchset is already included.
> Shouldn't this get fixed before 4.14 is released?

We will try to seek a solution as soon as possible. If we can't catch 
4.14, we will do it for stable for sure.

Thanks

>
> Stefan
>> Thanks

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Paolo Bonzini]

On 08/11/2017 09:21, Jason Wang wrote:
> 
> 
> On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote:
>> Am 08.11.2017 um 08:54 schrieb Jason Wang:
>>>
>>> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
>>>> Hi Paolo,
>>>>
>>>> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>>>>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>>>>> HI Paolo,
>>>>>>
>>>>>> could this patchset be related?
>>>>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we
>>>>> need to
>>>>> disable UFO in the newest machine types, but do we also have to do
>>>>> (software) UFO in vhost-net and QEMU for migration compatibility?
>>>> Any news on this?
>>>>
>>>> Greets,
>>> Since we probe UFO support, it will be disabled automatically on device
>>> startup.
>>>
>>> For the issue of migration, I think the only way is trying to fix it in
>>> kernel.
>> But 4.14 is around the corner and the patchset is already included.
>> Shouldn't this get fixed before 4.14 is released?
> 
> We will try to seek a solution as soon as possible. If we can't catch
> 4.14, we will do it for stable for sure.

Jason, can you write to netdev and Cc Linus and me?

Thanks,

Paolo

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Jason Wang]

On 2017年11月08日 18:46, Paolo Bonzini wrote:
> On 08/11/2017 09:21, Jason Wang wrote:
>>
>> On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote:
>>> Am 08.11.2017 um 08:54 schrieb Jason Wang:
>>>> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
>>>>> Hi Paolo,
>>>>>
>>>>> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>>>>>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>>>>>> HI Paolo,
>>>>>>>
>>>>>>> could this patchset be related?
>>>>>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we
>>>>>> need to
>>>>>> disable UFO in the newest machine types, but do we also have to do
>>>>>> (software) UFO in vhost-net and QEMU for migration compatibility?
>>>>> Any news on this?
>>>>>
>>>>> Greets,
>>>> Since we probe UFO support, it will be disabled automatically on device
>>>> startup.
>>>>
>>>> For the issue of migration, I think the only way is trying to fix it in
>>>> kernel.
>>> But 4.14 is around the corner and the patchset is already included.
>>> Shouldn't this get fixed before 4.14 is released?
>> We will try to seek a solution as soon as possible. If we can't catch
>> 4.14, we will do it for stable for sure.
> Jason, can you write to netdev and Cc Linus and me?
>
> Thanks,
>
> Paolo

Paolo, see this https://www.spinics.net/lists/netdev/msg465454.html

Just notice this today since I'm not on the cc list.

Thanks

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Jason Wang]

On 2017年11月08日 19:22, Jason Wang wrote:
>
>
> On 2017年11月08日 18:46, Paolo Bonzini wrote:
>> On 08/11/2017 09:21, Jason Wang wrote:
>>>
>>> On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote:
>>>> Am 08.11.2017 um 08:54 schrieb Jason Wang:
>>>>> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
>>>>>> Hi Paolo,
>>>>>>
>>>>>> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>>>>>>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>>>>>>> HI Paolo,
>>>>>>>>
>>>>>>>> could this patchset be related?
>>>>>>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we
>>>>>>> need to
>>>>>>> disable UFO in the newest machine types, but do we also have to do
>>>>>>> (software) UFO in vhost-net and QEMU for migration compatibility?
>>>>>> Any news on this?
>>>>>>
>>>>>> Greets,
>>>>> Since we probe UFO support, it will be disabled automatically on 
>>>>> device
>>>>> startup.
>>>>>
>>>>> For the issue of migration, I think the only way is trying to fix 
>>>>> it in
>>>>> kernel.
>>>> But 4.14 is around the corner and the patchset is already included.
>>>> Shouldn't this get fixed before 4.14 is released?
>>> We will try to seek a solution as soon as possible. If we can't catch
>>> 4.14, we will do it for stable for sure.
>> Jason, can you write to netdev and Cc Linus and me?
>>
>> Thanks,
>>
>> Paolo
>
> Paolo, see this https://www.spinics.net/lists/netdev/msg465454.html
>
> Just notice this today since I'm not on the cc list.
>
> Thanks
>
>

An update:

After some discussions on netdev, we will try to bring UFO back 
partially for just TAP. Willem promise to fix this. 4.14 is too late 
consider the fix is not trivial, it will go through stable tree.

Thanks

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

Hello,

Am 10.11.2017 um 05:18 schrieb Jason Wang:
> 
> 
> On 2017年11月08日 19:22, Jason Wang wrote:
>>
>>
>> On 2017年11月08日 18:46, Paolo Bonzini wrote:
>>> On 08/11/2017 09:21, Jason Wang wrote:
>>>>
>>>> On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote:
>>>>> Am 08.11.2017 um 08:54 schrieb Jason Wang:
>>>>>> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
>>>>>>> Hi Paolo,
>>>>>>>
>>>>>>> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>>>>>>>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>>>>>>>> HI Paolo,
>>>>>>>>>
>>>>>>>>> could this patchset be related?
>>>>>>>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we
>>>>>>>> need to
>>>>>>>> disable UFO in the newest machine types, but do we also have to do
>>>>>>>> (software) UFO in vhost-net and QEMU for migration compatibility?
>>>>>>> Any news on this?
>>>>>>>
>>>>>>> Greets,
>>>>>> Since we probe UFO support, it will be disabled automatically on
>>>>>> device
>>>>>> startup.
>>>>>>
>>>>>> For the issue of migration, I think the only way is trying to fix
>>>>>> it in
>>>>>> kernel.
>>>>> But 4.14 is around the corner and the patchset is already included.
>>>>> Shouldn't this get fixed before 4.14 is released?
>>>> We will try to seek a solution as soon as possible. If we can't catch
>>>> 4.14, we will do it for stable for sure.
>>> Jason, can you write to netdev and Cc Linus and me?
>>>
>>> Thanks,
>>>
>>> Paolo
>>
>> Paolo, see this https://www.spinics.net/lists/netdev/msg465454.html
>>
>> Just notice this today since I'm not on the cc list.
>>
>> Thanks
>>
>>
> 
> An update:
> 
> After some discussions on netdev, we will try to bring UFO back
> partially for just TAP. Willem promise to fix this. 4.14 is too late
> consider the fix is not trivial, it will go through stable tree.

OK is it save to just revert the UFO patchset for my local branch?

Greets,
Stefan

> 
> Thanks

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Paolo Bonzini]

On 11/11/2017 19:59, Stefan Priebe - Profihost AG wrote:
> Hello,
> 
> Am 10.11.2017 um 05:18 schrieb Jason Wang:
>>
>>
>> On 2017年11月08日 19:22, Jason Wang wrote:
>>>
>>>
>>> On 2017年11月08日 18:46, Paolo Bonzini wrote:
>>>> On 08/11/2017 09:21, Jason Wang wrote:
>>>>>
>>>>> On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote:
>>>>>> Am 08.11.2017 um 08:54 schrieb Jason Wang:
>>>>>>> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote:
>>>>>>>> Hi Paolo,
>>>>>>>>
>>>>>>>> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini:
>>>>>>>>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>>>>>>>>> HI Paolo,
>>>>>>>>>>
>>>>>>>>>> could this patchset be related?
>>>>>>>>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we
>>>>>>>>> need to
>>>>>>>>> disable UFO in the newest machine types, but do we also have to do
>>>>>>>>> (software) UFO in vhost-net and QEMU for migration compatibility?
>>>>>>>> Any news on this?
>>>>>>>>
>>>>>>>> Greets,
>>>>>>> Since we probe UFO support, it will be disabled automatically on
>>>>>>> device
>>>>>>> startup.
>>>>>>>
>>>>>>> For the issue of migration, I think the only way is trying to fix
>>>>>>> it in
>>>>>>> kernel.
>>>>>> But 4.14 is around the corner and the patchset is already included.
>>>>>> Shouldn't this get fixed before 4.14 is released?
>>>>> We will try to seek a solution as soon as possible. If we can't catch
>>>>> 4.14, we will do it for stable for sure.
>>>> Jason, can you write to netdev and Cc Linus and me?
>>>
>>> Paolo, see this https://www.spinics.net/lists/netdev/msg465454.html
>>>
>>> Just notice this today since I'm not on the cc list.
>>
>> An update:
>>
>> After some discussions on netdev, we will try to bring UFO back
>> partially for just TAP. Willem promise to fix this. 4.14 is too late
>> consider the fix is not trivial, it will go through stable tree.
> 
> OK is it save to just revert the UFO patchset for my local branch?

Yes, it is.

Paolo

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Dr. David Alan Gilbert]

* Paolo Bonzini (pbonzini@redhat.com) wrote:
> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
> > HI Paolo,
> > 
> > could this patchset be related?
> 
> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
> disable UFO in the newest machine types, but do we also have to do
> (software) UFO in vhost-net and QEMU for migration compatibility?

Was there a solution to this?

Dave

> Thanks,
> 
> Paolo
> 
> > Greets,
> > Stefan
> > 
> > Am 06.11.2017 um 10:52 schrieb Stefan Priebe - Profihost AG:
> >> Hi Paolo,
> >>
> >> Am 06.11.2017 um 10:49 schrieb Paolo Bonzini:
> >>> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
> >>>> Hi Paolo,
> >>>>
> >>>> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
> >>>>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
> >>>>>> Hello,
> >>>>>>
> >>>>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
> >>>>>> 2.9.1.
> >>>>>>
> >>>>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
> >>>>>> i get:
> >>>>>>
> >>>>>> kvm: virtio-net: saved image requires TUN_F_UFO support
> >>>>>> kvm: Failed to load virtio-net-device:tmp
> >>>>>> kvm: Failed to load virtio-net:virtio
> >>>>>> kvm: error while loading state for instance 0x0 of device
> >>>>>> '0000:00:12.0/virtio-net'
> >>>>>> kvm: load of migration failed: Invalid argument
> >>>>>>
> >>>>>>
> >>>>>> while migrating from 4.12 to 4.4 works fine.
> >>>>>>
> >>>>>> Can anybody help? Is this expected?
> >>>>>
> >>>>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
> >>>>
> >>>> May be - how can i archieve this? Patching the code is not a problem if
> >>>> you can give me a hint.
> >>>>
> >>>>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
> >>>>> int tap_probe_has_ufo(int fd)
> >>>>> {
> >>>>>     unsigned offload;
> >>>>>
> >>>>>     offload = TUN_F_CSUM | TUN_F_UFO;
> >>>>>
> >>>>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
> >>>>>         return 0;
> >>>>>
> >>>>>     return 1;
> >>>>> }
> >>>>
> >>>> Should there be any kernel output or how can i detect / check it?
> >>>
> >>> For both, the simplest answer is probably just using printf.
> >>
> >> arg i missed an important part. The kernel is an opensuse SLE15 one.
> >>
> >> I've seen it contains the following patchset:
> >> https://www.spinics.net/lists/netdev/msg443821.html
> >>
> >> Greets,
> >> Stefan
> >>
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Stefan Priebe - Profihost AG]

Hello,

Am 22.11.2017 um 20:41 schrieb Dr. David Alan Gilbert:
> * Paolo Bonzini (pbonzini@redhat.com) wrote:
>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
>>> HI Paolo,
>>>
>>> could this patchset be related?
>>
>> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
>> disable UFO in the newest machine types, but do we also have to do
>> (software) UFO in vhost-net and QEMU for migration compatibility?
> 
> Was there a solution to this?

it will be this one:
https://patchwork.ozlabs.org/patch/840094/


Stefan

> Dave
> 
>> Thanks,
>>
>> Paolo
>>
>>> Greets,
>>> Stefan
>>>
>>> Am 06.11.2017 um 10:52 schrieb Stefan Priebe - Profihost AG:
>>>> Hi Paolo,
>>>>
>>>> Am 06.11.2017 um 10:49 schrieb Paolo Bonzini:
>>>>> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
>>>>>> Hi Paolo,
>>>>>>
>>>>>> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
>>>>>>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
>>>>>>>> Hello,
>>>>>>>>
>>>>>>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
>>>>>>>> 2.9.1.
>>>>>>>>
>>>>>>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
>>>>>>>> i get:
>>>>>>>>
>>>>>>>> kvm: virtio-net: saved image requires TUN_F_UFO support
>>>>>>>> kvm: Failed to load virtio-net-device:tmp
>>>>>>>> kvm: Failed to load virtio-net:virtio
>>>>>>>> kvm: error while loading state for instance 0x0 of device
>>>>>>>> '0000:00:12.0/virtio-net'
>>>>>>>> kvm: load of migration failed: Invalid argument
>>>>>>>>
>>>>>>>>
>>>>>>>> while migrating from 4.12 to 4.4 works fine.
>>>>>>>>
>>>>>>>> Can anybody help? Is this expected?
>>>>>>>
>>>>>>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
>>>>>>
>>>>>> May be - how can i archieve this? Patching the code is not a problem if
>>>>>> you can give me a hint.
>>>>>>
>>>>>>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
>>>>>>> int tap_probe_has_ufo(int fd)
>>>>>>> {
>>>>>>>     unsigned offload;
>>>>>>>
>>>>>>>     offload = TUN_F_CSUM | TUN_F_UFO;
>>>>>>>
>>>>>>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
>>>>>>>         return 0;
>>>>>>>
>>>>>>>     return 1;
>>>>>>> }
>>>>>>
>>>>>> Should there be any kernel output or how can i detect / check it?
>>>>>
>>>>> For both, the simplest answer is probably just using printf.
>>>>
>>>> arg i missed an important part. The kernel is an opensuse SLE15 one.
>>>>
>>>> I've seen it contains the following patchset:
>>>> https://www.spinics.net/lists/netdev/msg443821.html
>>>>
>>>> Greets,
>>>> Stefan
>>>>
>>
>>
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> 

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

[Dr. David Alan Gilbert]

* Stefan Priebe - Profihost AG (s.priebe@profihost.ag) wrote:
> Hello,
> 
> Am 22.11.2017 um 20:41 schrieb Dr. David Alan Gilbert:
> > * Paolo Bonzini (pbonzini@redhat.com) wrote:
> >> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote:
> >>> HI Paolo,
> >>>
> >>> could this patchset be related?
> >>
> >> Uh oh, yes it should.  Jason, any ways to fix it?  I suppose we need to
> >> disable UFO in the newest machine types, but do we also have to do
> >> (software) UFO in vhost-net and QEMU for migration compatibility?
> > 
> > Was there a solution to this?
> 
> it will be this one:
> https://patchwork.ozlabs.org/patch/840094/

Thanks; I've added a link to:
https://wiki.qemu.org/Features/Migration/Troubleshooting#virtio-net:_saved_image_requires_TUN_F_UFO_support

Dave

> 
> Stefan
> 
> > Dave
> > 
> >> Thanks,
> >>
> >> Paolo
> >>
> >>> Greets,
> >>> Stefan
> >>>
> >>> Am 06.11.2017 um 10:52 schrieb Stefan Priebe - Profihost AG:
> >>>> Hi Paolo,
> >>>>
> >>>> Am 06.11.2017 um 10:49 schrieb Paolo Bonzini:
> >>>>> On 06/11/2017 10:48, Stefan Priebe - Profihost AG wrote:
> >>>>>> Hi Paolo,
> >>>>>>
> >>>>>> Am 06.11.2017 um 10:40 schrieb Paolo Bonzini:
> >>>>>>> On 06/11/2017 10:38, Stefan Priebe - Profihost AG wrote:
> >>>>>>>> Hello,
> >>>>>>>>
> >>>>>>>> i've upgraded some servers from kernel 4.4 to 4.12 - both running Qemu
> >>>>>>>> 2.9.1.
> >>>>>>>>
> >>>>>>>> If i migrate a VM from a host running kernel 4.4 to a host running 4.12
> >>>>>>>> i get:
> >>>>>>>>
> >>>>>>>> kvm: virtio-net: saved image requires TUN_F_UFO support
> >>>>>>>> kvm: Failed to load virtio-net-device:tmp
> >>>>>>>> kvm: Failed to load virtio-net:virtio
> >>>>>>>> kvm: error while loading state for instance 0x0 of device
> >>>>>>>> '0000:00:12.0/virtio-net'
> >>>>>>>> kvm: load of migration failed: Invalid argument
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> while migrating from 4.12 to 4.4 works fine.
> >>>>>>>>
> >>>>>>>> Can anybody help? Is this expected?
> >>>>>>>
> >>>>>>> Can you check why peer_has_ufo failed (in hw/net/virtio-net.c)?
> >>>>>>
> >>>>>> May be - how can i archieve this? Patching the code is not a problem if
> >>>>>> you can give me a hint.
> >>>>>>
> >>>>>>> Also, did this ioctl fail when the tap device was set up on the 4.12 destination?
> >>>>>>> int tap_probe_has_ufo(int fd)
> >>>>>>> {
> >>>>>>>     unsigned offload;
> >>>>>>>
> >>>>>>>     offload = TUN_F_CSUM | TUN_F_UFO;
> >>>>>>>
> >>>>>>>     if (ioctl(fd, TUNSETOFFLOAD, offload) < 0)
> >>>>>>>         return 0;
> >>>>>>>
> >>>>>>>     return 1;
> >>>>>>> }
> >>>>>>
> >>>>>> Should there be any kernel output or how can i detect / check it?
> >>>>>
> >>>>> For both, the simplest answer is probably just using printf.
> >>>>
> >>>> arg i missed an important part. The kernel is an opensuse SLE15 one.
> >>>>
> >>>> I've seen it contains the following patchset:
> >>>> https://www.spinics.net/lists/netdev/msg443821.html
> >>>>
> >>>> Greets,
> >>>> Stefan
> >>>>
> >>
> >>
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> > 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK