[Buildroot] [PATCH v4 1/3] uboot: Use BR2_TARGET_UBOOT_SPL_NAME for TPL name

[Buildroot] [PATCH v4 1/3] uboot: Use BR2_TARGET_UBOOT_SPL_NAME for TPL name

[Jagan Teki]

Since BR2_TARGET_UBOOT_SPL_NAME can accept list of binaries,
the same config can reuse for TPL binary name as well.
So update the string and help text to indicate the same
config use for SPL and TPL.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Use BR2_TARGET_UBOOT_SPL_NAME for adding tpl binary
Changes for v3, v2:
- None

 boot/uboot/Config.in | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in
index 8215912..70e2bfd 100644
--- a/boot/uboot/Config.in
+++ b/boot/uboot/Config.in
@@ -334,13 +334,14 @@ config BR2_TARGET_UBOOT_SPL
 	  into DDR.
 
 config BR2_TARGET_UBOOT_SPL_NAME
-	string "U-Boot SPL binary image name"
+	string "U-Boot SPL/TPL binary image name(s)"
 	default "spl/u-boot-spl.bin"
 	depends on BR2_TARGET_UBOOT_SPL
 	help
-	  A space-separated list of SPL binaries, generated during
-	  u-boot build. For most platform it is spl/u-boot-spl.bin but
-	  not always. It is MLO on OMAP and SPL on i.MX6 for example.
+	  A space-separated list of SPL/TPL binaries, generated during
+	  u-boot build. For most platform SPL name is spl/u-boot-spl.bin
+	  and TPL name is tpl/u-boot-tpl.bin but not always. SPL name is
+	  MLO on OMAP and SPL on i.MX6 for example.
 
 config BR2_TARGET_UBOOT_ZYNQ_IMAGE
 	bool "Generate image for Xilinx Zynq"
-- 
1.9.1

[Buildroot] [PATCH v4 2/3] board: Add Vyasa RK388 board support

[Jagan Teki]

Add Vyasa board, from rk3288 family SOC.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- Use liux-next
- Add linux_gmac.fragment, rockchip gmac as module
- Add evetest command
- enable BR2_LINUX_KERNEL_INSTALL_TARGET 
Changes for v3:
- Fix ascending order in DEVELOPERS
- Fix u-boot-dtb.img offset
- Fix extlinux.conf label
Changes for v2:
- Bump to U-Boot v2017.11
- Bump to linux-next

 .gitlab-ci.yml                          |  1 +
 DEVELOPERS                              |  2 ++
 board/amarula/vyasa/extlinux.conf       |  4 +++
 board/amarula/vyasa/genimage.cfg        | 21 ++++++++++++
 board/amarula/vyasa/linux_gmac.fragment |  3 ++
 board/amarula/vyasa/post-build.sh       |  9 +++++
 board/amarula/vyasa/readme.txt          | 31 +++++++++++++++++
 configs/amarula_vyasa_rk3288_defconfig  | 59 +++++++++++++++++++++++++++++++++
 8 files changed, 130 insertions(+)
 create mode 100644 board/amarula/vyasa/extlinux.conf
 create mode 100644 board/amarula/vyasa/genimage.cfg
 create mode 100644 board/amarula/vyasa/linux_gmac.fragment
 create mode 100755 board/amarula/vyasa/post-build.sh
 create mode 100644 board/amarula/vyasa/readme.txt
 create mode 100644 configs/amarula_vyasa_rk3288_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 0dddb22..542663a 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -62,6 +62,7 @@ acmesystems_aria_g25_128mb_defconfig: *defconfig
 acmesystems_aria_g25_256mb_defconfig: *defconfig
 acmesystems_arietta_g25_128mb_defconfig: *defconfig
 acmesystems_arietta_g25_256mb_defconfig: *defconfig
+amarula_vyasa_rk3288_defconfig: *defconfig
 arcturus_ucp1020_defconfig: *defconfig
 arm_foundationv8_defconfig: *defconfig
 arm_juno_defconfig: *defconfig
diff --git a/DEVELOPERS b/DEVELOPERS
index c39348a..0db11e1 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -745,8 +745,10 @@ N:	Ilias Apalodimas <apalos@gmail.com>
 F:	package/keepalived/
 
 N:	Jagan Teki <jagan@amarulasolutions.com>
+F:	board/amarula/
 F:	board/bananapi/
 F:	board/engicam/
+F:	configs/amarula_vyasa_rk3288_defconfig
 F:	configs/bananapi_m1_defconfig
 F:	configs/engicam_imx6qdl_icore_defconfig
 F:	configs/engicam_imx6qdl_icore_qt5_defconfig
diff --git a/board/amarula/vyasa/extlinux.conf b/board/amarula/vyasa/extlinux.conf
new file mode 100644
index 0000000..a8fcc35
--- /dev/null
+++ b/board/amarula/vyasa/extlinux.conf
@@ -0,0 +1,4 @@
+label Vyasa linux-next
+  kernel /boot/uImage
+  devicetree /boot/rk3288-vyasa.dtb
+  append console=ttyS2,115200n8 root=/dev/mmcblk0p1 rootwait
diff --git a/board/amarula/vyasa/genimage.cfg b/board/amarula/vyasa/genimage.cfg
new file mode 100644
index 0000000..fa41de3
--- /dev/null
+++ b/board/amarula/vyasa/genimage.cfg
@@ -0,0 +1,21 @@
+image sdcard.img {
+	hdimage {
+	}
+
+	partition u-boot-tpl-spl-dtb {
+		in-partition-table = "no"
+		image = "u-boot-tpl-spl-dtb.img"
+		offset = 32K
+	}
+
+	partition u-boot-dtb {
+		in-partition-table = "no"
+		image = "u-boot-dtb.img"
+		offset = 8M
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
diff --git a/board/amarula/vyasa/linux_gmac.fragment b/board/amarula/vyasa/linux_gmac.fragment
new file mode 100644
index 0000000..dd458c7
--- /dev/null
+++ b/board/amarula/vyasa/linux_gmac.fragment
@@ -0,0 +1,3 @@
+# Currently kernel mainline exhibits issues when running rockchip gmac
+# on the board, so enable it as loadable module and insert it later
+CONFIG_DWMAC_ROCKCHIP=m
diff --git a/board/amarula/vyasa/post-build.sh b/board/amarula/vyasa/post-build.sh
new file mode 100755
index 0000000..ffbbcde
--- /dev/null
+++ b/board/amarula/vyasa/post-build.sh
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+MKIMAGE=$HOST_DIR/bin/mkimage
+BOARD_DIR="$(dirname $0)"
+
+$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-tpl.bin $BINARIES_DIR/u-boot-tpl.img
+cat $BINARIES_DIR/u-boot-tpl.img $BINARIES_DIR/u-boot-spl-dtb.bin > $BINARIES_DIR/u-boot-tpl-spl-dtb.img
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
diff --git a/board/amarula/vyasa/readme.txt b/board/amarula/vyasa/readme.txt
new file mode 100644
index 0000000..b95889e
--- /dev/null
+++ b/board/amarula/vyasa/readme.txt
@@ -0,0 +1,31 @@
+Vyasa RK3288
+============
+
+Vyasa is RK3288 based Single board computer with fully supported opensource software.
+
+https://openedev.amarulasolutions.com/display/ODWIKI/Vyasa+RK3288
+
+How to build it
+===============
+
+  $ make amarula_vyasa_rk3288_defconfig
+
+Then you can edit the build options using
+
+  $ make menuconfig
+
+Compile all and build rootfs image:
+
+  $ make
+
+Prepare your SDCard
+===================
+
+Buildroot generates a ready-to-use SD card image that you can flash directly to
+the card. The image will be in output/images/sdcard.img.
+You can write this image directly to an SD card device (i.e. /dev/xxx):
+
+  $ sudo dd if=output/images/sdcard.img of=/dev/xxx
+  $ sudo sync
+
+Finally, you can insert the SD card to the Vyasa RK3288 board, close J4 and boot it.
diff --git a/configs/amarula_vyasa_rk3288_defconfig b/configs/amarula_vyasa_rk3288_defconfig
new file mode 100644
index 0000000..5e62ac0
--- /dev/null
+++ b/configs/amarula_vyasa_rk3288_defconfig
@@ -0,0 +1,59 @@
+# Architecture
+BR2_arm=y
+BR2_cortex_a17=y
+BR2_ARM_FPU_NEON_VFPV4=y
+
+# Linux headers same as kernel, a 4.13 series
+BR2_KERNEL_HEADERS_4_13=y
+
+# Toolchain
+BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.11"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="vyasa-rk3288"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="7e8a1fd62911a59f1f95d4620e89603230fdd6f9"
+BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
+BR2_LINUX_KERNEL_UIMAGE=y
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-vyasa"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="board/amarula/vyasa/linux_gmac.fragment"
+
+# Filesystem
+BR2_TARGET_GENERIC_HOSTNAME="vyasa-rk3288"
+BR2_TARGET_GENERIC_ISSUE="Welcome to VYASA RK3288!"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="512M"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/amarula/vyasa/genimage.cfg"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/amarula/vyasa/post-build.sh"
+
+# evtest
+BR2_PACKAGE_EVTEST=y
+
+# qt5
+BR2_PACKAGE_QT5=y
+BR2_PACKAGE_QT5BASE_EXAMPLES=y
+BR2_PACKAGE_QT5BASE_GUI=y
+BR2_PACKAGE_QT5BASE_EGLFS=y
+BR2_PACKAGE_MALI_T76X=y
-- 
1.9.1

[Buildroot] [PATCH v4 3/3] board: Add Tinker RK388 board support

[Jagan Teki]

Add Tinker board, from rk3288 family SOC.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
Changes for v4:
- enable BR2_LINUX_KERNEL_INSTALL_TARGET 
- enable BR2_TARGET_UBOOT_FORMAT_DTB_BINe
- Create single u-boot binary
- Use linux-4.12 along with same headers

 .gitlab-ci.yml                       |  1 +
 DEVELOPERS                           |  2 ++
 board/asus/tinker/extlinux.conf      |  4 +++
 board/asus/tinker/genimage.cfg       | 15 ++++++++++
 board/asus/tinker/post-build.sh      |  9 ++++++
 board/asus/tinker/readme.txt         | 37 ++++++++++++++++++++++++
 configs/asus_tinker_rk3288_defconfig | 55 ++++++++++++++++++++++++++++++++++++
 7 files changed, 123 insertions(+)
 create mode 100644 board/asus/tinker/extlinux.conf
 create mode 100644 board/asus/tinker/genimage.cfg
 create mode 100755 board/asus/tinker/post-build.sh
 create mode 100644 board/asus/tinker/readme.txt
 create mode 100644 configs/asus_tinker_rk3288_defconfig

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 542663a..a9c0202 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -69,6 +69,7 @@ arm_juno_defconfig: *defconfig
 armadeus_apf27_defconfig: *defconfig
 armadeus_apf28_defconfig: *defconfig
 armadeus_apf51_defconfig: *defconfig
+asus_tinker_rk3288_defconfig: *defconfig
 at91sam9260eknf_defconfig: *defconfig
 at91sam9g20dfc_defconfig: *defconfig
 at91sam9g45m10ek_defconfig: *defconfig
diff --git a/DEVELOPERS b/DEVELOPERS
index 0db11e1..053d5e4 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -746,9 +746,11 @@ F:	package/keepalived/
 
 N:	Jagan Teki <jagan@amarulasolutions.com>
 F:	board/amarula/
+F:	board/asus/
 F:	board/bananapi/
 F:	board/engicam/
 F:	configs/amarula_vyasa_rk3288_defconfig
+F:	configs/asus_tinker_rk3288_defconfig
 F:	configs/bananapi_m1_defconfig
 F:	configs/engicam_imx6qdl_icore_defconfig
 F:	configs/engicam_imx6qdl_icore_qt5_defconfig
diff --git a/board/asus/tinker/extlinux.conf b/board/asus/tinker/extlinux.conf
new file mode 100644
index 0000000..136af0d
--- /dev/null
+++ b/board/asus/tinker/extlinux.conf
@@ -0,0 +1,4 @@
+label Tinker linux-next
+  kernel /boot/uImage
+  devicetree /boot/rk3288-tinker.dtb
+  append console=ttyS2,115200n8 root=/dev/mmcblk0p1 rootwait
diff --git a/board/asus/tinker/genimage.cfg b/board/asus/tinker/genimage.cfg
new file mode 100644
index 0000000..a4b1e8d
--- /dev/null
+++ b/board/asus/tinker/genimage.cfg
@@ -0,0 +1,15 @@
+image sdcard.img {
+	hdimage {
+	}
+
+	partition u-boot-spl-dtb {
+		in-partition-table = "no"
+		image = "u-boot-spl-dtb.img"
+		offset = 32K
+	}
+
+	partition rootfs {
+		partition-type = 0x83
+		image = "rootfs.ext4"
+	}
+}
diff --git a/board/asus/tinker/post-build.sh b/board/asus/tinker/post-build.sh
new file mode 100755
index 0000000..8108ed8
--- /dev/null
+++ b/board/asus/tinker/post-build.sh
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+MKIMAGE=$HOST_DIR/bin/mkimage
+BOARD_DIR="$(dirname $0)"
+
+$MKIMAGE -n rk3288 -T rksd -d $BINARIES_DIR/u-boot-spl-dtb.bin $BINARIES_DIR/u-boot-spl-dtb.img
+cat $BINARIES_DIR/u-boot-dtb.bin >> $BINARIES_DIR/u-boot-spl-dtb.img
+
+install -m 0644 -D $BOARD_DIR/extlinux.conf $TARGET_DIR/boot/extlinux/extlinux.conf
diff --git a/board/asus/tinker/readme.txt b/board/asus/tinker/readme.txt
new file mode 100644
index 0000000..7372d29
--- /dev/null
+++ b/board/asus/tinker/readme.txt
@@ -0,0 +1,37 @@
+Tinker RK3288
+=============
+
+Tinker Board is a Single Board Computer (SBC) in an ultra-small form
+factor that offers class-leading performance while leveraging outstanding
+mechanical compatibility.
+
+Tinker link:
+https://www.asus.com/in/Single-Board-Computer/Tinker-Board/
+
+Wiki link:
+https://openedev.amarulasolutions.com/display/ODWIKI/Tinker+RK3288
+
+How to build it
+===============
+
+  $ make asus_tinker_rk3288_defconfig
+
+Then you can edit the build options using
+
+  $ make menuconfig
+
+Compile all and build rootfs image:
+
+  $ make
+
+Prepare your SDCard
+===================
+
+Buildroot generates a ready-to-use SD card image that you can flash directly to
+the card. The image will be in output/images/sdcard.img.
+You can write this image directly to an SD card device (i.e. /dev/xxx):
+
+  $ sudo dd if=output/images/sdcard.img of=/dev/xxx
+  $ sudo sync
+
+Finally, you can insert the SD card to the Tinker RK3288 board and boot it.
diff --git a/configs/asus_tinker_rk3288_defconfig b/configs/asus_tinker_rk3288_defconfig
new file mode 100644
index 0000000..7f20cf1
--- /dev/null
+++ b/configs/asus_tinker_rk3288_defconfig
@@ -0,0 +1,55 @@
+# Architecture
+BR2_arm=y
+BR2_cortex_a17=y
+BR2_ARM_FPU_NEON_VFPV4=y
+
+# Linux headers same as kernel, a 4.12 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_12=y
+
+# Toolchain
+BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
+BR2_TOOLCHAIN_BUILDROOT_CXX=y
+
+# Bootloader
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.11"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="tinker-rk3288"
+BR2_TARGET_UBOOT_NEEDS_DTC=y
+BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
+BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
+BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y
+BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.12"
+BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
+BR2_LINUX_KERNEL_UIMAGE=y
+BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-tinker"
+BR2_LINUX_KERNEL_INSTALL_TARGET=y
+
+# Filesystem
+BR2_TARGET_GENERIC_HOSTNAME="tinker-rk3288"
+BR2_TARGET_GENERIC_ISSUE="Welcome to TINKER RK3288!"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+BR2_TARGET_ROOTFS_EXT2_SIZE="512M"
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y
+BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
+BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/asus/tinker/genimage.cfg"
+BR2_ROOTFS_POST_BUILD_SCRIPT="board/asus/tinker/post-build.sh"
+
+# qt5
+BR2_PACKAGE_QT5=y
+BR2_PACKAGE_QT5BASE_EXAMPLES=y
+BR2_PACKAGE_QT5BASE_GUI=y
+BR2_PACKAGE_QT5BASE_EGLFS=y
+BR2_PACKAGE_MALI_T76X=y
-- 
1.9.1

[Buildroot] [PATCH v4 2/3] board: Add Vyasa RK388 board support

[Jagan Teki]

On Sat, Nov 18, 2017 at 2:58 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote:
> Add Vyasa board, from rk3288 family SOC.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v4:
> - Use liux-next
> - Add linux_gmac.fragment, rockchip gmac as module
> - Add evetest command
> - enable BR2_LINUX_KERNEL_INSTALL_TARGET
> Changes for v3:
> - Fix ascending order in DEVELOPERS
> - Fix u-boot-dtb.img offset
> - Fix extlinux.conf label
> Changes for v2:
> - Bump to U-Boot v2017.11
> - Bump to linux-next

Any further comments?

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[Buildroot] [PATCH v4 1/3] uboot: Use BR2_TARGET_UBOOT_SPL_NAME for TPL name

[Thomas Petazzoni]

Hello,

On Sat, 18 Nov 2017 10:28:47 +0100, Jagan Teki wrote:
> Since BR2_TARGET_UBOOT_SPL_NAME can accept list of binaries,
> the same config can reuse for TPL binary name as well.
> So update the string and help text to indicate the same
> config use for SPL and TPL.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v4:
> - Use BR2_TARGET_UBOOT_SPL_NAME for adding tpl binary
> Changes for v3, v2:
> - None

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH v4 2/3] board: Add Vyasa RK388 board support

[Thomas Petazzoni]

Hello,

Title is wrong I believe, it shoul dbe RK3288 I guess.

On Sat, 18 Nov 2017 10:28:48 +0100, Jagan Teki wrote:

> diff --git a/board/amarula/vyasa/linux_gmac.fragment b/board/amarula/vyasa/linux_gmac.fragment
> new file mode 100644
> index 0000000..dd458c7
> --- /dev/null
> +++ b/board/amarula/vyasa/linux_gmac.fragment
> @@ -0,0 +1,3 @@
> +# Currently kernel mainline exhibits issues when running rockchip gmac
> +# on the board, so enable it as loadable module and insert it later
> +CONFIG_DWMAC_ROCKCHIP=m
> diff --git a/board/amarula/vyasa/post-build.sh b/board/amarula/vyasa/post-build.sh
> new file mode 100755
> index 0000000..ffbbcde
> --- /dev/null
> +++ b/board/amarula/vyasa/post-build.sh
> @@ -0,0 +1,9 @@
> +#!/bin/sh
> +
> +MKIMAGE=$HOST_DIR/bin/mkimage

So you need host-uboot-tools, but it is not enabled in your defconfig.


> diff --git a/configs/amarula_vyasa_rk3288_defconfig b/configs/amarula_vyasa_rk3288_defconfig
> new file mode 100644
> index 0000000..5e62ac0
> --- /dev/null
> +++ b/configs/amarula_vyasa_rk3288_defconfig
> @@ -0,0 +1,59 @@
> +# Architecture
> +BR2_arm=y
> +BR2_cortex_a17=y
> +BR2_ARM_FPU_NEON_VFPV4=y
> +
> +# Linux headers same as kernel, a 4.13 series
> +BR2_KERNEL_HEADERS_4_13=y
> +
> +# Toolchain
> +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y

Please keep the default toolchain configuration.

> +
> +# Bootloader
> +BR2_TARGET_UBOOT=y
> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.11"
> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="vyasa-rk3288"
> +BR2_TARGET_UBOOT_NEEDS_DTC=y
> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
> +BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
> +BR2_TARGET_UBOOT_SPL=y
> +BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="7e8a1fd62911a59f1f95d4620e89603230fdd6f9"

Using linux-next doesn't work, as it gets rebased constantly. The
commit 7e8a1fd62911a59f1f95d4620e89603230fdd6f9 no longer exists. You
have to wait for the support for this board to land into the mainline
kernel, or point to a vendor-specific Git tree.

> +# evtest
> +BR2_PACKAGE_EVTEST=y
> +
> +# qt5
> +BR2_PACKAGE_QT5=y
> +BR2_PACKAGE_QT5BASE_EXAMPLES=y
> +BR2_PACKAGE_QT5BASE_GUI=y
> +BR2_PACKAGE_QT5BASE_EGLFS=y
> +BR2_PACKAGE_MALI_T76X=y

Please remove this custom selection of packages. We want to have minimal
defconfigs in Buildroot.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 3/3] board: Add Tinker RK388 board support

[Thomas Petazzoni]

Hello,

On Sat, 18 Nov 2017 10:28:49 +0100, Jagan Teki wrote:
> Add Tinker board, from rk3288 family SOC.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>

Same question about the title: shouldn't it be RK3288 ?


> diff --git a/board/asus/tinker/post-build.sh b/board/asus/tinker/post-build.sh
> new file mode 100755
> index 0000000..8108ed8
> --- /dev/null
> +++ b/board/asus/tinker/post-build.sh
> @@ -0,0 +1,9 @@
> +#!/bin/sh
> +
> +MKIMAGE=$HOST_DIR/bin/mkimage

host-uboot-tools is needed.


> diff --git a/configs/asus_tinker_rk3288_defconfig b/configs/asus_tinker_rk3288_defconfig
> new file mode 100644
> index 0000000..7f20cf1
> --- /dev/null
> +++ b/configs/asus_tinker_rk3288_defconfig
> @@ -0,0 +1,55 @@
> +# Architecture
> +BR2_arm=y
> +BR2_cortex_a17=y
> +BR2_ARM_FPU_NEON_VFPV4=y
> +
> +# Linux headers same as kernel, a 4.12 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_12=y
> +
> +# Toolchain
> +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
> +BR2_TOOLCHAIN_BUILDROOT_CXX=y

Keep the default toolchain configuration.

> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.12"
> +BR2_LINUX_KERNEL_DEFCONFIG="multi_v7"
> +BR2_LINUX_KERNEL_UIMAGE=y
> +BR2_LINUX_KERNEL_UIMAGE_LOADADDR="0x02000000"
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="rk3288-tinker"
> +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> +
> +# Filesystem
> +BR2_TARGET_GENERIC_HOSTNAME="tinker-rk3288"
> +BR2_TARGET_GENERIC_ISSUE="Welcome to TINKER RK3288!"
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +BR2_TARGET_ROOTFS_EXT2_SIZE="512M"
> +BR2_PACKAGE_HOST_DOSFSTOOLS=y
> +BR2_PACKAGE_HOST_GENIMAGE=y
> +BR2_PACKAGE_HOST_MTOOLS=y
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/asus/tinker/genimage.cfg"
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/asus/tinker/post-build.sh"
> +
> +# qt5
> +BR2_PACKAGE_QT5=y
> +BR2_PACKAGE_QT5BASE_EXAMPLES=y
> +BR2_PACKAGE_QT5BASE_GUI=y
> +BR2_PACKAGE_QT5BASE_EGLFS=y
> +BR2_PACKAGE_MALI_T76X=y

And keep the configuration minimal by not adding Qt5/OpenGL.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH v4 2/3] board: Add Vyasa RK388 board support

[Jagan Teki]

Hi Thomas,

On Fri, Nov 24, 2017 at 3:13 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> Title is wrong I believe, it shoul dbe RK3288 I guess.
>
> On Sat, 18 Nov 2017 10:28:48 +0100, Jagan Teki wrote:
>
>> diff --git a/board/amarula/vyasa/linux_gmac.fragment b/board/amarula/vyasa/linux_gmac.fragment
>> new file mode 100644
>> index 0000000..dd458c7
>> --- /dev/null
>> +++ b/board/amarula/vyasa/linux_gmac.fragment
>> @@ -0,0 +1,3 @@
>> +# Currently kernel mainline exhibits issues when running rockchip gmac
>> +# on the board, so enable it as loadable module and insert it later
>> +CONFIG_DWMAC_ROCKCHIP=m
>> diff --git a/board/amarula/vyasa/post-build.sh b/board/amarula/vyasa/post-build.sh
>> new file mode 100755
>> index 0000000..ffbbcde
>> --- /dev/null
>> +++ b/board/amarula/vyasa/post-build.sh
>> @@ -0,0 +1,9 @@
>> +#!/bin/sh
>> +
>> +MKIMAGE=$HOST_DIR/bin/mkimage
>
> So you need host-uboot-tools, but it is not enabled in your defconfig.
>
>
>> diff --git a/configs/amarula_vyasa_rk3288_defconfig b/configs/amarula_vyasa_rk3288_defconfig
>> new file mode 100644
>> index 0000000..5e62ac0
>> --- /dev/null
>> +++ b/configs/amarula_vyasa_rk3288_defconfig
>> @@ -0,0 +1,59 @@
>> +# Architecture
>> +BR2_arm=y
>> +BR2_cortex_a17=y
>> +BR2_ARM_FPU_NEON_VFPV4=y
>> +
>> +# Linux headers same as kernel, a 4.13 series
>> +BR2_KERNEL_HEADERS_4_13=y
>> +
>> +# Toolchain
>> +BR2_TOOLCHAIN_BUILDROOT_GLIBC=y
>> +BR2_TOOLCHAIN_BUILDROOT_CXX=y
>
> Please keep the default toolchain configuration.
>
>> +
>> +# Bootloader
>> +BR2_TARGET_UBOOT=y
>> +BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
>> +BR2_TARGET_UBOOT_CUSTOM_VERSION=y
>> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2017.11"
>> +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="vyasa-rk3288"
>> +BR2_TARGET_UBOOT_NEEDS_DTC=y
>> +BR2_TARGET_UBOOT_NEEDS_OPENSSL=y
>> +BR2_TARGET_UBOOT_FORMAT_DTB_IMG=y
>> +BR2_TARGET_UBOOT_SPL=y
>> +BR2_TARGET_UBOOT_SPL_NAME="spl/u-boot-spl-dtb.bin tpl/u-boot-tpl.bin"
>> +
>> +# Kernel
>> +BR2_LINUX_KERNEL=y
>> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
>> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git"
>> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="7e8a1fd62911a59f1f95d4620e89603230fdd6f9"
>
> Using linux-next doesn't work, as it gets rebased constantly. The
> commit 7e8a1fd62911a59f1f95d4620e89603230fdd6f9 no longer exists. You
> have to wait for the support for this board to land into the mainline
> kernel, or point to a vendor-specific Git tree.

Can't we use linux-next at all? you are with head commits which were
always changes during rebase, but I've used the board specific commit
in v5 and that will always unchanged.

If you remember I've asked during ELCE, Prague about using linux-next
on BR and we discussed the same scenario.

thanks!
-- 
Jagan Teki
Senior Linux Kernel Engineer | Amarula Solutions
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[Buildroot] [PATCH v4 2/3] board: Add Vyasa RK388 board support

[Thomas Petazzoni]

Hello,

On Wed, 29 Nov 2017 12:37:05 +0530, Jagan Teki wrote:

> > Using linux-next doesn't work, as it gets rebased constantly. The
> > commit 7e8a1fd62911a59f1f95d4620e89603230fdd6f9 no longer exists. You
> > have to wait for the support for this board to land into the mainline
> > kernel, or point to a vendor-specific Git tree.  
> 
> Can't we use linux-next at all? you are with head commits which were
> always changes during rebase, but I've used the board specific commit
> in v5 and that will always unchanged.

No, you can't use linux-next, as commits are not stable.

Please try yourself: wait a few days, delete your Buildroot download
folder entirely, and try to build your defconfig: it will fail, because
the git commit no longer exists on the linux-next Git repository.

If the commit still exists, then it means that it's a commit that is
part of Linus tree, in which case there is no point in using linux-next.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com