* [Buildroot] [PATCH 1/1] janus-gateway: add option for libcurl support
@ 2017-11-03 10:23 Olivier Maignial
2017-11-19 21:04 ` Adam Duskett
2017-11-23 22:15 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Olivier Maignial @ 2017-11-03 10:23 UTC (permalink / raw)
To: buildroot
libcurl is not mandatory to compile Janus, but Janus use it in several way:
- RTSP stream support in plugin streaming
- TURN REST API support
- HTTP backend for text room plugin
- ...
This commit add an option "libcurl support" to add dependency on libcurl.
Signed-off-by: Olivier Maignial <olivier.maignial@smile.fr>
---
package/janus-gateway/Config.in | 18 ++++++++++++++++++
package/janus-gateway/janus-gateway.mk | 4 ++++
2 files changed, 22 insertions(+)
diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
index 5bd4e95..156fac6 100644
--- a/package/janus-gateway/Config.in
+++ b/package/janus-gateway/Config.in
@@ -38,6 +38,12 @@ config BR2_PACKAGE_JANUS_STREAMING
# SO_REUSEPORT
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
+if BR2_PACKAGE_JANUS_STREAMING
+config BR2_PACKAGE_JANUS_STREAMING_RTSP
+ bool "Support RTSP feed"
+ select BR2_PACKAGE_JANUS_LIBCURL
+endif
+
comment "streaming plugin needs a toolchain w/ headers >= 3.9"
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
@@ -77,6 +83,7 @@ config BR2_PACKAGE_JANUS_REST
bool "REST (HTTP/HTTPS)"
depends on BR2_TOOLCHAIN_HAS_THREADS
select BR2_PACKAGE_LIBMICROHTTPD
+ select BR2_PACKAGE_JANUS_LIBCURL
comment "REST transport needs a toolchain w/ threads"
depends on !BR2_TOOLCHAIN_HAS_THREADS
@@ -90,6 +97,17 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
depends on BR2_USE_MMU
select BR2_PACKAGE_LIBWEBSOCKETS
+comment "libcurl support"
+
+config BR2_PACKAGE_JANUS_LIBCURL
+ bool "Enable libcurl support"
+ default y
+ help
+ Janus uses libcurl to several purposes:
+ - Enable TURN REST API
+ - Implement Sample Event Handler plugin
+ - Support RTSP stream in streaming plugin
+
endif
comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
index bf3e590..7314d1c 100644
--- a/package/janus-gateway/janus-gateway.mk
+++ b/package/janus-gateway/janus-gateway.mk
@@ -117,6 +117,10 @@ else
JANUS_GATEWAY_CONF_OPTS += --disable-websockets
endif
+ifeq ($(BR2_PACKAGE_JANUS_LIBCURL),y)
+JANUS_GATEWAY_DEPENDENCIES += libcurl
+endif
+
# Parallel build broken
JANUS_GATEWAY_MAKE = $(MAKE1)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] janus-gateway: add option for libcurl support
2017-11-03 10:23 [Buildroot] [PATCH 1/1] janus-gateway: add option for libcurl support Olivier Maignial
@ 2017-11-19 21:04 ` Adam Duskett
2017-11-23 22:15 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Adam Duskett @ 2017-11-19 21:04 UTC (permalink / raw)
To: buildroot
Hello
On Fri, Nov 3, 2017 at 6:23 AM, Olivier Maignial
<olivier.maignial@smile.fr> wrote:
> libcurl is not mandatory to compile Janus, but Janus use it in several way:
> - RTSP stream support in plugin streaming
> - TURN REST API support
> - HTTP backend for text room plugin
> - ...
> This commit add an option "libcurl support" to add dependency on libcurl.
>
> Signed-off-by: Olivier Maignial <olivier.maignial@smile.fr>
> ---
> package/janus-gateway/Config.in | 18 ++++++++++++++++++
> package/janus-gateway/janus-gateway.mk | 4 ++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/package/janus-gateway/Config.in b/package/janus-gateway/Config.in
> index 5bd4e95..156fac6 100644
> --- a/package/janus-gateway/Config.in
> +++ b/package/janus-gateway/Config.in
> @@ -38,6 +38,12 @@ config BR2_PACKAGE_JANUS_STREAMING
> # SO_REUSEPORT
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>
> +if BR2_PACKAGE_JANUS_STREAMING
> +config BR2_PACKAGE_JANUS_STREAMING_RTSP
> + bool "Support RTSP feed"
> + select BR2_PACKAGE_JANUS_LIBCURL
> +endif
> +
This should be in a seperate patch.
> comment "streaming plugin needs a toolchain w/ headers >= 3.9"
> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>
> @@ -77,6 +83,7 @@ config BR2_PACKAGE_JANUS_REST
> bool "REST (HTTP/HTTPS)"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_LIBMICROHTTPD
> + select BR2_PACKAGE_JANUS_LIBCURL
>
1) There's a trailing whitespace here.
2) This wasn't mandatory before, and shouldn't be mandatory now.
> comment "REST transport needs a toolchain w/ threads"
> depends on !BR2_TOOLCHAIN_HAS_THREADS
> @@ -90,6 +97,17 @@ config BR2_PACKAGE_JANUS_WEBSOCKETS
> depends on BR2_USE_MMU
> select BR2_PACKAGE_LIBWEBSOCKETS
>
> +comment "libcurl support"
Do we really need a comment for this?
> +
> +config BR2_PACKAGE_JANUS_LIBCURL
> + bool "Enable libcurl support"
> + default y
The default shouldn't be yes, some users don't want libcurl support.
> + help
> + Janus uses libcurl to several purposes:
to -> for
> + - Enable TURN REST API
There's a trailing whitespace here as well.
> + - Implement Sample Event Handler plugin
> + - Support RTSP stream in streaming plugin
> +
> endif
>
> comment "janus-gateway needs a toolchain w/ dynamic library, threads, wchar"
> diff --git a/package/janus-gateway/janus-gateway.mk b/package/janus-gateway/janus-gateway.mk
> index bf3e590..7314d1c 100644
> --- a/package/janus-gateway/janus-gateway.mk
> +++ b/package/janus-gateway/janus-gateway.mk
> @@ -117,6 +117,10 @@ else
> JANUS_GATEWAY_CONF_OPTS += --disable-websockets
> endif
>
> +ifeq ($(BR2_PACKAGE_JANUS_LIBCURL),y)
> +JANUS_GATEWAY_DEPENDENCIES += libcurl
> +endif
> +
> # Parallel build broken
> JANUS_GATEWAY_MAKE = $(MAKE1)
>
> --
> 2.7.4
>
Thanks!
Adam
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] janus-gateway: add option for libcurl support
2017-11-03 10:23 [Buildroot] [PATCH 1/1] janus-gateway: add option for libcurl support Olivier Maignial
2017-11-19 21:04 ` Adam Duskett
@ 2017-11-23 22:15 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2017-11-23 22:15 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 3 Nov 2017 11:23:59 +0100, Olivier Maignial wrote:
> libcurl is not mandatory to compile Janus, but Janus use it in several way:
> - RTSP stream support in plugin streaming
> - TURN REST API support
> - HTTP backend for text room plugin
> - ...
> This commit add an option "libcurl support" to add dependency on libcurl.
>
> Signed-off-by: Olivier Maignial <olivier.maignial@smile.fr>
> ---
> package/janus-gateway/Config.in | 18 ++++++++++++++++++
> package/janus-gateway/janus-gateway.mk | 4 ++++
> 2 files changed, 22 insertions(+)
You received some comments from Adam Duskett on this patch. Do you
think you will be able to send an updated version of this patch that
takes into account the comments?
I will mark your patch as Changes Requested in our patch tracking
system, which means that if you don't resend a new version, we will
forget about your patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-23 22:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-03 10:23 [Buildroot] [PATCH 1/1] janus-gateway: add option for libcurl support Olivier Maignial
2017-11-19 21:04 ` Adam Duskett
2017-11-23 22:15 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.