* [PATCH] drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
@ 2017-11-23 23:37 Chris Wilson
2017-11-23 23:56 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Chris Wilson @ 2017-11-23 23:37 UTC (permalink / raw)
To: intel-gfx
Since the removal of the delayed rc6 enabling, we now setup and drop the
early rpm wakeref during modules initialisation before we start the live
selftests. As such, we are now detecting errors in the tests where we
were not holding the required wakeref for various actions. As rpm is not
the primary goal of the tests involved, take a coarse and convenient rpm
wakeref around the tests.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.william.auld@gmail.com>
---
drivers/gpu/drm/i915/selftests/huge_pages.c | 2 ++
drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 2 ++
2 files changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/selftests/huge_pages.c b/drivers/gpu/drm/i915/selftests/huge_pages.c
index df1befe2c793..e6b31041cc88 100644
--- a/drivers/gpu/drm/i915/selftests/huge_pages.c
+++ b/drivers/gpu/drm/i915/selftests/huge_pages.c
@@ -1749,6 +1749,7 @@ int i915_gem_huge_page_live_selftests(struct drm_i915_private *dev_priv)
return PTR_ERR(file);
mutex_lock(&dev_priv->drm.struct_mutex);
+ intel_runtime_pm_get(dev_priv);
ctx = live_context(dev_priv, file);
if (IS_ERR(ctx)) {
@@ -1759,6 +1760,7 @@ int i915_gem_huge_page_live_selftests(struct drm_i915_private *dev_priv)
err = i915_subtests(tests, ctx);
out_unlock:
+ intel_runtime_pm_put(dev_priv);
mutex_unlock(&dev_priv->drm.struct_mutex);
mock_file_free(dev_priv, file);
diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
index f463105ff48d..e1ddad635d73 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_evict.c
@@ -355,6 +355,7 @@ static int igt_evict_contexts(void *arg)
return 0;
mutex_lock(&i915->drm.struct_mutex);
+ intel_runtime_pm_get(i915);
/* Reserve a block so that we know we have enough to fit a few rq */
memset(&hole, 0, sizeof(hole));
@@ -463,6 +464,7 @@ static int igt_evict_contexts(void *arg)
}
if (drm_mm_node_allocated(&hole))
drm_mm_remove_node(&hole);
+ intel_runtime_pm_put(i915);
mutex_unlock(&i915->drm.struct_mutex);
return err;
--
2.15.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
2017-11-23 23:37 [PATCH] drm/i915/selftests: Hold rpm wakeref for request + ggtt usage Chris Wilson
@ 2017-11-23 23:56 ` Patchwork
2017-11-24 0:13 ` [PATCH] " Matthew Auld
2017-11-24 1:28 ` ✗ Fi.CI.IGT: warning for " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-11-23 23:56 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
URL : https://patchwork.freedesktop.org/series/34334/
State : success
== Summary ==
Series 34334v1 drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
https://patchwork.freedesktop.org/api/1.0/series/34334/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (fi-cfl-s2)
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:442s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:462s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:388s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:541s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:279s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:506s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:506s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:502s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:492s
fi-cfl-s2 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:616s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:430s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:263s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:542s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:432s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:440s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:432s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:473s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:461s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:575s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:457s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:547s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:563s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:522s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:502s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:461s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:571s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:427s
Blacklisted hosts:
fi-cnl-y total:289 pass:261 dwarn:1 dfail:0 fail:0 skip:27 time:575s
fi-glk-dsi total:18 pass:17 dwarn:0 dfail:0 fail:0 skip:0
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:478s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:528s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:483s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:529s
b407e5f38397c0c22b5056a1664753287993b152 drm-tip: 2017y-11m-23d-16h-14m-59s UTC integration manifest
dcdbce940b87 drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7271/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
2017-11-23 23:37 [PATCH] drm/i915/selftests: Hold rpm wakeref for request + ggtt usage Chris Wilson
2017-11-23 23:56 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-11-24 0:13 ` Matthew Auld
2017-11-24 9:32 ` Chris Wilson
2017-11-24 1:28 ` ✗ Fi.CI.IGT: warning for " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Matthew Auld @ 2017-11-24 0:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: Intel Graphics Development
On 23 November 2017 at 23:37, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Since the removal of the delayed rc6 enabling, we now setup and drop the
> early rpm wakeref during modules initialisation before we start the live
> selftests. As such, we are now detecting errors in the tests where we
> were not holding the required wakeref for various actions. As rpm is not
> the primary goal of the tests involved, take a coarse and convenient rpm
> wakeref around the tests.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.william.auld@gmail.com>
Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* ✗ Fi.CI.IGT: warning for drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
2017-11-23 23:37 [PATCH] drm/i915/selftests: Hold rpm wakeref for request + ggtt usage Chris Wilson
2017-11-23 23:56 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-24 0:13 ` [PATCH] " Matthew Auld
@ 2017-11-24 1:28 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2017-11-24 1:28 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
URL : https://patchwork.freedesktop.org/series/34334/
State : warning
== Summary ==
Test kms_chv_cursor_fail:
Subgroup pipe-b-128x128-top-edge:
pass -> SKIP (shard-hsw)
Test kms_force_connector_basic:
Subgroup prune-stale-modes:
skip -> PASS (shard-hsw)
Test drv_selftest:
Subgroup mock_sanitycheck:
pass -> DMESG-WARN (shard-snb) fdo#103717
Test drv_module_reload:
Subgroup basic-reload-inject:
pass -> DMESG-WARN (shard-snb) fdo#102707 +1
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
pass -> FAIL (shard-snb) fdo#101623
Test kms_sysfs_edid_timing:
pass -> WARN (shard-hsw) fdo#100047
Test gem_busy:
Subgroup close-race:
pass -> FAIL (shard-snb) fdo#103829
fdo#103717 https://bugs.freedesktop.org/show_bug.cgi?id=103717
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
fdo#103829 https://bugs.freedesktop.org/show_bug.cgi?id=103829
shard-hsw total:2667 pass:1533 dwarn:2 dfail:0 fail:10 skip:1121 time:9523s
shard-snb total:2667 pass:1309 dwarn:3 dfail:0 fail:14 skip:1341 time:8095s
Blacklisted hosts:
shard-apl total:2645 pass:1666 dwarn:2 dfail:0 fail:22 skip:954 time:13223s
shard-kbl total:2667 pass:1801 dwarn:1 dfail:0 fail:25 skip:840 time:10916s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7271/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/i915/selftests: Hold rpm wakeref for request + ggtt usage
2017-11-24 0:13 ` [PATCH] " Matthew Auld
@ 2017-11-24 9:32 ` Chris Wilson
0 siblings, 0 replies; 5+ messages in thread
From: Chris Wilson @ 2017-11-24 9:32 UTC (permalink / raw)
To: Matthew Auld; +Cc: Intel Graphics Development
Quoting Matthew Auld (2017-11-24 00:13:47)
> On 23 November 2017 at 23:37, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Since the removal of the delayed rc6 enabling, we now setup and drop the
> > early rpm wakeref during modules initialisation before we start the live
> > selftests. As such, we are now detecting errors in the tests where we
> > were not holding the required wakeref for various actions. As rpm is not
> > the primary goal of the tests involved, take a coarse and convenient rpm
> > wakeref around the tests.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Matthew Auld <matthew.william.auld@gmail.com>
> Reviewed-by: Matthew Auld <matthew.william.auld@gmail.com>
Thanks, pushed. I'm scratching my head a bit why I see this but CI
doesn't... Either that or I've overlooked the dmesg-warns?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-24 9:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-23 23:37 [PATCH] drm/i915/selftests: Hold rpm wakeref for request + ggtt usage Chris Wilson
2017-11-23 23:56 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-11-24 0:13 ` [PATCH] " Matthew Auld
2017-11-24 9:32 ` Chris Wilson
2017-11-24 1:28 ` ✗ Fi.CI.IGT: warning for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.