From: Michal Hocko <mhocko@kernel.org>
To: Vaneet Narang <v.narang@samsung.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Maninder Singh <maninder1.s@samsung.com>,
"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"guptap@codeaurora.org" <guptap@codeaurora.org>,
"vinmenon@codeaurora.org" <vinmenon@codeaurora.org>,
AMIT SAHRAWAT <a.sahrawat@samsung.com>,
PANKAJ MISHRA <pankaj.m@samsung.com>,
Lalit Mohan Tripathi <lalit.mohan@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.
Date: Fri, 24 Nov 2017 14:48:08 +0100 [thread overview]
Message-ID: <20171124134808.ixyqzmzzyamja4ao@dhcp22.suse.cz> (raw)
In-Reply-To: <20171124133025epcms5p7dc263c4a831552245e60193917a45b07@epcms5p7>
On Fri 24-11-17 13:30:25, Vaneet Narang wrote:
> Hi Michal,
>
> >> We have been getting similar kind of such entries and eventually
> >> stackdepot reaches Max Cap. So we found this interface useful in debugging
> >> stackdepot issue so shared in community.
>
> >Then use it for internal debugging and provide a code which would scale
> >better on smaller systems. We do not need this in the kernel IMHO. We do
> >not merge all the debugging patches we use for internal development.
> `
> Not just debugging but this information can also be used to profile and tune stack depot.
> Getting count of stack entries would help in deciding hash table size and
> page order used by stackdepot.
How can you control that in runtime?
> For less entries, bigger hash table and higher page order slabs might not be required as
> maintained by stackdepot. As i already mentioned smaller size hashtable can be choosen and
> similarly lower order pages can be used for slabs.
>
> If you think its useful, we can share scalable patch to configure below two values based on
> number of stack entries dynamically.
Exporting this data without having a way to control it is just not very
useful for upstream kernel. If you can come up with some dynamic tuning
then that might be interesting. But your patch doesn't seem useful
outside of the development enviroment AFAICS.
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Vaneet Narang <v.narang@samsung.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
Maninder Singh <maninder1.s@samsung.com>,
"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"vbabka@suse.cz" <vbabka@suse.cz>,
"guptap@codeaurora.org" <guptap@codeaurora.org>,
"vinmenon@codeaurora.org" <vinmenon@codeaurora.org>,
AMIT SAHRAWAT <a.sahrawat@samsung.com>,
PANKAJ MISHRA <pankaj.m@samsung.com>,
Lalit Mohan Tripathi <lalit.mohan@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
kasan-dev <kasan-dev@googlegroups.com>
Subject: Re: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.
Date: Fri, 24 Nov 2017 14:48:08 +0100 [thread overview]
Message-ID: <20171124134808.ixyqzmzzyamja4ao@dhcp22.suse.cz> (raw)
In-Reply-To: <20171124133025epcms5p7dc263c4a831552245e60193917a45b07@epcms5p7>
On Fri 24-11-17 13:30:25, Vaneet Narang wrote:
> Hi Michal,
>
> >> We have been getting similar kind of such entries and eventually
> >> stackdepot reaches Max Cap. So we found this interface useful in debugging
> >> stackdepot issue so shared in community.
>
> >Then use it for internal debugging and provide a code which would scale
> >better on smaller systems. We do not need this in the kernel IMHO. We do
> >not merge all the debugging patches we use for internal development.
> `
> Not just debugging but this information can also be used to profile and tune stack depot.
> Getting count of stack entries would help in deciding hash table size and
> page order used by stackdepot.
How can you control that in runtime?
> For less entries, bigger hash table and higher page order slabs might not be required as
> maintained by stackdepot. As i already mentioned smaller size hashtable can be choosen and
> similarly lower order pages can be used for slabs.
>
> If you think its useful, we can share scalable patch to configure below two values based on
> number of stack entries dynamically.
Exporting this data without having a way to control it is just not very
useful for upstream kernel. If you can come up with some dynamic tuning
then that might be interesting. But your patch doesn't seem useful
outside of the development enviroment AFAICS.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-24 13:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20171122105142epcas5p173b7205da12e1fc72e16ec74c49db665@epcas5p1.samsung.com>
2017-11-22 10:47 ` [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot Maninder Singh
2017-11-22 10:47 ` Maninder Singh
2017-11-23 16:28 ` Michal Hocko
2017-11-23 16:28 ` Michal Hocko
[not found] ` <CGME20171122105142epcas5p173b7205da12e1fc72e16ec74c49db665@epcms5p3>
2017-11-24 9:41 ` Maninder Singh
2017-11-24 9:41 ` Maninder Singh
2017-11-24 9:54 ` Michal Hocko
2017-11-24 9:54 ` Michal Hocko
2017-11-24 10:23 ` Dmitry Vyukov
2017-11-24 10:23 ` Dmitry Vyukov
[not found] ` <CGME20171122105142epcas5p173b7205da12e1fc72e16ec74c49db665@epcms5p4>
2017-11-24 11:57 ` Vaneet Narang
2017-11-24 11:57 ` Vaneet Narang
2017-11-24 12:44 ` Michal Hocko
2017-11-24 12:44 ` Michal Hocko
[not found] ` <CGME20171122105142epcas5p173b7205da12e1fc72e16ec74c49db665@epcms5p7>
2017-11-24 13:30 ` Vaneet Narang
2017-11-24 13:30 ` Vaneet Narang
2017-11-24 13:48 ` Michal Hocko [this message]
2017-11-24 13:48 ` Michal Hocko
2017-11-28 3:37 ` Vinayak Menon
2017-11-28 3:37 ` Vinayak Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124134808.ixyqzmzzyamja4ao@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=a.sahrawat@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=guptap@codeaurora.org \
--cc=jpoimboe@redhat.com \
--cc=kasan-dev@googlegroups.com \
--cc=kstewart@linuxfoundation.org \
--cc=lalit.mohan@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=pombredanne@nexb.com \
--cc=v.narang@samsung.com \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.