All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset
@ 2017-11-27 18:51 Jakub Kicinski
  2017-11-27 20:33 ` Jakub Kicinski
  0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2017-11-27 18:51 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolai Stange
  Cc: linux-kernel, oss-drivers, Jakub Kicinski

Recent commit moved the implementation of debugfs_real_fops()
out of the header file.  The declaration, however, is only
provided if CONFIG_DEBUG_FS is set.  Add an empty static inline
definition for when CONFIG_DEBUG_FS is unset.

Fixes: 7c8d469877b1 ("debugfs: add support for more elaborate ->d_fsdata")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
---
 include/linux/debugfs.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
index f36ecc2a5712..b1dc23cc0214 100644
--- a/include/linux/debugfs.h
+++ b/include/linux/debugfs.h
@@ -216,6 +216,11 @@ static inline void debugfs_remove(struct dentry *dentry)
 static inline void debugfs_remove_recursive(struct dentry *dentry)
 { }
 
+const struct file_operations *debugfs_real_fops(const struct file *filp)
+{
+	return NULL;
+}
+
 static inline int debugfs_file_get(struct dentry *dentry)
 {
 	return 0;
-- 
2.14.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset
  2017-11-27 18:51 [PATCH] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset Jakub Kicinski
@ 2017-11-27 20:33 ` Jakub Kicinski
  0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2017-11-27 20:33 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Nicolai Stange; +Cc: linux-kernel, oss-drivers

On Mon, 27 Nov 2017 10:51:34 -0800, Jakub Kicinski wrote:
> Recent commit moved the implementation of debugfs_real_fops()
> out of the header file.  The declaration, however, is only
> provided if CONFIG_DEBUG_FS is set.  Add an empty static inline
> definition for when CONFIG_DEBUG_FS is unset.
> 
> Fixes: 7c8d469877b1 ("debugfs: add support for more elaborate ->d_fsdata")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>

Argh, should've been a static inline.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-27 20:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 18:51 [PATCH] debugfs: add definition of debugfs_real_fops() if CONFIG_DEBUG_FS unset Jakub Kicinski
2017-11-27 20:33 ` Jakub Kicinski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.