All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Benjamin Gaignard" <benjamin.gaignard@linaro.org>,
	driverdevel <devel@driverdev.osuosl.org>,
	linux-api@vger.kernel.org, "Arve Hjønnevåg" <arve@android.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Riley Andrews" <riandrews@android.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Dan Carpenter" <dan.carpenter@oracle.com>
Subject: Re: [PATCH v6 2/2] staging: ion: create one device entry per heap
Date: Mon, 27 Nov 2017 17:12:23 +0100	[thread overview]
Message-ID: <20171127161222.oig34dt2uc4lzpk2@phenom.ffwll.local> (raw)
In-Reply-To: <20171127114357.GB3710@kroah.com>

On Mon, Nov 27, 2017 at 12:43:57PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote:
> > 2017-11-09 22:17 GMT+01:00 Laura Abbott <labbott@redhat.com>:
> > > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote:
> > >>
> > >> Instead a getting only one common device "/dev/ion" for
> > >> all the heaps this patch allow to create one device
> > >> entry ("/dev/ionX") per heap.
> > >> Getting an entry per heap could allow to set security rules
> > >> per heap and global ones for all heaps.
> > >>
> > >> Allocation requests will be only allowed if the mask_id
> > >> match with device minor.
> > >> Query request could be done on any of the devices.
> > >>
> > >
> > > With this patch, sysfs looks like:
> > >
> > > $ ls /sys/devices/
> > > breakpoint ion platform software system virtual
> > >
> > > From an Ion perspective, you can have
> > >
> > > Acked-by: Laura Abbott <labbott@redhat.com>
> > >
> > > Another Ack for the device model stuff would be good but I'll
> > > assume deafening silence means nobody hates it.
> > 
> > Greg, can we get your point of view of this ?
> 
> It's 1 day after the merge window has closed, and my todo patch queue
> looks like this:
> 	$ mdfrm -c ~/mail/todo/
> 	1523 messages in /home/gregkh/mail/todo/
> 
> Please give me a chance to catch up...

commit model ftw, we have 400+ patches for 4.16 already merged and tested
and all ready, right when -rc1 gets tagged. Makes the merge window the
most relaxed time of all, because all the other maintainers are drowning
and wont pester you.

Just saying, this is an entirely fixable problem :-P

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: driverdevel <devel@driverdev.osuosl.org>,
	linux-api@vger.kernel.org,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Riley Andrews" <riandrews@android.com>,
	"Dan Carpenter" <dan.carpenter@oracle.com>
Subject: Re: [PATCH v6 2/2] staging: ion: create one device entry per heap
Date: Mon, 27 Nov 2017 17:12:23 +0100	[thread overview]
Message-ID: <20171127161222.oig34dt2uc4lzpk2@phenom.ffwll.local> (raw)
In-Reply-To: <20171127114357.GB3710@kroah.com>

On Mon, Nov 27, 2017 at 12:43:57PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Nov 27, 2017 at 11:46:18AM +0100, Benjamin Gaignard wrote:
> > 2017-11-09 22:17 GMT+01:00 Laura Abbott <labbott@redhat.com>:
> > > On 11/06/2017 07:59 AM, Benjamin Gaignard wrote:
> > >>
> > >> Instead a getting only one common device "/dev/ion" for
> > >> all the heaps this patch allow to create one device
> > >> entry ("/dev/ionX") per heap.
> > >> Getting an entry per heap could allow to set security rules
> > >> per heap and global ones for all heaps.
> > >>
> > >> Allocation requests will be only allowed if the mask_id
> > >> match with device minor.
> > >> Query request could be done on any of the devices.
> > >>
> > >
> > > With this patch, sysfs looks like:
> > >
> > > $ ls /sys/devices/
> > > breakpoint ion platform software system virtual
> > >
> > > From an Ion perspective, you can have
> > >
> > > Acked-by: Laura Abbott <labbott@redhat.com>
> > >
> > > Another Ack for the device model stuff would be good but I'll
> > > assume deafening silence means nobody hates it.
> > 
> > Greg, can we get your point of view of this ?
> 
> It's 1 day after the merge window has closed, and my todo patch queue
> looks like this:
> 	$ mdfrm -c ~/mail/todo/
> 	1523 messages in /home/gregkh/mail/todo/
> 
> Please give me a chance to catch up...

commit model ftw, we have 400+ patches for 4.16 already merged and tested
and all ready, right when -rc1 gets tagged. Makes the merge window the
most relaxed time of all, because all the other maintainers are drowning
and wont pester you.

Just saying, this is an entirely fixable problem :-P

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-11-27 16:12 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-06 15:59 [PATCH v6 0/2] staging: ion: get one device per heap Benjamin Gaignard
2017-11-06 15:59 ` Benjamin Gaignard
2017-11-06 15:59 ` [PATCH v6 1/2] staging: ion: reorder include Benjamin Gaignard
2017-11-06 15:59   ` Benjamin Gaignard
2017-11-09 21:02   ` Laura Abbott
2017-11-09 21:02     ` Laura Abbott
2017-11-28 13:20   ` Greg KH
2017-11-28 13:20     ` Greg KH
2017-11-28 13:34     ` Benjamin Gaignard
2017-11-28 13:34       ` Benjamin Gaignard
2017-11-28 13:40       ` Greg KH
2017-11-28 13:40         ` Greg KH
2017-11-06 15:59 ` [PATCH v6 2/2] staging: ion: create one device entry per heap Benjamin Gaignard
2017-11-09 21:17   ` Laura Abbott
2017-11-09 21:17     ` Laura Abbott
2017-11-27 10:46     ` Benjamin Gaignard
2017-11-27 10:46       ` Benjamin Gaignard
2017-11-27 11:43       ` Greg Kroah-Hartman
2017-11-27 11:43         ` Greg Kroah-Hartman
2017-11-27 16:12         ` Daniel Vetter [this message]
2017-11-27 16:12           ` Daniel Vetter
2017-11-27 16:30           ` Mark Brown
2017-11-28 13:32   ` Greg KH
2017-11-28 13:32     ` Greg KH
2017-11-28 16:26     ` Mark Brown
2017-11-28 16:26       ` Mark Brown
2017-11-28 17:08       ` Greg KH
2017-11-28 17:08         ` Greg KH
2017-11-28 17:12         ` Mark Brown
2017-11-28 17:12           ` Mark Brown
2017-11-28 17:28           ` Greg KH
2017-11-28 17:28             ` Greg KH
2017-11-28 17:37             ` Mark Brown
2017-11-28 17:37               ` Mark Brown
2017-11-28 18:00               ` Greg KH
2017-11-28 18:00                 ` Greg KH
2017-11-29 14:00     ` Benjamin Gaignard
2017-11-29 14:00       ` Benjamin Gaignard
2017-12-02 15:53       ` Greg KH
2017-12-02 15:53         ` Greg KH
2017-12-05 23:01         ` Laura Abbott
2017-12-05 23:01           ` Laura Abbott
2017-12-06  6:28           ` Greg KH
2017-12-06  6:28             ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2017-10-23 15:55 [PATCH v6 0/2] staging: ion: get one device " Benjamin Gaignard
2017-10-23 15:55 ` [PATCH v6 2/2] staging: ion: create one device entry " Benjamin Gaignard
2017-10-23 15:55   ` Benjamin Gaignard
2017-10-24 16:14   ` Jordan Crouse
2017-10-31 19:03   ` Laura Abbott
2017-10-31 19:03     ` Laura Abbott
2017-10-31 19:11     ` Mark Brown
2017-10-31 19:11       ` Mark Brown
2017-10-31 19:45       ` Laura Abbott
2017-10-31 19:45         ` Laura Abbott
2017-11-02 10:44       ` Greg KH
2017-11-02 11:10         ` Mark Brown
2017-11-02 11:10           ` Mark Brown
2017-11-06 14:42           ` Benjamin Gaignard
2017-11-06 14:42             ` Benjamin Gaignard
2017-11-06 14:46             ` Greg KH
2017-11-06 14:46               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127161222.oig34dt2uc4lzpk2@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=arve@android.com \
    --cc=benjamin.gaignard@linaro.org \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riandrews@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.