All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bind: fix python3 dependencies
@ 2017-11-27 18:29 Dan McGregor
  0 siblings, 0 replies; 8+ messages in thread
From: Dan McGregor @ 2017-11-27 18:29 UTC (permalink / raw)
  To: openembedded-core; +Cc: Dan McGregor

From: Dan McGregor <dan.mcgregor@usask.ca>

Add missing python3 dependency, and use python3 from the build
system.

Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca>
---
 meta/recipes-connectivity/bind/bind_9.10.6.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-connectivity/bind/bind_9.10.6.bb b/meta/recipes-connectivity/bind/bind_9.10.6.bb
index 8b8835ba80..0cf572af26 100644
--- a/meta/recipes-connectivity/bind/bind_9.10.6.bb
+++ b/meta/recipes-connectivity/bind/bind_9.10.6.bb
@@ -5,7 +5,7 @@ SECTION = "console/network"
 LICENSE = "ISC & BSD"
 LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=dba46507446198119bcde32a4feaab43"
 
-DEPENDS = "openssl libcap"
+DEPENDS = "openssl libcap python3"
 
 SRC_URI = "https://ftp.isc.org/isc/bind9/${PV}/${BPN}-${PV}.tar.gz \
            file://conf.patch \
@@ -38,7 +38,7 @@ EXTRA_OECONF = " ${ENABLE_IPV6} --with-libtool --enable-threads \
                  --with-openssl=${STAGING_LIBDIR}/.. \
                "
 
-inherit autotools update-rc.d systemd useradd pkgconfig python3-dir
+inherit autotools update-rc.d systemd useradd pkgconfig python3-dir python3native
 
 export PYTHON_SITEPACKAGES_DIR
 
-- 
2.15.0.106.g7bc77766e



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] bind: fix python3 dependencies
  2017-11-29  6:09         ` Alexander Kanavin
@ 2017-11-29 14:26           ` Dan McGregor
  0 siblings, 0 replies; 8+ messages in thread
From: Dan McGregor @ 2017-11-29 14:26 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer

On 29 November 2017 at 00:09, Alexander Kanavin
<alexander.kanavin@linux.intel.com> wrote:
> On 11/28/2017 06:54 PM, Dan McGregor wrote:
>>>
>>> Can you dig a bit deeper and find out the root cause of the error message
>>> you are getting without this patch please? Try also with a plain poky
>>> checkout, and see if the issue disappears there.
>>
>>
>> Yeah, as I said above python3 distutils seems to be broken when
>> multilib is enabled. I'll fix that and send a patch later today or
>> tomorrow.
>
>
> Just wondering, do you have this fix in your setup?
>
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=3d29214b20433a506a3d59cdc08fc1a9be09a5a0
>

I do. I found that distutils isn't patched in there, it's still hardcoded.

> Alex


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] bind: fix python3 dependencies
  2017-11-28 16:54       ` Dan McGregor
@ 2017-11-29  6:09         ` Alexander Kanavin
  2017-11-29 14:26           ` Dan McGregor
  0 siblings, 1 reply; 8+ messages in thread
From: Alexander Kanavin @ 2017-11-29  6:09 UTC (permalink / raw)
  To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer

On 11/28/2017 06:54 PM, Dan McGregor wrote:
>> Can you dig a bit deeper and find out the root cause of the error message
>> you are getting without this patch please? Try also with a plain poky
>> checkout, and see if the issue disappears there.
> 
> Yeah, as I said above python3 distutils seems to be broken when
> multilib is enabled. I'll fix that and send a patch later today or
> tomorrow.

Just wondering, do you have this fix in your setup?

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=3d29214b20433a506a3d59cdc08fc1a9be09a5a0

Alex


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] bind: fix python3 dependencies
  2017-11-28  6:30     ` Alexander Kanavin
@ 2017-11-28 16:54       ` Dan McGregor
  2017-11-29  6:09         ` Alexander Kanavin
  0 siblings, 1 reply; 8+ messages in thread
From: Dan McGregor @ 2017-11-28 16:54 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer

On 28 November 2017 at 00:30, Alexander Kanavin
<alexander.kanavin@linux.intel.com> wrote:
> On 11/27/2017 10:24 PM, Dan McGregor wrote:
>>>
>>> 2) why is native python3 needed, and host python3 is not enough.
>>
>>
>> Host python3 gives me the error above. Possibly my host's python3 is
>> broken, but it's a Poky build appliance with multilib enabled.
>>
>> I'll make it more explicit in my commit message.
>
>
> Note that bind is built by yocto autobuilder many times a day, in multiple
> configurations (including multilib). And no one else has reported the issue.
> It does seem to me that the patch is working around a problem that is
> somehow specific to your setup, and is not a common issue.
>

Oh I'm sure it's specific to my organisation now. The issue is in
distutils on the host, it doesn't like being installed in /usr/lib64,
so I'll make a patch for that soon. I still don't like relying on host
tools for the python stuff, though.

> Can you dig a bit deeper and find out the root cause of the error message
> you are getting without this patch please? Try also with a plain poky
> checkout, and see if the issue disappears there.

Yeah, as I said above python3 distutils seems to be broken when
multilib is enabled. I'll fix that and send a patch later today or
tomorrow.

>
>
> Alex


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] bind: fix python3 dependencies
  2017-11-27 20:24   ` Dan McGregor
@ 2017-11-28  6:30     ` Alexander Kanavin
  2017-11-28 16:54       ` Dan McGregor
  0 siblings, 1 reply; 8+ messages in thread
From: Alexander Kanavin @ 2017-11-28  6:30 UTC (permalink / raw)
  To: Dan McGregor; +Cc: Patches and discussions about the oe-core layer

On 11/27/2017 10:24 PM, Dan McGregor wrote:
>> 2) why is native python3 needed, and host python3 is not enough.
> 
> Host python3 gives me the error above. Possibly my host's python3 is
> broken, but it's a Poky build appliance with multilib enabled.
> 
> I'll make it more explicit in my commit message.

Note that bind is built by yocto autobuilder many times a day, in 
multiple configurations (including multilib). And no one else has 
reported the issue. It does seem to me that the patch is working around 
a problem that is somehow specific to your setup, and is not a common 
issue.

Can you dig a bit deeper and find out the root cause of the error 
message you are getting without this patch please? Try also with a plain 
poky checkout, and see if the issue disappears there.


Alex


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] bind: fix python3 dependencies
  2017-11-27 19:16 ` Alexander Kanavin
@ 2017-11-27 20:24   ` Dan McGregor
  2017-11-28  6:30     ` Alexander Kanavin
  0 siblings, 1 reply; 8+ messages in thread
From: Dan McGregor @ 2017-11-27 20:24 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer

On 27 November 2017 at 13:16, Alexander Kanavin
<alexander.kanavin@linux.intel.com> wrote:
> On 11/27/2017 08:35 PM, Dan McGregor wrote:
>>
>> Add missing python3 dependency, and use python3 from the build
>> system.
>> -DEPENDS = "openssl libcap"
>> +DEPENDS = "openssl libcap python3"
>> -inherit autotools update-rc.d systemd useradd pkgconfig python3-dir
>> +inherit autotools update-rc.d systemd useradd pkgconfig python3-dir
>> python3native
>
>
> This should have a more specific explanation. Namely:
>
> 1) why is target python3 needed at build time (if not, it should be in
> RDEPENDS of a specific package)

It's already in RDEPENDS as python3-core. It's needed at build time so
that the python component build of bind can find python in the
sysroot. Without this change I get:

| error: invalid Python installation: unable to open
/usr/lib/python3.5/config-3.5m/Makefile (No such file or directory)

With only inherit python3native I get:

| error: invalid Python installation: unable to open <recipe
sysroot>/usr/lib64/python3.5/config-3.5m/Makefile (No such file or
directory)

>
> 2) why is native python3 needed, and host python3 is not enough.

Host python3 gives me the error above. Possibly my host's python3 is
broken, but it's a Poky build appliance with multilib enabled.

I'll make it more explicit in my commit message.

Thanks.

>
>
> Alex


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] bind: fix python3 dependencies
  2017-11-27 18:35 Dan McGregor
@ 2017-11-27 19:16 ` Alexander Kanavin
  2017-11-27 20:24   ` Dan McGregor
  0 siblings, 1 reply; 8+ messages in thread
From: Alexander Kanavin @ 2017-11-27 19:16 UTC (permalink / raw)
  To: Dan McGregor, openembedded-core; +Cc: Dan McGregor

On 11/27/2017 08:35 PM, Dan McGregor wrote:
> Add missing python3 dependency, and use python3 from the build
> system.
> -DEPENDS = "openssl libcap"
> +DEPENDS = "openssl libcap python3"
> -inherit autotools update-rc.d systemd useradd pkgconfig python3-dir
> +inherit autotools update-rc.d systemd useradd pkgconfig python3-dir python3native

This should have a more specific explanation. Namely:

1) why is target python3 needed at build time (if not, it should be in 
RDEPENDS of a specific package)

2) why is native python3 needed, and host python3 is not enough.


Alex


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] bind: fix python3 dependencies
@ 2017-11-27 18:35 Dan McGregor
  2017-11-27 19:16 ` Alexander Kanavin
  0 siblings, 1 reply; 8+ messages in thread
From: Dan McGregor @ 2017-11-27 18:35 UTC (permalink / raw)
  To: openembedded-core; +Cc: Dan McGregor

From: Dan McGregor <dan.mcgregor@usask.ca>

Add missing python3 dependency, and use python3 from the build
system.

Signed-off-by: Dan McGregor <dan.mcgregor@usask.ca>
---
 meta/recipes-connectivity/bind/bind_9.10.6.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-connectivity/bind/bind_9.10.6.bb b/meta/recipes-connectivity/bind/bind_9.10.6.bb
index 8b8835ba80..0cf572af26 100644
--- a/meta/recipes-connectivity/bind/bind_9.10.6.bb
+++ b/meta/recipes-connectivity/bind/bind_9.10.6.bb
@@ -5,7 +5,7 @@ SECTION = "console/network"
 LICENSE = "ISC & BSD"
 LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=dba46507446198119bcde32a4feaab43"
 
-DEPENDS = "openssl libcap"
+DEPENDS = "openssl libcap python3"
 
 SRC_URI = "https://ftp.isc.org/isc/bind9/${PV}/${BPN}-${PV}.tar.gz \
            file://conf.patch \
@@ -38,7 +38,7 @@ EXTRA_OECONF = " ${ENABLE_IPV6} --with-libtool --enable-threads \
                  --with-openssl=${STAGING_LIBDIR}/.. \
                "
 
-inherit autotools update-rc.d systemd useradd pkgconfig python3-dir
+inherit autotools update-rc.d systemd useradd pkgconfig python3-dir python3native
 
 export PYTHON_SITEPACKAGES_DIR
 
-- 
2.15.0.106.g7bc77766e



^ permalink raw reply related	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-11-29 14:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-27 18:29 [PATCH] bind: fix python3 dependencies Dan McGregor
2017-11-27 18:35 Dan McGregor
2017-11-27 19:16 ` Alexander Kanavin
2017-11-27 20:24   ` Dan McGregor
2017-11-28  6:30     ` Alexander Kanavin
2017-11-28 16:54       ` Dan McGregor
2017-11-29  6:09         ` Alexander Kanavin
2017-11-29 14:26           ` Dan McGregor

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.