All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: lowmem check: Reword an unclear error message about file extent gap
@ 2017-11-10  9:47 Lu Fengqi
  2017-11-27 18:55 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Lu Fengqi @ 2017-11-10  9:47 UTC (permalink / raw)
  To: linux-btrfs

This error occurs when no_holes is not set, but there is a gap
before the file extent.

Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---

Really ashamed, I made the mistake about the meaning of this word.

 cmds-check.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/cmds-check.c b/cmds-check.c
index a93ac2c8..5eab0143 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -5868,8 +5868,9 @@ static int check_file_extent(struct btrfs_root *root, struct btrfs_key *fkey,
 		if (!repair || ret) {
 			err |= FILE_EXTENT_ERROR;
 			error(
-		"root %llu EXTENT_DATA[%llu %llu] interrupt, should start at %llu",
-			root->objectid, fkey->objectid, fkey->offset, *end);
+"root %llu EXTENT_DATA[%llu %llu] gap exists, expected: EXTENT_DATA[%llu %llu]",
+			root->objectid, fkey->objectid, fkey->offset,
+			fkey->objectid, *end);
 		}
 	}
 
-- 
2.15.0




^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs-progs: lowmem check: Reword an unclear error message about file extent gap
  2017-11-10  9:47 [PATCH] btrfs-progs: lowmem check: Reword an unclear error message about file extent gap Lu Fengqi
@ 2017-11-27 18:55 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-11-27 18:55 UTC (permalink / raw)
  To: Lu Fengqi; +Cc: linux-btrfs

On Fri, Nov 10, 2017 at 05:47:10PM +0800, Lu Fengqi wrote:
> This error occurs when no_holes is not set, but there is a gap
> before the file extent.
> 
> Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-27 18:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-10  9:47 [PATCH] btrfs-progs: lowmem check: Reword an unclear error message about file extent gap Lu Fengqi
2017-11-27 18:55 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.