* [Buildroot] [PATCH] google-breakpad: take into account host architecture dependencies
@ 2017-11-26 14:40 Thomas Petazzoni
2017-11-27 20:33 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Petazzoni @ 2017-11-26 14:40 UTC (permalink / raw)
To: buildroot
Building the target google-breakpad requires building the host variant
of google-breakpad. Just like the target google-breakpad only supports
a limited number of architectures, it is the same for the host
google-breakpad.
We therefore introduce a
BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS option that is used
where necessary to prevent the user from choosing Google Breakpad when
building on unsupported host platforms.
Fixes:
http://autobuild.buildroot.net/results/c7c04483508f9e4d629efa54571afeb1feaa5f73/
(build on a powerpc64le machine)
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
Config.in | 1 +
package/Config.in.host | 1 +
package/google-breakpad/Config.in | 2 ++
package/google-breakpad/Config.in.host | 8 ++++++++
4 files changed, 12 insertions(+)
create mode 100644 package/google-breakpad/Config.in.host
diff --git a/Config.in b/Config.in
index 75e5604831..62d67ce957 100644
--- a/Config.in
+++ b/Config.in
@@ -539,6 +539,7 @@ config BR2_GOOGLE_BREAKPAD_ENABLE
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
help
This option will enable the use of google breakpad, a library
and tool suite that allows you to distribute an application to
diff --git a/package/Config.in.host b/package/Config.in.host
index 59be666143..48b6f8c7a8 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -20,6 +20,7 @@ menu "Host utilities"
source "package/genpart/Config.in.host"
source "package/go/Config.in.host"
source "package/go-bootstrap/Config.in.host"
+ source "package/google-breakpad/Config.in.host"
source "package/gptfdisk/Config.in.host"
source "package/imx-usb-loader/Config.in.host"
source "package/jq/Config.in.host"
diff --git a/package/google-breakpad/Config.in b/package/google-breakpad/Config.in
index e0e91068be..91ec9ce309 100644
--- a/package/google-breakpad/Config.in
+++ b/package/google-breakpad/Config.in
@@ -12,6 +12,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
select BR2_PACKAGE_LINUX_SYSCALL_SUPPORT
help
Google-Breakpad is a library and tool suite that allows you
@@ -36,6 +37,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, thread, C++, gcc >= 4.8"
depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ depends on BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
!BR2_TOOLCHAIN_HAS_THREADS || \
!(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC) || \
diff --git a/package/google-breakpad/Config.in.host b/package/google-breakpad/Config.in.host
new file mode 100644
index 0000000000..28d304766a
--- /dev/null
+++ b/package/google-breakpad/Config.in.host
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS
+ bool
+ default y if BR2_HOSTARCH = "x86_64"
+ default y if BR2_HOSTARCH = "x86"
+ default y if BR2_HOSTARCH = "arm"
+ default y if BR2_HOSTARCH = "aarch64"
+ default y if BR2_HOSTARCH = "mips"
+ default y if BR2_HOSTARCH = "mipsel"
--
2.13.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] google-breakpad: take into account host architecture dependencies
2017-11-26 14:40 [Buildroot] [PATCH] google-breakpad: take into account host architecture dependencies Thomas Petazzoni
@ 2017-11-27 20:33 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2017-11-27 20:33 UTC (permalink / raw)
To: buildroot
Hello,
On Sun, 26 Nov 2017 15:40:19 +0100, Thomas Petazzoni wrote:
> Building the target google-breakpad requires building the host variant
> of google-breakpad. Just like the target google-breakpad only supports
> a limited number of architectures, it is the same for the host
> google-breakpad.
>
> We therefore introduce a
> BR2_PACKAGE_HOST_GOOGLE_BREAKPAD_ARCH_SUPPORTS option that is used
> where necessary to prevent the user from choosing Google Breakpad when
> building on unsupported host platforms.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/c7c04483508f9e4d629efa54571afeb1feaa5f73/
> (build on a powerpc64le machine)
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> Config.in | 1 +
> package/Config.in.host | 1 +
> package/google-breakpad/Config.in | 2 ++
> package/google-breakpad/Config.in.host | 8 ++++++++
> 4 files changed, 12 insertions(+)
> create mode 100644 package/google-breakpad/Config.in.host
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-27 20:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-26 14:40 [Buildroot] [PATCH] google-breakpad: take into account host architecture dependencies Thomas Petazzoni
2017-11-27 20:33 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.