* [PATCH net] bonding: use nla_get_u64 to extract the value for IFLA_BOND_AD_ACTOR_SYSTEM
@ 2017-11-26 13:12 Xin Long
2017-11-28 20:56 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Xin Long @ 2017-11-26 13:12 UTC (permalink / raw)
To: network dev; +Cc: davem, Andy Gospodarek
bond_opt_initval expects a u64 type param, it's better to use
nla_get_u64 to extract the value here, to eliminate a sparse
endianness mismatch warning.
Fixes: 171a42c38c6e ("bonding: add netlink support for sys prio, actor sys mac, and port key")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
drivers/net/bonding/bond_netlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c
index a1b33aa..9697977 100644
--- a/drivers/net/bonding/bond_netlink.c
+++ b/drivers/net/bonding/bond_netlink.c
@@ -423,7 +423,7 @@ static int bond_changelink(struct net_device *bond_dev, struct nlattr *tb[],
return -EINVAL;
bond_opt_initval(&newval,
- nla_get_be64(data[IFLA_BOND_AD_ACTOR_SYSTEM]));
+ nla_get_u64(data[IFLA_BOND_AD_ACTOR_SYSTEM]));
err = __bond_opt_set(bond, BOND_OPT_AD_ACTOR_SYSTEM, &newval);
if (err)
return err;
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] bonding: use nla_get_u64 to extract the value for IFLA_BOND_AD_ACTOR_SYSTEM
2017-11-26 13:12 [PATCH net] bonding: use nla_get_u64 to extract the value for IFLA_BOND_AD_ACTOR_SYSTEM Xin Long
@ 2017-11-28 20:56 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-11-28 20:56 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, gospo
From: Xin Long <lucien.xin@gmail.com>
Date: Sun, 26 Nov 2017 21:12:09 +0800
> bond_opt_initval expects a u64 type param, it's better to use
> nla_get_u64 to extract the value here, to eliminate a sparse
> endianness mismatch warning.
>
> Fixes: 171a42c38c6e ("bonding: add netlink support for sys prio, actor sys mac, and port key")
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-28 20:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-26 13:12 [PATCH net] bonding: use nla_get_u64 to extract the value for IFLA_BOND_AD_ACTOR_SYSTEM Xin Long
2017-11-28 20:56 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.