From: Viresh Kumar <viresh.kumar@linaro.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: sboyd@codeaurora.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, ysato@users.sourceforge.jp,
vz@mleia.com, slemieux.tyco@gmail.com, vireshk@kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines
Date: Tue, 28 Nov 2017 08:12:25 +0530 [thread overview]
Message-ID: <20171128024225.GC11413@vireshk-i7> (raw)
In-Reply-To: <03a5ce213323863375e1fb3f85c0c3cc8c921a41.1511505932.git.arvind.yadav.cs@gmail.com>
On 24-11-17, 12:25, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/clk/spear/clk-frac-synth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/clk-frac-synth.c b/drivers/clk/spear/clk-frac-synth.c
> index 58d678b..cbdf43a 100644
> --- a/drivers/clk/spear/clk-frac-synth.c
> +++ b/drivers/clk/spear/clk-frac-synth.c
> @@ -131,7 +131,7 @@ struct clk *clk_register_frac(const char *name, const char *parent_name,
> struct clk *clk;
>
> if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
> - pr_err("Invalid arguments passed");
> + pr_err("Invalid arguments passed\n");
> return ERR_PTR(-EINVAL);
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] clk: SPEAr: pr_err() strings should end with newlines
Date: Tue, 28 Nov 2017 08:12:25 +0530 [thread overview]
Message-ID: <20171128024225.GC11413@vireshk-i7> (raw)
In-Reply-To: <03a5ce213323863375e1fb3f85c0c3cc8c921a41.1511505932.git.arvind.yadav.cs@gmail.com>
On 24-11-17, 12:25, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/clk/spear/clk-frac-synth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/spear/clk-frac-synth.c b/drivers/clk/spear/clk-frac-synth.c
> index 58d678b..cbdf43a 100644
> --- a/drivers/clk/spear/clk-frac-synth.c
> +++ b/drivers/clk/spear/clk-frac-synth.c
> @@ -131,7 +131,7 @@ struct clk *clk_register_frac(const char *name, const char *parent_name,
> struct clk *clk;
>
> if (!name || !parent_name || !reg || !rtbl || !rtbl_cnt) {
> - pr_err("Invalid arguments passed");
> + pr_err("Invalid arguments passed\n");
> return ERR_PTR(-EINVAL);
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2017-11-28 2:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 6:55 [PATCH 0/6] clk: pr_err() strings should end with newlines Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-11-24 6:55 ` [PATCH 1/6] clk: stm32f4: " Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-12-07 6:40 ` Stephen Boyd
2017-12-07 6:40 ` Stephen Boyd
2017-11-24 6:55 ` [PATCH 2/6] clk: lpc32xx: " Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-11-25 8:59 ` Vladimir Zapolskiy
2017-11-25 8:59 ` Vladimir Zapolskiy
2017-12-07 6:41 ` Stephen Boyd
2017-12-07 6:41 ` Stephen Boyd
2017-11-24 6:55 ` [PATCH 3/6] clk: SPEAr: " Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-11-28 2:42 ` Viresh Kumar [this message]
2017-11-28 2:42 ` Viresh Kumar
2017-12-07 6:41 ` Stephen Boyd
2017-12-07 6:41 ` Stephen Boyd
2017-11-24 6:55 ` [PATCH 4/6] SPEAr: clk: " Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-11-28 2:42 ` Viresh Kumar
2017-11-28 2:42 ` Viresh Kumar
2017-12-07 6:41 ` Stephen Boyd
2017-12-07 6:41 ` Stephen Boyd
2017-11-24 6:55 ` [PATCH 5/6] clk: h8s2678: " Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-12-07 6:41 ` Stephen Boyd
2017-12-07 6:41 ` Stephen Boyd
2017-11-24 6:55 ` [PATCH 6/6] clk: h8300: " Arvind Yadav
2017-11-24 6:55 ` Arvind Yadav
2017-12-07 6:41 ` Stephen Boyd
2017-12-07 6:41 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128024225.GC11413@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=alexandre.torgue@st.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=slemieux.tyco@gmail.com \
--cc=vireshk@kernel.org \
--cc=vz@mleia.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.