* [PATCH v3] bcma:Adjust block comments
@ 2017-11-28 15:54 Ashish Kalra
2017-11-28 16:05 ` Himanshu Jha
2017-12-07 13:35 ` [v3] bcma: Adjust block comment Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Ashish Kalra @ 2017-11-28 15:54 UTC (permalink / raw)
To: zajec5; +Cc: himanshujha199640, linux-wireless, linux-kernel, eashishkalra
use * for block comments in multiple lines according to kernel coding
style
Reported by: checkpatch.pl
Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
---
Change log:
-v3: Improvement on commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com>
-v2: Improvement on commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com>(https://lkml.org/lkml/2017/11/27/1259)
-v1: https://lkml.org/lkml/2017/11/26/85
drivers/bcma/driver_pcie2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/bcma/driver_pcie2.c b/drivers/bcma/driver_pcie2.c
index b1a6e327cb23..cf889fc62ac7 100644
--- a/drivers/bcma/driver_pcie2.c
+++ b/drivers/bcma/driver_pcie2.c
@@ -83,7 +83,8 @@ static void bcma_core_pcie2_hw_ltr_war(struct bcma_drv_pcie2 *pcie2)
bcma_core_pcie2_set_ltr_vals(pcie2);
/* TODO:
- si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0); */
+ *si_core_wrapperreg(pcie2, 3, 0x60, 0x8080, 0);
+ */
/* enable the LTR */
devstsctr2 |= PCIE2_CAP_DEVSTSCTRL2_LTRENAB;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] bcma:Adjust block comments
2017-11-28 15:54 [PATCH v3] bcma:Adjust block comments Ashish Kalra
@ 2017-11-28 16:05 ` Himanshu Jha
2017-12-07 13:35 ` [v3] bcma: Adjust block comment Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Himanshu Jha @ 2017-11-28 16:05 UTC (permalink / raw)
To: Ashish Kalra; +Cc: zajec5, linux-wireless, linux-kernel
Hi Ashish,
On Tue, Nov 28, 2017 at 09:24:58PM +0530, Ashish Kalra wrote:
> use * for block comments in multiple lines according to kernel coding
> style
>
> Reported by: checkpatch.pl
>
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> ---
Looks good now!
FWIW,
Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com>
> Change log:
> -v3: Improvement on commit message as per review from Morgan Freeman <morganfreeman6991@gmail.com>
BTW, this <morganfreeman6991@gmail.com> is my secondary email subscibed
to linux-wirless as I don't want my primary email to be flooded with
frequent emails, and my upstream mail is himanshujha199640@gmail.com !
Thanks
Himanshu Jha
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v3] bcma: Adjust block comment
2017-11-28 15:54 [PATCH v3] bcma:Adjust block comments Ashish Kalra
2017-11-28 16:05 ` Himanshu Jha
@ 2017-12-07 13:35 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2017-12-07 13:35 UTC (permalink / raw)
To: Ashish Kalra
Cc: zajec5, himanshujha199640, linux-wireless, linux-kernel, eashishkalra
Ashish Kalra <eashishkalra@gmail.com> wrote:
> use * for block comments in multiple lines according to kernel coding
> style
>
> Reported by: checkpatch.pl
>
> Signed-off-by: Ashish Kalra <eashishkalra@gmail.com>
> Reviewed-by: Himanshu Jha <himanshujha199640@gmail.com>
Patch applied to wireless-drivers-next.git, thanks.
a765c8fdc869 bcma: Adjust block comment
--
https://patchwork.kernel.org/patch/10080747/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-07 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-28 15:54 [PATCH v3] bcma:Adjust block comments Ashish Kalra
2017-11-28 16:05 ` Himanshu Jha
2017-12-07 13:35 ` [v3] bcma: Adjust block comment Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.