From: Eduardo Habkost <ehabkost@redhat.com> To: "Marc-André Lureau" <marcandre.lureau@gmail.com> Cc: QEMU <qemu-devel@nongnu.org>, jgross@suse.com, Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, Alexander Graf <agraf@suse.de>, Anthony Perard <anthony.perard@citrix.com>, "open list:ARM" <qemu-arm@nongnu.org>, "open list:sPAPR pseries" <qemu-ppc@nongnu.org>, Marcel Apfelbaum <marcel@redhat.com>, xen-devel@lists.xenproject.org, Laszlo Ersek <lersek@redhat.com>, David Gibson <david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH v2 1/6] machine: Replace has_dynamic_sysbus with list of allowed devices Date: Tue, 28 Nov 2017 16:34:08 -0200 [thread overview] Message-ID: <20171128183408.GP3037@localhost.localdomain> (raw) In-Reply-To: <CAJ+F1CJRkXNnU+NK93vvSg806=vUBwxx9KGLGoJ_XBQFi+-Nfw@mail.gmail.com> On Tue, Nov 28, 2017 at 05:55:15PM +0100, Marc-André Lureau wrote: [...] > Hi > > On Sat, Nov 25, 2017 at 4:16 PM, Eduardo Habkost <ehabkost@redhat.com> wrote: > > The existing has_dynamic_sysbus flag makes the machine accept > > every user-creatable sysbus device type on the command-line. > > Replace it with a list of allowed device types, so machines can > > easily accept some sysbus devices while rejecting others. > > > > To keep exactly the same behavior as before, the existing > > has_dynamic_sysbus=true assignments are replaced with a > > TYPE_SYS_BUS_DEVICE entry on the allowed list. Other patches > > will replace the TYPE_SYS_BUS_DEVICE entries with more specific > > lists of devices. > > > > Cc: Peter Maydell <peter.maydell@linaro.org> > > Cc: Marcel Apfelbaum <marcel@redhat.com> > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > > Cc: Alexander Graf <agraf@suse.de> > > Cc: David Gibson <david@gibson.dropbear.id.au> > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > Cc: Anthony Perard <anthony.perard@citrix.com> > > Cc: qemu-arm@nongnu.org > > Cc: qemu-ppc@nongnu.org > > Cc: xen-devel@lists.xenproject.org > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Thanks! [...] > > - mc->has_dynamic_sysbus = true; > > + /*TODO: allow only sysbus devices that really work with this machine */ > > cosmetic: why do you not leave a space between * and TODO ? (you did > that repeatedly) Good question. :) For reasons I can't explain, I thought "/*TODO:" was more common than "/* TODO:", but I was mistaken. I will change this to "/* TODO:" when committing the patches. -- Eduardo
WARNING: multiple messages have this Message-ID (diff)
From: Eduardo Habkost <ehabkost@redhat.com> To: "Marc-André Lureau" <marcandre.lureau@gmail.com> Cc: jgross@suse.com, Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>, Stefano Stabellini <sstabellini@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, QEMU <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Marcel Apfelbaum <marcel@redhat.com>, "open list:ARM" <qemu-arm@nongnu.org>, "open list:sPAPR pseries" <qemu-ppc@nongnu.org>, Anthony Perard <anthony.perard@citrix.com>, xen-devel@lists.xenproject.org, Laszlo Ersek <lersek@redhat.com>, David Gibson <david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH v2 1/6] machine: Replace has_dynamic_sysbus with list of allowed devices Date: Tue, 28 Nov 2017 16:34:08 -0200 [thread overview] Message-ID: <20171128183408.GP3037@localhost.localdomain> (raw) In-Reply-To: <CAJ+F1CJRkXNnU+NK93vvSg806=vUBwxx9KGLGoJ_XBQFi+-Nfw@mail.gmail.com> On Tue, Nov 28, 2017 at 05:55:15PM +0100, Marc-André Lureau wrote: [...] > Hi > > On Sat, Nov 25, 2017 at 4:16 PM, Eduardo Habkost <ehabkost@redhat.com> wrote: > > The existing has_dynamic_sysbus flag makes the machine accept > > every user-creatable sysbus device type on the command-line. > > Replace it with a list of allowed device types, so machines can > > easily accept some sysbus devices while rejecting others. > > > > To keep exactly the same behavior as before, the existing > > has_dynamic_sysbus=true assignments are replaced with a > > TYPE_SYS_BUS_DEVICE entry on the allowed list. Other patches > > will replace the TYPE_SYS_BUS_DEVICE entries with more specific > > lists of devices. > > > > Cc: Peter Maydell <peter.maydell@linaro.org> > > Cc: Marcel Apfelbaum <marcel@redhat.com> > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > > Cc: Alexander Graf <agraf@suse.de> > > Cc: David Gibson <david@gibson.dropbear.id.au> > > Cc: Stefano Stabellini <sstabellini@kernel.org> > > Cc: Anthony Perard <anthony.perard@citrix.com> > > Cc: qemu-arm@nongnu.org > > Cc: qemu-ppc@nongnu.org > > Cc: xen-devel@lists.xenproject.org > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > > Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Thanks! [...] > > - mc->has_dynamic_sysbus = true; > > + /*TODO: allow only sysbus devices that really work with this machine */ > > cosmetic: why do you not leave a space between * and TODO ? (you did > that repeatedly) Good question. :) For reasons I can't explain, I thought "/*TODO:" was more common than "/* TODO:", but I was mistaken. I will change this to "/* TODO:" when committing the patches. -- Eduardo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2017-11-28 18:34 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-25 15:16 [Qemu-devel] [PATCH v2 0/6] Replace has_dynamic_sysbus with list of allowed device types Eduardo Habkost 2017-11-25 15:16 ` [Qemu-devel] [PATCH v2 1/6] machine: Replace has_dynamic_sysbus with list of allowed devices Eduardo Habkost 2017-11-25 15:16 ` Eduardo Habkost 2017-11-25 17:08 ` [Qemu-devel] " Greg Kurz 2017-11-25 17:08 ` Greg Kurz 2017-11-27 1:51 ` David Gibson 2017-11-27 1:51 ` David Gibson 2017-11-27 8:39 ` [Qemu-devel] " Marcel Apfelbaum 2017-11-27 8:39 ` Marcel Apfelbaum 2017-11-28 16:55 ` [Qemu-devel] " Marc-André Lureau 2017-11-28 16:55 ` Marc-André Lureau 2017-11-28 18:34 ` Eduardo Habkost [this message] 2017-11-28 18:34 ` Eduardo Habkost 2017-11-25 15:16 ` [Qemu-devel] [PATCH v2 2/6] hw/arm/virt: Allow only supported dynamic sysbus devices Eduardo Habkost 2017-11-25 15:16 ` [Qemu-devel] [PATCH v2 3/6] ppc: e500: " Eduardo Habkost 2017-11-25 18:31 ` Greg Kurz 2017-11-28 1:11 ` Eduardo Habkost 2017-11-27 1:52 ` David Gibson 2017-11-28 1:12 ` Eduardo Habkost 2017-11-28 4:54 ` David Gibson 2017-11-25 15:16 ` [Qemu-devel] [PATCH v2 4/6] spapr: " Eduardo Habkost 2017-11-25 17:43 ` Greg Kurz 2017-11-27 1:52 ` David Gibson 2017-11-25 15:16 ` [Qemu-devel] [PATCH v2 5/6] xen: Add only xen-sysdev to dynamic sysbus device list Eduardo Habkost 2017-11-25 15:16 ` Eduardo Habkost 2017-12-22 13:36 ` [Qemu-devel] " Marc-André Lureau 2017-12-22 13:36 ` Marc-André Lureau 2018-01-05 14:12 ` Anthony PERARD 2018-01-05 14:12 ` Anthony PERARD 2017-11-25 15:16 ` [Qemu-devel] [PATCH v2 6/6] q35: Allow only supported dynamic sysbus devices Eduardo Habkost 2017-11-27 8:44 ` Marcel Apfelbaum 2017-11-28 1:18 ` Eduardo Habkost 2017-12-22 13:37 ` [Qemu-devel] [PATCH v2 0/6] Replace has_dynamic_sysbus with list of allowed device types Marc-André Lureau 2018-01-09 20:12 ` Eduardo Habkost
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171128183408.GP3037@localhost.localdomain \ --to=ehabkost@redhat.com \ --cc=agraf@suse.de \ --cc=anthony.perard@citrix.com \ --cc=david@gibson.dropbear.id.au \ --cc=jgross@suse.com \ --cc=lersek@redhat.com \ --cc=marcandre.lureau@gmail.com \ --cc=marcel@redhat.com \ --cc=mst@redhat.com \ --cc=peter.maydell@linaro.org \ --cc=qemu-arm@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ --cc=sstabellini@kernel.org \ --cc=thuth@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.