All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] strbuf: Remove unused stripspace function alias
@ 2017-11-29  1:45 Elijah Newren
  2017-11-29  8:47 ` Tobias Klauser
  0 siblings, 1 reply; 2+ messages in thread
From: Elijah Newren @ 2017-11-29  1:45 UTC (permalink / raw)
  To: git; +Cc: Tobias Klauser, Elijah Newren

In commit 63af4a8446 ("strbuf: make stripspace() part of strbuf",
2015-10-16), stripspace() was moved to strbuf and renamed to
strbuf_stripspace().  A "temporary" alias was added for the old name until
all topic branches had time to switch over.  They have had time, so remove
the old alias.

Signed-off-by: Elijah Newren <newren@gmail.com>
---
 strbuf.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/strbuf.h b/strbuf.h
index 0a74acb236..14c8c10d66 100644
--- a/strbuf.h
+++ b/strbuf.h
@@ -480,15 +480,6 @@ extern int strbuf_normalize_path(struct strbuf *sb);
  */
 extern void strbuf_stripspace(struct strbuf *buf, int skip_comments);
 
-/**
- * Temporary alias until all topic branches have switched to use
- * strbuf_stripspace directly.
- */
-static inline void stripspace(struct strbuf *buf, int skip_comments)
-{
-	strbuf_stripspace(buf, skip_comments);
-}
-
 static inline int strbuf_strip_suffix(struct strbuf *sb, const char *suffix)
 {
 	if (strip_suffix_mem(sb->buf, &sb->len, suffix)) {
-- 
2.15.0.408.g850bc54b15


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] strbuf: Remove unused stripspace function alias
  2017-11-29  1:45 [PATCH] strbuf: Remove unused stripspace function alias Elijah Newren
@ 2017-11-29  8:47 ` Tobias Klauser
  0 siblings, 0 replies; 2+ messages in thread
From: Tobias Klauser @ 2017-11-29  8:47 UTC (permalink / raw)
  To: Elijah Newren; +Cc: git

On 2017-11-29 at 02:45:59 +0100, Elijah Newren <newren@gmail.com> wrote:
> In commit 63af4a8446 ("strbuf: make stripspace() part of strbuf",
> 2015-10-16), stripspace() was moved to strbuf and renamed to
> strbuf_stripspace().  A "temporary" alias was added for the old name until
> all topic branches had time to switch over.  They have had time, so remove
> the old alias.
> 
> Signed-off-by: Elijah Newren <newren@gmail.com>

Reviewed-by: Tobias Klauser <tklauser@distanz.ch>

Thanks!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-29  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29  1:45 [PATCH] strbuf: Remove unused stripspace function alias Elijah Newren
2017-11-29  8:47 ` Tobias Klauser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.