* [PATCH] Fix NULL pointer deref. on no default_rng
@ 2017-11-12 14:24 Pierre Ducroquet
2017-11-12 14:46 ` PrasannaKumar Muralidharan
2017-11-29 6:34 ` Herbert Xu
0 siblings, 2 replies; 6+ messages in thread
From: Pierre Ducroquet @ 2017-11-12 14:24 UTC (permalink / raw)
To: linux-crypto; +Cc: davem, herbert, Pierre Ducroquet
If crypto_get_default_rng returns an error, the
function ecc_gen_privkey should return an error.
Instead, it currently tries to use the default_rng
nevertheless, thus creating a kernel panic with a
NULL pointer dereference.
Returning the error directly, as was supposedly
intended when looking at the code, fixes this.
Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
---
crypto/ecc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/ecc.c b/crypto/ecc.c
index 633a9bcdc574..18f32f2a5e1c 100644
--- a/crypto/ecc.c
+++ b/crypto/ecc.c
@@ -964,7 +964,7 @@ int ecc_gen_privkey(unsigned int curve_id, unsigned int ndigits, u64 *privkey)
* DRBG with a security strength of 256.
*/
if (crypto_get_default_rng())
- err = -EFAULT;
+ return -EFAULT;
err = crypto_rng_get_bytes(crypto_default_rng, (u8 *)priv, nbytes);
crypto_put_default_rng();
--
2.15.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix NULL pointer deref. on no default_rng
2017-11-12 14:24 [PATCH] Fix NULL pointer deref. on no default_rng Pierre Ducroquet
@ 2017-11-12 14:46 ` PrasannaKumar Muralidharan
2017-11-18 17:18 ` Pierre
2017-11-29 6:34 ` Herbert Xu
1 sibling, 1 reply; 6+ messages in thread
From: PrasannaKumar Muralidharan @ 2017-11-12 14:46 UTC (permalink / raw)
To: Pierre Ducroquet
Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
David S . Miller, Herbert Xu
Hi Pierre,
On 12 November 2017 at 19:54, Pierre Ducroquet <pinaraf@pinaraf.info> wrote:
> If crypto_get_default_rng returns an error, the
> function ecc_gen_privkey should return an error.
> Instead, it currently tries to use the default_rng
> nevertheless, thus creating a kernel panic with a
> NULL pointer dereference.
> Returning the error directly, as was supposedly
> intended when looking at the code, fixes this.
>
> Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
> ---
> crypto/ecc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/ecc.c b/crypto/ecc.c
> index 633a9bcdc574..18f32f2a5e1c 100644
> --- a/crypto/ecc.c
> +++ b/crypto/ecc.c
> @@ -964,7 +964,7 @@ int ecc_gen_privkey(unsigned int curve_id, unsigned int ndigits, u64 *privkey)
> * DRBG with a security strength of 256.
> */
> if (crypto_get_default_rng())
> - err = -EFAULT;
> + return -EFAULT;
>
> err = crypto_rng_get_bytes(crypto_default_rng, (u8 *)priv, nbytes);
> crypto_put_default_rng();
> --
> 2.15.0
>
Looks good to me.
Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Regards,
PrasannaKumar
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix NULL pointer deref. on no default_rng
2017-11-12 14:46 ` PrasannaKumar Muralidharan
@ 2017-11-18 17:18 ` Pierre
0 siblings, 0 replies; 6+ messages in thread
From: Pierre @ 2017-11-18 17:18 UTC (permalink / raw)
To: PrasannaKumar Muralidharan
Cc: open list:HARDWARE RANDOM NUMBER GENERATOR CORE,
David S . Miller, Herbert Xu
[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]
On Sunday, November 12, 2017 8:16:27 PM CET PrasannaKumar Muralidharan wrote:
> Hi Pierre,
>
> On 12 November 2017 at 19:54, Pierre Ducroquet <pinaraf@pinaraf.info> wrote:
> > If crypto_get_default_rng returns an error, the
> > function ecc_gen_privkey should return an error.
> > Instead, it currently tries to use the default_rng
> > nevertheless, thus creating a kernel panic with a
> > NULL pointer dereference.
> > Returning the error directly, as was supposedly
> > intended when looking at the code, fixes this.
> >
> > Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
> > ---
> >
> > crypto/ecc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/crypto/ecc.c b/crypto/ecc.c
> > index 633a9bcdc574..18f32f2a5e1c 100644
> > --- a/crypto/ecc.c
> > +++ b/crypto/ecc.c
> > @@ -964,7 +964,7 @@ int ecc_gen_privkey(unsigned int curve_id, unsigned
> > int ndigits, u64 *privkey)>
> > * DRBG with a security strength of 256.
> > */
> >
> > if (crypto_get_default_rng())
> >
> > - err = -EFAULT;
> > + return -EFAULT;
> >
> > err = crypto_rng_get_bytes(crypto_default_rng, (u8 *)priv,
> > nbytes);
> > crypto_put_default_rng();
> >
> > --
> > 2.15.0
>
> Looks good to me.
>
> Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>
> Regards,
> PrasannaKumar
Hi
Thanks for your review.
Is there anything I should do to have this merged ? It fixes a kernel panic at
boot on my computer, so I suppose other people may have that too.
Regards
Pierre
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix NULL pointer deref. on no default_rng
2017-11-12 14:24 [PATCH] Fix NULL pointer deref. on no default_rng Pierre Ducroquet
2017-11-12 14:46 ` PrasannaKumar Muralidharan
@ 2017-11-29 6:34 ` Herbert Xu
2017-12-07 10:32 ` Pierre
2017-12-20 19:49 ` Pierre
1 sibling, 2 replies; 6+ messages in thread
From: Herbert Xu @ 2017-11-29 6:34 UTC (permalink / raw)
To: Pierre Ducroquet; +Cc: linux-crypto, davem
On Sun, Nov 12, 2017 at 03:24:32PM +0100, Pierre Ducroquet wrote:
> If crypto_get_default_rng returns an error, the
> function ecc_gen_privkey should return an error.
> Instead, it currently tries to use the default_rng
> nevertheless, thus creating a kernel panic with a
> NULL pointer dereference.
> Returning the error directly, as was supposedly
> intended when looking at the code, fixes this.
>
> Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix NULL pointer deref. on no default_rng
2017-11-29 6:34 ` Herbert Xu
@ 2017-12-07 10:32 ` Pierre
2017-12-20 19:49 ` Pierre
1 sibling, 0 replies; 6+ messages in thread
From: Pierre @ 2017-12-07 10:32 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto, davem
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Wednesday, November 29, 2017 5:34:30 PM CET you wrote:
> On Sun, Nov 12, 2017 at 03:24:32PM +0100, Pierre Ducroquet wrote:
> > If crypto_get_default_rng returns an error, the
> > function ecc_gen_privkey should return an error.
> > Instead, it currently tries to use the default_rng
> > nevertheless, thus creating a kernel panic with a
> > NULL pointer dereference.
> > Returning the error directly, as was supposedly
> > intended when looking at the code, fixes this.
> >
> > Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
>
> Patch applied. Thanks.
Thanks to you.
Will it be backported to 4.14 and the LTS releases ? Currently, no recent
debian kernel can boot on my system without that patch (I don't know why
nobody else noticed that before).
Pierre
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix NULL pointer deref. on no default_rng
2017-11-29 6:34 ` Herbert Xu
2017-12-07 10:32 ` Pierre
@ 2017-12-20 19:49 ` Pierre
1 sibling, 0 replies; 6+ messages in thread
From: Pierre @ 2017-12-20 19:49 UTC (permalink / raw)
To: Herbert Xu; +Cc: linux-crypto, davem
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Wednesday, November 29, 2017 5:34:30 PM CET Herbert Xu wrote:
> On Sun, Nov 12, 2017 at 03:24:32PM +0100, Pierre Ducroquet wrote:
> > If crypto_get_default_rng returns an error, the
> > function ecc_gen_privkey should return an error.
> > Instead, it currently tries to use the default_rng
> > nevertheless, thus creating a kernel panic with a
> > NULL pointer dereference.
> > Returning the error directly, as was supposedly
> > intended when looking at the code, fixes this.
> >
> > Signed-off-by: Pierre Ducroquet <pinaraf@pinaraf.info>
>
> Patch applied. Thanks.
Hi
How long will it take for the patch to be merged in an official release ?
This simple patch fixes a kernel panic at boot, it would be great for it to be
merged in 4.15.
Thanks
Pierre
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-20 19:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-12 14:24 [PATCH] Fix NULL pointer deref. on no default_rng Pierre Ducroquet
2017-11-12 14:46 ` PrasannaKumar Muralidharan
2017-11-18 17:18 ` Pierre
2017-11-29 6:34 ` Herbert Xu
2017-12-07 10:32 ` Pierre
2017-12-20 19:49 ` Pierre
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.