* [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity
@ 2017-11-25 22:51 Fabio Estevam
2017-11-27 4:55 ` Patrick Brünn
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-11-25 22:51 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
phy-reset-gpios is active high only if the 'phy-reset-active-high' is
present.
As 'phy-reset-active-high' is not used here, fix the device tree
description by passing GPIO_ACTIVE_LOW flag.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx53-cx9020.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx53-cx9020.dts b/arch/arm/boot/dts/imx53-cx9020.dts
index 4f54fd4..5e67e43 100644
--- a/arch/arm/boot/dts/imx53-cx9020.dts
+++ b/arch/arm/boot/dts/imx53-cx9020.dts
@@ -152,7 +152,7 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_fec>;
phy-mode = "rmii";
- phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
+ phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;
status = "okay";
};
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity
2017-11-25 22:51 [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity Fabio Estevam
@ 2017-11-27 4:55 ` Patrick Brünn
2017-11-27 13:29 ` Andrew Lunn
2017-11-29 7:00 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Patrick Brünn @ 2017-11-27 4:55 UTC (permalink / raw)
To: linux-arm-kernel
>From: Fabio Estevam [mailto:festevam at gmail.com]
>Sent: Samstag, 25. November 2017 23:51
>From: Fabio Estevam <fabio.estevam@nxp.com>
>
>As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
>phy-reset-gpios is active high only if the 'phy-reset-active-high' is
>present.
>
>As 'phy-reset-active-high' is not used here, fix the device tree
>description by passing GPIO_ACTIVE_LOW flag.
>
>Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
>---
> arch/arm/boot/dts/imx53-cx9020.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/arch/arm/boot/dts/imx53-cx9020.dts b/arch/arm/boot/dts/imx53-
>cx9020.dts
>index 4f54fd4..5e67e43 100644
>--- a/arch/arm/boot/dts/imx53-cx9020.dts
>+++ b/arch/arm/boot/dts/imx53-cx9020.dts
>@@ -152,7 +152,7 @@
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_fec>;
> phy-mode = "rmii";
>- phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
>+ phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_LOW>;
> status = "okay";
> };
>
>--
>2.7.4
Tested-by: Patrick Bruenn <p.bruenn@beckhoff.com>
Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity
2017-11-25 22:51 [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity Fabio Estevam
2017-11-27 4:55 ` Patrick Brünn
@ 2017-11-27 13:29 ` Andrew Lunn
2017-11-27 13:35 ` Fabio Estevam
2017-11-29 7:00 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Andrew Lunn @ 2017-11-27 13:29 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Nov 25, 2017 at 08:51:07PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
> phy-reset-gpios is active high only if the 'phy-reset-active-high' is
> present.
>
> As 'phy-reset-active-high' is not used here, fix the device tree
> description by passing GPIO_ACTIVE_LOW flag.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Hi Fabio
Do you have a bigger plan than just 'documentation'. Given that device
tree is an ABI, the GPIO_ACTIVE_ flag has to be ignored. Having it
correct is just documentation.
If you want to fix them all, is it worth adding in a warning to detect
a miss match between the GPIO_ACTIVE_* and phy-reset-active-high?
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity
2017-11-27 13:29 ` Andrew Lunn
@ 2017-11-27 13:35 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2017-11-27 13:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrew,
On Mon, Nov 27, 2017 at 11:29 AM, Andrew Lunn <andrew@lunn.ch> wrote:
> Hi Fabio
>
> Do you have a bigger plan than just 'documentation'. Given that device
> tree is an ABI, the GPIO_ACTIVE_ flag has to be ignored. Having it
> correct is just documentation.
>
> If you want to fix them all, is it worth adding in a warning to detect
> a miss match between the GPIO_ACTIVE_* and phy-reset-active-high?
This was the only dts with a mismatch.
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity
2017-11-25 22:51 [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity Fabio Estevam
2017-11-27 4:55 ` Patrick Brünn
2017-11-27 13:29 ` Andrew Lunn
@ 2017-11-29 7:00 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2017-11-29 7:00 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Nov 25, 2017 at 08:51:07PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
> phy-reset-gpios is active high only if the 'phy-reset-active-high' is
> present.
>
> As 'phy-reset-active-high' is not used here, fix the device tree
> description by passing GPIO_ACTIVE_LOW flag.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-29 7:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-25 22:51 [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity Fabio Estevam
2017-11-27 4:55 ` Patrick Brünn
2017-11-27 13:29 ` Andrew Lunn
2017-11-27 13:35 ` Fabio Estevam
2017-11-29 7:00 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.