[PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Jon Hunter]

On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
the EC is failing.

The Tegra SPI driver configures the SPI chip-selects to be active-high
by default (and always has for many years). The EC SPI requires an
active-low chip-select and so the Tegra chip-select is reconfigured to
be active-low when the EC SPI driver calls spi_setup(). The problem is
that if the first SPI message to the EC is sent too soon after
reconfiguring the SPI chip-select, it fails.

The EC SPI driver prevents back-to-back SPI messages being sent too
soon by keeping track of the time the last transfer was sent via the
variable 'last_transfer_ns'. To prevent the very first transfer being
sent too soon, initialise the 'last_transfer_ns' variable after calling
spi_setup() and before sending the first SPI message.

Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
---
Looks like this issue has been around for several Linux releases now
and it just depends on timing if this issue is seen or not and so there
is no specific commit this fixes. However, would be good to include for
v4.15.

 drivers/mfd/cros_ec_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index c9714072e224..a14196e95e9b 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -667,6 +667,7 @@ static int cros_ec_spi_probe(struct spi_device *spi)
 			   sizeof(struct ec_response_get_protocol_info);
 	ec_dev->dout_size = sizeof(struct ec_host_request);
 
+	ec_spi->last_transfer_ns = ktime_get_ns();
 
 	err = cros_ec_register(ec_dev);
 	if (err) {
-- 
2.7.4

[PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Jon Hunter]

On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
the EC is failing.

The Tegra SPI driver configures the SPI chip-selects to be active-high
by default (and always has for many years). The EC SPI requires an
active-low chip-select and so the Tegra chip-select is reconfigured to
be active-low when the EC SPI driver calls spi_setup(). The problem is
that if the first SPI message to the EC is sent too soon after
reconfiguring the SPI chip-select, it fails.

The EC SPI driver prevents back-to-back SPI messages being sent too
soon by keeping track of the time the last transfer was sent via the
variable 'last_transfer_ns'. To prevent the very first transfer being
sent too soon, initialise the 'last_transfer_ns' variable after calling
spi_setup() and before sending the first SPI message.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
Looks like this issue has been around for several Linux releases now
and it just depends on timing if this issue is seen or not and so there
is no specific commit this fixes. However, would be good to include for
v4.15.

 drivers/mfd/cros_ec_spi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index c9714072e224..a14196e95e9b 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -667,6 +667,7 @@ static int cros_ec_spi_probe(struct spi_device *spi)
 			   sizeof(struct ec_response_get_protocol_info);
 	ec_dev->dout_size = sizeof(struct ec_host_request);
 
+	ec_spi->last_transfer_ns = ktime_get_ns();
 
 	err = cros_ec_register(ec_dev);
 	if (err) {
-- 
2.7.4

[PATCH 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

[Jon Hunter]

The EC SPI driver prevents SPI transfers being to rapidly by keeping
track of the time the last transfer was issued via the
'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
variable was zero, this indicated that no previous transfer had been
sent and that no delay was needed. However, the EC SPI driver has
been updated to always initialise the 'last_transfer_ns' variable
during probe and therefore, it is no longer necessary to test if it
is zero. Remove the code that checks if this variable is zero.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index a14196e95e9b..7849d781c6bb 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -72,8 +72,7 @@
  * struct cros_ec_spi - information about a SPI-connected EC
  *
  * @spi: SPI device we are connected to
- * @last_transfer_ns: time that we last finished a transfer, or 0 if there
- *	if no record
+ * @last_transfer_ns: time that we last finished a transfer.
  * @start_of_msg_delay: used to set the delay_usecs on the spi_transfer that
  *      is sent when we want to turn on CS at the start of a transaction.
  * @end_of_msg_delay: used to set the delay_usecs on the spi_transfer that
@@ -378,18 +377,15 @@ static int cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev,
 	u8 *rx_buf;
 	u8 sum;
 	int ret = 0, final_ret;
+	unsigned long delay;
 
 	len = cros_ec_prepare_tx(ec_dev, ec_msg);
 	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
 
 	/* If it's too soon to do another transaction, wait */
-	if (ec_spi->last_transfer_ns) {
-		unsigned long delay;	/* The delay completed so far */
-
-		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
-		if (delay < EC_SPI_RECOVERY_TIME_NS)
-			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
-	}
+	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
+	if (delay < EC_SPI_RECOVERY_TIME_NS)
+		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
 
 	rx_buf = kzalloc(len, GFP_KERNEL);
 	if (!rx_buf)
@@ -510,18 +506,15 @@ static int cros_ec_cmd_xfer_spi(struct cros_ec_device *ec_dev,
 	u8 *rx_buf;
 	int sum;
 	int ret = 0, final_ret;
+	unsigned long delay;
 
 	len = cros_ec_prepare_tx(ec_dev, ec_msg);
 	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
 
 	/* If it's too soon to do another transaction, wait */
-	if (ec_spi->last_transfer_ns) {
-		unsigned long delay;	/* The delay completed so far */
-
-		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
-		if (delay < EC_SPI_RECOVERY_TIME_NS)
-			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
-	}
+	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
+	if (delay < EC_SPI_RECOVERY_TIME_NS)
+		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
 
 	rx_buf = kzalloc(len, GFP_KERNEL);
 	if (!rx_buf)
-- 
2.7.4

[PATCH 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

[Jon Hunter]

The EC SPI driver prevents SPI transfers being to rapidly by keeping
track of the time the last transfer was issued via the
'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
variable was zero, this indicated that no previous transfer had been
sent and that no delay was needed. However, the EC SPI driver has
been updated to always initialise the 'last_transfer_ns' variable
during probe and therefore, it is no longer necessary to test if it
is zero. Remove the code that checks if this variable is zero.

Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
---
 drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
index a14196e95e9b..7849d781c6bb 100644
--- a/drivers/mfd/cros_ec_spi.c
+++ b/drivers/mfd/cros_ec_spi.c
@@ -72,8 +72,7 @@
  * struct cros_ec_spi - information about a SPI-connected EC
  *
  * @spi: SPI device we are connected to
- * @last_transfer_ns: time that we last finished a transfer, or 0 if there
- *	if no record
+ * @last_transfer_ns: time that we last finished a transfer.
  * @start_of_msg_delay: used to set the delay_usecs on the spi_transfer that
  *      is sent when we want to turn on CS at the start of a transaction.
  * @end_of_msg_delay: used to set the delay_usecs on the spi_transfer that
@@ -378,18 +377,15 @@ static int cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev,
 	u8 *rx_buf;
 	u8 sum;
 	int ret = 0, final_ret;
+	unsigned long delay;
 
 	len = cros_ec_prepare_tx(ec_dev, ec_msg);
 	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
 
 	/* If it's too soon to do another transaction, wait */
-	if (ec_spi->last_transfer_ns) {
-		unsigned long delay;	/* The delay completed so far */
-
-		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
-		if (delay < EC_SPI_RECOVERY_TIME_NS)
-			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
-	}
+	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
+	if (delay < EC_SPI_RECOVERY_TIME_NS)
+		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
 
 	rx_buf = kzalloc(len, GFP_KERNEL);
 	if (!rx_buf)
@@ -510,18 +506,15 @@ static int cros_ec_cmd_xfer_spi(struct cros_ec_device *ec_dev,
 	u8 *rx_buf;
 	int sum;
 	int ret = 0, final_ret;
+	unsigned long delay;
 
 	len = cros_ec_prepare_tx(ec_dev, ec_msg);
 	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
 
 	/* If it's too soon to do another transaction, wait */
-	if (ec_spi->last_transfer_ns) {
-		unsigned long delay;	/* The delay completed so far */
-
-		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
-		if (delay < EC_SPI_RECOVERY_TIME_NS)
-			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
-	}
+	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
+	if (delay < EC_SPI_RECOVERY_TIME_NS)
+		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
 
 	rx_buf = kzalloc(len, GFP_KERNEL);
 	if (!rx_buf)
-- 
2.7.4

Re: [PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Brian Norris]

+ others

On Mon, Nov 13, 2017 at 09:05:39PM +0000, Jon Hunter wrote:
> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
> the EC is failing.
> 
> The Tegra SPI driver configures the SPI chip-selects to be active-high
> by default (and always has for many years). The EC SPI requires an
> active-low chip-select and so the Tegra chip-select is reconfigured to
> be active-low when the EC SPI driver calls spi_setup(). The problem is
> that if the first SPI message to the EC is sent too soon after
> reconfiguring the SPI chip-select, it fails.
> 
> The EC SPI driver prevents back-to-back SPI messages being sent too
> soon by keeping track of the time the last transfer was sent via the
> variable 'last_transfer_ns'. To prevent the very first transfer being
> sent too soon, initialise the 'last_transfer_ns' variable after calling
> spi_setup() and before sending the first SPI message.
> 
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Looks like this issue has been around for several Linux releases now
> and it just depends on timing if this issue is seen or not and so there
> is no specific commit this fixes. However, would be good to include for
> v4.15.

I wonder if that doesn't mean we should have a stable tag still?

Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>

>  drivers/mfd/cros_ec_spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index c9714072e224..a14196e95e9b 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -667,6 +667,7 @@ static int cros_ec_spi_probe(struct spi_device *spi)
>  			   sizeof(struct ec_response_get_protocol_info);
>  	ec_dev->dout_size = sizeof(struct ec_host_request);
>  
> +	ec_spi->last_transfer_ns = ktime_get_ns();

Seems pretty reasonable to me:

Reviewed-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

>  
>  	err = cros_ec_register(ec_dev);
>  	if (err) {
> -- 
> 2.7.4
> 

Re: [PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Brian Norris]

+ others

On Mon, Nov 13, 2017 at 09:05:39PM +0000, Jon Hunter wrote:
> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
> the EC is failing.
> 
> The Tegra SPI driver configures the SPI chip-selects to be active-high
> by default (and always has for many years). The EC SPI requires an
> active-low chip-select and so the Tegra chip-select is reconfigured to
> be active-low when the EC SPI driver calls spi_setup(). The problem is
> that if the first SPI message to the EC is sent too soon after
> reconfiguring the SPI chip-select, it fails.
> 
> The EC SPI driver prevents back-to-back SPI messages being sent too
> soon by keeping track of the time the last transfer was sent via the
> variable 'last_transfer_ns'. To prevent the very first transfer being
> sent too soon, initialise the 'last_transfer_ns' variable after calling
> spi_setup() and before sending the first SPI message.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> Looks like this issue has been around for several Linux releases now
> and it just depends on timing if this issue is seen or not and so there
> is no specific commit this fixes. However, would be good to include for
> v4.15.

I wonder if that doesn't mean we should have a stable tag still?

Cc: <stable@vger.kernel.org>

>  drivers/mfd/cros_ec_spi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index c9714072e224..a14196e95e9b 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -667,6 +667,7 @@ static int cros_ec_spi_probe(struct spi_device *spi)
>  			   sizeof(struct ec_response_get_protocol_info);
>  	ec_dev->dout_size = sizeof(struct ec_host_request);
>  
> +	ec_spi->last_transfer_ns = ktime_get_ns();

Seems pretty reasonable to me:

Reviewed-by: Brian Norris <briannorris@chromium.org>

>  
>  	err = cros_ec_register(ec_dev);
>  	if (err) {
> -- 
> 2.7.4
> 

Re: [PATCH 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

[Brian Norris]

On Mon, Nov 13, 2017 at 09:05:40PM +0000, Jon Hunter wrote:
> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicated that no previous transfer had been
> sent and that no delay was needed. However, the EC SPI driver has
> been updated to always initialise the 'last_transfer_ns' variable
> during probe and therefore, it is no longer necessary to test if it
> is zero. Remove the code that checks if this variable is zero.
> 
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Reviewed-by: Brian Norris <briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

> ---
>  drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index a14196e95e9b..7849d781c6bb 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -72,8 +72,7 @@
>   * struct cros_ec_spi - information about a SPI-connected EC
>   *
>   * @spi: SPI device we are connected to
> - * @last_transfer_ns: time that we last finished a transfer, or 0 if there
> - *	if no record
> + * @last_transfer_ns: time that we last finished a transfer.
>   * @start_of_msg_delay: used to set the delay_usecs on the spi_transfer that
>   *      is sent when we want to turn on CS at the start of a transaction.
>   * @end_of_msg_delay: used to set the delay_usecs on the spi_transfer that
> @@ -378,18 +377,15 @@ static int cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev,
>  	u8 *rx_buf;
>  	u8 sum;
>  	int ret = 0, final_ret;
> +	unsigned long delay;
>  
>  	len = cros_ec_prepare_tx(ec_dev, ec_msg);
>  	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
>  
>  	/* If it's too soon to do another transaction, wait */
> -	if (ec_spi->last_transfer_ns) {
> -		unsigned long delay;	/* The delay completed so far */
> -
> -		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> -		if (delay < EC_SPI_RECOVERY_TIME_NS)
> -			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
> -	}
> +	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> +	if (delay < EC_SPI_RECOVERY_TIME_NS)
> +		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
>  
>  	rx_buf = kzalloc(len, GFP_KERNEL);
>  	if (!rx_buf)
> @@ -510,18 +506,15 @@ static int cros_ec_cmd_xfer_spi(struct cros_ec_device *ec_dev,
>  	u8 *rx_buf;
>  	int sum;
>  	int ret = 0, final_ret;
> +	unsigned long delay;
>  
>  	len = cros_ec_prepare_tx(ec_dev, ec_msg);
>  	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
>  
>  	/* If it's too soon to do another transaction, wait */
> -	if (ec_spi->last_transfer_ns) {
> -		unsigned long delay;	/* The delay completed so far */
> -
> -		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> -		if (delay < EC_SPI_RECOVERY_TIME_NS)
> -			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
> -	}
> +	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> +	if (delay < EC_SPI_RECOVERY_TIME_NS)
> +		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
>  
>  	rx_buf = kzalloc(len, GFP_KERNEL);
>  	if (!rx_buf)
> -- 
> 2.7.4
> 

Re: [PATCH 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

[Brian Norris]

On Mon, Nov 13, 2017 at 09:05:40PM +0000, Jon Hunter wrote:
> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicated that no previous transfer had been
> sent and that no delay was needed. However, the EC SPI driver has
> been updated to always initialise the 'last_transfer_ns' variable
> during probe and therefore, it is no longer necessary to test if it
> is zero. Remove the code that checks if this variable is zero.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>

Reviewed-by: Brian Norris <briannorris@chromium.org>

> ---
>  drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c
> index a14196e95e9b..7849d781c6bb 100644
> --- a/drivers/mfd/cros_ec_spi.c
> +++ b/drivers/mfd/cros_ec_spi.c
> @@ -72,8 +72,7 @@
>   * struct cros_ec_spi - information about a SPI-connected EC
>   *
>   * @spi: SPI device we are connected to
> - * @last_transfer_ns: time that we last finished a transfer, or 0 if there
> - *	if no record
> + * @last_transfer_ns: time that we last finished a transfer.
>   * @start_of_msg_delay: used to set the delay_usecs on the spi_transfer that
>   *      is sent when we want to turn on CS at the start of a transaction.
>   * @end_of_msg_delay: used to set the delay_usecs on the spi_transfer that
> @@ -378,18 +377,15 @@ static int cros_ec_pkt_xfer_spi(struct cros_ec_device *ec_dev,
>  	u8 *rx_buf;
>  	u8 sum;
>  	int ret = 0, final_ret;
> +	unsigned long delay;
>  
>  	len = cros_ec_prepare_tx(ec_dev, ec_msg);
>  	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
>  
>  	/* If it's too soon to do another transaction, wait */
> -	if (ec_spi->last_transfer_ns) {
> -		unsigned long delay;	/* The delay completed so far */
> -
> -		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> -		if (delay < EC_SPI_RECOVERY_TIME_NS)
> -			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
> -	}
> +	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> +	if (delay < EC_SPI_RECOVERY_TIME_NS)
> +		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
>  
>  	rx_buf = kzalloc(len, GFP_KERNEL);
>  	if (!rx_buf)
> @@ -510,18 +506,15 @@ static int cros_ec_cmd_xfer_spi(struct cros_ec_device *ec_dev,
>  	u8 *rx_buf;
>  	int sum;
>  	int ret = 0, final_ret;
> +	unsigned long delay;
>  
>  	len = cros_ec_prepare_tx(ec_dev, ec_msg);
>  	dev_dbg(ec_dev->dev, "prepared, len=%d\n", len);
>  
>  	/* If it's too soon to do another transaction, wait */
> -	if (ec_spi->last_transfer_ns) {
> -		unsigned long delay;	/* The delay completed so far */
> -
> -		delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> -		if (delay < EC_SPI_RECOVERY_TIME_NS)
> -			ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
> -	}
> +	delay = ktime_get_ns() - ec_spi->last_transfer_ns;
> +	if (delay < EC_SPI_RECOVERY_TIME_NS)
> +		ndelay(EC_SPI_RECOVERY_TIME_NS - delay);
>  
>  	rx_buf = kzalloc(len, GFP_KERNEL);
>  	if (!rx_buf)
> -- 
> 2.7.4
> 

Re: [PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Jon Hunter]

On 13/11/17 21:19, Brian Norris wrote:
> + others
> 
> On Mon, Nov 13, 2017 at 09:05:39PM +0000, Jon Hunter wrote:
>> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
>> the EC is failing.
>>
>> The Tegra SPI driver configures the SPI chip-selects to be active-high
>> by default (and always has for many years). The EC SPI requires an
>> active-low chip-select and so the Tegra chip-select is reconfigured to
>> be active-low when the EC SPI driver calls spi_setup(). The problem is
>> that if the first SPI message to the EC is sent too soon after
>> reconfiguring the SPI chip-select, it fails.
>>
>> The EC SPI driver prevents back-to-back SPI messages being sent too
>> soon by keeping track of the time the last transfer was sent via the
>> variable 'last_transfer_ns'. To prevent the very first transfer being
>> sent too soon, initialise the 'last_transfer_ns' variable after calling
>> spi_setup() and before sending the first SPI message.
>>
>> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> ---
>> Looks like this issue has been around for several Linux releases now
>> and it just depends on timing if this issue is seen or not and so there
>> is no specific commit this fixes. However, would be good to include for
>> v4.15.
> 
> I wonder if that doesn't mean we should have a stable tag still?
> 
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>

I was thinking about that as well after I sent it. I have resent as a V2
CC'ing stable.

Cheers
Jon

-- 
nvpublic

Re: [PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Jon Hunter]

On 13/11/17 21:19, Brian Norris wrote:
> + others
> 
> On Mon, Nov 13, 2017 at 09:05:39PM +0000, Jon Hunter wrote:
>> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
>> the EC is failing.
>>
>> The Tegra SPI driver configures the SPI chip-selects to be active-high
>> by default (and always has for many years). The EC SPI requires an
>> active-low chip-select and so the Tegra chip-select is reconfigured to
>> be active-low when the EC SPI driver calls spi_setup(). The problem is
>> that if the first SPI message to the EC is sent too soon after
>> reconfiguring the SPI chip-select, it fails.
>>
>> The EC SPI driver prevents back-to-back SPI messages being sent too
>> soon by keeping track of the time the last transfer was sent via the
>> variable 'last_transfer_ns'. To prevent the very first transfer being
>> sent too soon, initialise the 'last_transfer_ns' variable after calling
>> spi_setup() and before sending the first SPI message.
>>
>> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
>> ---
>> Looks like this issue has been around for several Linux releases now
>> and it just depends on timing if this issue is seen or not and so there
>> is no specific commit this fixes. However, would be good to include for
>> v4.15.
> 
> I wonder if that doesn't mean we should have a stable tag still?
> 
> Cc: <stable@vger.kernel.org>

I was thinking about that as well after I sent it. I have resent as a V2
CC'ing stable.

Cheers
Jon

-- 
nvpublic

Re: [PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Lee Jones]

On Mon, 13 Nov 2017, Jon Hunter wrote:

> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
> the EC is failing.
> 
> The Tegra SPI driver configures the SPI chip-selects to be active-high
> by default (and always has for many years). The EC SPI requires an
> active-low chip-select and so the Tegra chip-select is reconfigured to
> be active-low when the EC SPI driver calls spi_setup(). The problem is
> that if the first SPI message to the EC is sent too soon after
> reconfiguring the SPI chip-select, it fails.
> 
> The EC SPI driver prevents back-to-back SPI messages being sent too
> soon by keeping track of the time the last transfer was sent via the
> variable 'last_transfer_ns'. To prevent the very first transfer being
> sent too soon, initialise the 'last_transfer_ns' variable after calling
> spi_setup() and before sending the first SPI message.
> 
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
> Looks like this issue has been around for several Linux releases now
> and it just depends on timing if this issue is seen or not and so there
> is no specific commit this fixes. However, would be good to include for
> v4.15.
> 
>  drivers/mfd/cros_ec_spi.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/2] mfd: cros ec: spi: Don't send first message too soon

[Lee Jones]

On Mon, 13 Nov 2017, Jon Hunter wrote:

> On the Tegra124 Nyan-Big chromebook the very first SPI message sent to
> the EC is failing.
> 
> The Tegra SPI driver configures the SPI chip-selects to be active-high
> by default (and always has for many years). The EC SPI requires an
> active-low chip-select and so the Tegra chip-select is reconfigured to
> be active-low when the EC SPI driver calls spi_setup(). The problem is
> that if the first SPI message to the EC is sent too soon after
> reconfiguring the SPI chip-select, it fails.
> 
> The EC SPI driver prevents back-to-back SPI messages being sent too
> soon by keeping track of the time the last transfer was sent via the
> variable 'last_transfer_ns'. To prevent the very first transfer being
> sent too soon, initialise the 'last_transfer_ns' variable after calling
> spi_setup() and before sending the first SPI message.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
> Looks like this issue has been around for several Linux releases now
> and it just depends on timing if this issue is seen or not and so there
> is no specific commit this fixes. However, would be good to include for
> v4.15.
> 
>  drivers/mfd/cros_ec_spi.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

[Lee Jones]

On Mon, 13 Nov 2017, Jon Hunter wrote:

> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicated that no previous transfer had been
> sent and that no delay was needed. However, the EC SPI driver has
> been updated to always initialise the 'last_transfer_ns' variable
> during probe and therefore, it is no longer necessary to test if it
> is zero. Remove the code that checks if this variable is zero.
> 
> Signed-off-by: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 2/2] mfd: cros ec: spi: Simplify delay handling between SPI messages

[Lee Jones]

On Mon, 13 Nov 2017, Jon Hunter wrote:

> The EC SPI driver prevents SPI transfers being to rapidly by keeping
> track of the time the last transfer was issued via the
> 'last_transfer_ns' variable. Previously, if the 'last_transfer_ns'
> variable was zero, this indicated that no previous transfer had been
> sent and that no delay was needed. However, the EC SPI driver has
> been updated to always initialise the 'last_transfer_ns' variable
> during probe and therefore, it is no longer necessary to test if it
> is zero. Remove the code that checks if this variable is zero.
> 
> Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
> ---
>  drivers/mfd/cros_ec_spi.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)

Applied, thanks.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog