* [PATCH] Use non-debug build for Xen 4.10
@ 2017-11-29 12:09 Julien Grall
2017-11-29 13:29 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2017-11-29 12:09 UTC (permalink / raw)
To: xen-devel
Cc: sstabellini, wei.liu2, George.Dunlap, andrew.cooper3,
Julien Grall, ian.jackson, tim, jbeulich
Modify Config.mk and Kconfig.debug to disable debug by default in
preparation for late RCs and eventual release.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
I would like this to get included before branching. So we can cut the RC
right after branching.
---
tools/Rules.mk | 2 +-
xen/Kconfig.debug | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index 61515d3063..6268c14e3a 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -31,7 +31,7 @@ CFLAGS_xeninclude = -I$(XEN_INCLUDE)
XENSTORE_XENSTORED ?= y
# A debug build of tools?
-debug ?= y
+debug ?= n
debug_symbols ?= $(debug)
# Set CONFIG_GOLANG=y in .config (or in make) to build golang
diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug
index 8d70f63743..c0f3c017ed 100644
--- a/xen/Kconfig.debug
+++ b/xen/Kconfig.debug
@@ -3,7 +3,7 @@ menu "Debugging Options"
config DEBUG
bool "Developer Checks"
- default y
+ default n
---help---
If you say Y here this will enable developer checks such as asserts
and extra printks. This option is intended for development purposes
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Use non-debug build for Xen 4.10
2017-11-29 12:09 [PATCH] Use non-debug build for Xen 4.10 Julien Grall
@ 2017-11-29 13:29 ` Jan Beulich
2017-11-29 14:22 ` Julien Grall
0 siblings, 1 reply; 4+ messages in thread
From: Jan Beulich @ 2017-11-29 13:29 UTC (permalink / raw)
To: Julien Grall
Cc: tim, sstabellini, wei.liu2, George.Dunlap, andrew.cooper3,
ian.jackson, xen-devel
>>> On 29.11.17 at 13:09, <julien.grall@linaro.org> wrote:
> Modify Config.mk and Kconfig.debug to disable debug by default in
> preparation for late RCs and eventual release.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>
> ---
>
> I would like this to get included before branching. So we can cut the RC
> right after branching.
I think doing this before branching has proven a bad idea in the
past, due to Coverity seeing a sufficiently different set of issues
in both modes. I therefore think that turning off debug should
actually be part of branching (e.g. be the first commit on the new
stable branch).
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Use non-debug build for Xen 4.10
2017-11-29 13:29 ` Jan Beulich
@ 2017-11-29 14:22 ` Julien Grall
2017-11-29 14:27 ` Jan Beulich
0 siblings, 1 reply; 4+ messages in thread
From: Julien Grall @ 2017-11-29 14:22 UTC (permalink / raw)
To: Jan Beulich
Cc: tim, sstabellini, wei.liu2, George.Dunlap, andrew.cooper3,
ian.jackson, xen-devel
Hi Jan,
On 11/29/2017 01:29 PM, Jan Beulich wrote:
>>>> On 29.11.17 at 13:09, <julien.grall@linaro.org> wrote:
>> Modify Config.mk and Kconfig.debug to disable debug by default in
>> preparation for late RCs and eventual release.
>>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>
>> ---
>>
>> I would like this to get included before branching. So we can cut the RC
>> right after branching.
>
> I think doing this before branching has proven a bad idea in the
> past, due to Coverity seeing a sufficiently different set of issues
> in both modes.
If Coverity requires debug then the .config used for coverity should
have CONFIG_DEBUG=y.
So, I find rather strange to have to delay that patch just because of
Coverity.
> I therefore think that turning off debug should
> actually be part of branching (e.g. be the first commit on the new
> stable branch).
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Use non-debug build for Xen 4.10
2017-11-29 14:22 ` Julien Grall
@ 2017-11-29 14:27 ` Jan Beulich
0 siblings, 0 replies; 4+ messages in thread
From: Jan Beulich @ 2017-11-29 14:27 UTC (permalink / raw)
To: Julien Grall
Cc: tim, sstabellini, wei.liu2, George.Dunlap, andrew.cooper3,
ian.jackson, xen-devel
>>> On 29.11.17 at 15:22, <julien.grall@linaro.org> wrote:
> On 11/29/2017 01:29 PM, Jan Beulich wrote:
>>>>> On 29.11.17 at 13:09, <julien.grall@linaro.org> wrote:
>>> Modify Config.mk and Kconfig.debug to disable debug by default in
>>> preparation for late RCs and eventual release.
>>>
>>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
>>>
>>> ---
>>>
>>> I would like this to get included before branching. So we can cut the RC
>>> right after branching.
>>
>> I think doing this before branching has proven a bad idea in the
>> past, due to Coverity seeing a sufficiently different set of issues
>> in both modes.
>
> If Coverity requires debug then the .config used for coverity should
> have CONFIG_DEBUG=y.
That would be wrong on stable branches. Coverity works on either
build, but produces significantly different results for the two cases.
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-29 14:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 12:09 [PATCH] Use non-debug build for Xen 4.10 Julien Grall
2017-11-29 13:29 ` Jan Beulich
2017-11-29 14:22 ` Julien Grall
2017-11-29 14:27 ` Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.