Re: omapfb: dss: Do not duplicate features data

Re: omapfb: dss: Do not duplicate features data

[SF Markus Elfring]

> As features data are read only, there is no need to allocate their
> copy on the heap.
…
>  Note2: Marcus, I hope it is okay to add your Suggested-by tag.

Maybe.


>         Please let me know, if I'm wrong.

I am unsure about the view on how much I suggested such a source code adjustment.

A development discussion for my update suggestion “omapfb/dss: Delete an error message
for a failed memory allocation in three functions” triggered the contribution of your idea.

https://lkml.org/lkml/2017/11/27/919


Did you omit the general Linux kernel mailing list from your proposal intentionally?

Regards,
Markus

Re: omapfb: dss: Do not duplicate features data

[Ladislav Michl]

On Wed, Nov 29, 2017 at 03:38:46PM +0100, SF Markus Elfring wrote:
> > As features data are read only, there is no need to allocate their
> > copy on the heap.
> …
> >  Note2: Marcus, I hope it is okay to add your Suggested-by tag.
> 
> Maybe.
> 
> >         Please let me know, if I'm wrong.
> 
> I am unsure about the view on how much I suggested such a source code adjustment.

Well, it is up to you completely. I didn't find any more relevant tag, which
neccessarily doesn't mean it is appropriate.

> A development discussion for my update suggestion “omapfb/dss: Delete an error message
> for a failed memory allocation in three functions” triggered the contribution of your idea.

I would never look at that code without looking to said patch.

> https://lkml.org/lkml/2017/11/27/919
> 
> Did you omit the general Linux kernel mailing list from your proposal intentionally?

I've never sent single mail to the general Linux kernel mailing list other than
it already was in Cc. It was write-only list decade ago and now it is not any
better :)

Best regards,
	ladis

Re: omapfb: dss: Do not duplicate features data

[SF Markus Elfring]

>>>  Note2: Marcus, I hope it is okay to add your Suggested-by tag.
>>
>> Maybe.
>>
>>>         Please let me know, if I'm wrong.
>>
>> I am unsure about the view on how much I suggested such a source code adjustment.
> 
> Well, it is up to you completely.

I would prefer then to omit this tag in case you are going to publish
a subsequent version for your current update suggestion.


> I didn't find any more relevant tag,
> which neccessarily doesn't mean it is appropriate.

Would you like to add your “own tag”?


>> A development discussion for my update suggestion “omapfb/dss: Delete an error message
>> for a failed memory allocation in three functions” triggered the contribution of your idea.
> 
> I would never look at that code without looking to said patch.
> 
>> https://lkml.org/lkml/2017/11/27/919

* Did you become inspired by this discussion anyhow?

* Will a link become useful for your commit message?

Regards,
Markus