All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Lee Jones <lee.jones@linaro.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux-Next Mailing List <linux-next@vger.kernel.org>
Subject: [PATCH] leds: pm8058: Make ledtype pointer sized type
Date: Wed, 29 Nov 2017 19:05:43 -0800	[thread overview]
Message-ID: <20171130030543.1071-1-bjorn.andersson@linaro.org> (raw)
In-Reply-To: <20171130113516.42c8bde2@canb.auug.org.au>

The pointer returned by of_device_get_match_data() doesn't have the same
size as u32 on 64-bit architectures, causing issues when compile testing
the driver on such platform. Make ledtype unsigned long instead, to
solve this problem.

Fixes: 7f866986e705 ("leds: add PM8058 LEDs driver")
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/leds/leds-pm8058.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/leds-pm8058.c b/drivers/leds/leds-pm8058.c
index a52674327857..cc2afe81720d 100644
--- a/drivers/leds/leds-pm8058.c
+++ b/drivers/leds/leds-pm8058.c
@@ -29,7 +29,7 @@
 struct pm8058_led {
 	struct regmap *map;
 	u32 reg;
-	u32 ledtype;
+	unsigned long ledtype;
 	struct led_classdev cdev;
 };
 
@@ -106,7 +106,7 @@ static int pm8058_led_probe(struct platform_device *pdev)
 	if (!led)
 		return -ENOMEM;
 
-	led->ledtype = (u32)of_device_get_match_data(&pdev->dev);
+	led->ledtype = (unsigned long)of_device_get_match_data(&pdev->dev);
 
 	map = dev_get_regmap(pdev->dev.parent, NULL);
 	if (!map) {
-- 
2.15.0

  reply	other threads:[~2017-11-30  3:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  0:35 linux-next: build warning after merge of the mfd tree Stephen Rothwell
2017-11-30  3:05 ` Bjorn Andersson [this message]
2017-11-30  8:29   ` [PATCH] leds: pm8058: Make ledtype pointer sized type Lee Jones
2017-11-30  8:31     ` Lee Jones
2017-11-30 22:02       ` Jacek Anaszewski
2017-12-01  7:56         ` Lee Jones
2017-12-01 20:35           ` Jacek Anaszewski
2017-11-30  9:18   ` Linus Walleij
2017-11-30  9:41     ` Lee Jones
2017-11-30  9:40   ` Pavel Machek
2017-11-30 21:58     ` Jacek Anaszewski
2017-11-30 22:34       ` Pavel Machek
2017-11-30 23:14         ` Stephen Rothwell
2017-12-01  0:28           ` Pavel Machek
2017-12-01  5:10             ` Bjorn Andersson
2017-11-30 22:18     ` Bjorn Andersson
2017-11-30  8:28 ` linux-next: build warning after merge of the mfd tree Lee Jones
2017-12-01  5:16 ` [PATCH v2] leds: pm8058: Silence pointer to integer size warning Bjorn Andersson
2017-12-01  7:57   ` Lee Jones
2017-12-01  8:36     ` Pavel Machek
2017-12-01  8:56       ` Lee Jones
2017-12-01  8:56   ` Lee Jones
2017-12-01  9:01   ` [GIT PULL] Immutable branch between MFD and LED due for the v4.16 merge window Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130030543.1071-1-bjorn.andersson@linaro.org \
    --to=bjorn.andersson@linaro.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.