From: Pavel Machek <pavel@ucw.cz>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Lee Jones <lee.jones@linaro.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: [PATCH] leds: pm8058: Make ledtype pointer sized type
Date: Fri, 1 Dec 2017 01:28:58 +0100 [thread overview]
Message-ID: <20171201002858.GD2808@amd> (raw)
In-Reply-To: <20171201101351.3e57f2b1@canb.auug.org.au>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Hi!
> > > of_device_get_match_data will return PM8058_LED_TYPE_*
> > > which clearly is a led type identifier.
> > >
> > > Thus unsigned long looks reasonable.
> >
> > Hmm. Ok. So u32 would actually make even more sense there (because
> > PM8058_LED_TYPE_* does not really need to be 64-bit), but it would
> > cause a warning.
> >
> > I don't like this. This fix actually makes code waste memory and is
> > uglier.
> >
> > ...but we get a warning fix. So I don't like the patch, but it is an
> > improvement...
>
> I *think* you can get away with (u32)(unsigned long)ptr ...
Yes, that should work. It would actually be my preferred solution.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2017-12-01 0:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 0:35 linux-next: build warning after merge of the mfd tree Stephen Rothwell
2017-11-30 3:05 ` [PATCH] leds: pm8058: Make ledtype pointer sized type Bjorn Andersson
2017-11-30 8:29 ` Lee Jones
2017-11-30 8:31 ` Lee Jones
2017-11-30 22:02 ` Jacek Anaszewski
2017-12-01 7:56 ` Lee Jones
2017-12-01 20:35 ` Jacek Anaszewski
2017-11-30 9:18 ` Linus Walleij
2017-11-30 9:41 ` Lee Jones
2017-11-30 9:40 ` Pavel Machek
2017-11-30 21:58 ` Jacek Anaszewski
2017-11-30 22:34 ` Pavel Machek
2017-11-30 23:14 ` Stephen Rothwell
2017-12-01 0:28 ` Pavel Machek [this message]
2017-12-01 5:10 ` Bjorn Andersson
2017-11-30 22:18 ` Bjorn Andersson
2017-11-30 8:28 ` linux-next: build warning after merge of the mfd tree Lee Jones
2017-12-01 5:16 ` [PATCH v2] leds: pm8058: Silence pointer to integer size warning Bjorn Andersson
2017-12-01 7:57 ` Lee Jones
2017-12-01 8:36 ` Pavel Machek
2017-12-01 8:56 ` Lee Jones
2017-12-01 8:56 ` Lee Jones
2017-12-01 9:01 ` [GIT PULL] Immutable branch between MFD and LED due for the v4.16 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201002858.GD2808@amd \
--to=pavel@ucw.cz \
--cc=bjorn.andersson@linaro.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.