[Buildroot] [PATCH 3/3] musl: enable or1k architecture

[Buildroot] [PATCH 3/3] musl: enable or1k architecture

[Waldemar Brodkorb]

With Linux kernel >= 4.13.x musl or1k can be used
with Qemu.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 toolchain/toolchain-buildroot/Config.in | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/toolchain/toolchain-buildroot/Config.in b/toolchain/toolchain-buildroot/Config.in
index c624350cac..9668f8d41a 100644
--- a/toolchain/toolchain-buildroot/Config.in
+++ b/toolchain/toolchain-buildroot/Config.in
@@ -79,10 +79,10 @@ comment "glibc on MIPS w/ NAN2008 needs a toolchain w/ headers >= 4.5"
 
 config BR2_TOOLCHAIN_BUILDROOT_MUSL
 	bool "musl"
-	depends on BR2_aarch64	  || BR2_arm     || BR2_armeb     || BR2_i386 || \
-		   BR2_microblaze || BR2_mips    || BR2_mipsel    || BR2_mips64 || \
-		   BR2_mips64el   || BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \
-		   BR2_sh         || BR2_x86_64
+	depends on BR2_aarch64	   || BR2_arm   || BR2_armeb   || BR2_i386 || \
+		   BR2_microblaze  || BR2_mips  || BR2_mipsel  || BR2_mips64 || \
+		   BR2_mips64el    || BR2_or1k  || BR2_powerpc || BR2_powerpc64 || \
+		   BR2_powerpc64le || BR2_sh    || BR2_x86_64
 	depends on !BR2_powerpc_SPE # not supported, build breaks
 	# sh2 nommu is supported by musl, but we don't have support
 	# for it in Buildroot.
-- 
2.11.0

[Buildroot] [PATCH 3/3] musl: enable or1k architecture

[Thomas Petazzoni]

Hello,

On Thu, 30 Nov 2017 07:00:28 +0100, Waldemar Brodkorb wrote:
> With Linux kernel >= 4.13.x musl or1k can be used
> with Qemu.
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

Could you clarify why it was not possible to use musl on or1k with
kernels < 4.13 ?

Was it just a limitation of the or1k support causing runtime issues ? A
build problem ?

I.e, I'm wondering if we should just enable or1k like you did, or if we
should make it conditional on the kernel headers being >= 4.13.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

[Buildroot] [PATCH 3/3] musl: enable or1k architecture

[Waldemar Brodkorb]

Hi,

> Am 30.11.2017 um 08:57 schrieb Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> 
> Hello,
> 
>> On Thu, 30 Nov 2017 07:00:28 +0100, Waldemar Brodkorb wrote:
>> With Linux kernel >= 4.13.x musl or1k can be used
>> with Qemu.
>> 
>> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> 
> Could you clarify why it was not possible to use musl on or1k with
> kernels < 4.13 ?
> 
> Was it just a limitation of the or1k support causing runtime issues ? A
> build problem ?
> 
> I.e, I'm wondering if we should just enable or1k like you did, or if we
> should make it conditional on the kernel headers being >= 4.13.

It was a runtime issue, panic of init.
Not sure which commit fixed it. I think 
it was a qemu specific problem, that means it might have worked on real hardware with older kernels.

Or nobody ever tested musl or1k on real hardware ?.
I know that Rich only tested the musl port with qemu-user, not with qemu-system.

best regards
 Waldemar