* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
@ 2017-05-02 9:24 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2017-05-02 9:24 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: linux-arm-kernel, Magnus Damm, Simon Horman
Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
as per:
* commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
* commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
Also set ignore_loglevel rw as boot args as is the case for the boards
for the boards for other Renesas ARM/ARM64 based SoCs.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
* Compile tested only due to lack of hardware access
* Based on renesas-devel-20170502-v4.11
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 2bc7ceb2efa4..7669b282bde2 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -21,6 +21,7 @@
};
chosen {
+ bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
stdout-path = "serial0:115200n8";
};
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
@ 2017-05-02 9:24 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2017-05-02 9:24 UTC (permalink / raw)
To: linux-arm-kernel
Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
as per:
* commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
* commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
Also set ignore_loglevel rw as boot args as is the case for the boards
for the boards for other Renesas ARM/ARM64 based SoCs.
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
* Compile tested only due to lack of hardware access
* Based on renesas-devel-20170502-v4.11
---
arch/arm64/boot/dts/renesas/ulcb.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi b/arch/arm64/boot/dts/renesas/ulcb.dtsi
index 2bc7ceb2efa4..7669b282bde2 100644
--- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
@@ -21,6 +21,7 @@
};
chosen {
+ bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
stdout-path = "serial0:115200n8";
};
--
2.1.4
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
2017-05-02 9:24 ` Simon Horman
@ 2017-05-02 9:27 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2017-05-02 9:27 UTC (permalink / raw)
To: Simon Horman; +Cc: Linux-Renesas, linux-arm-kernel, Magnus Damm
Hi Simon,
On Tue, May 2, 2017 at 11:24 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
> as per:
> * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
> * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
>
> Also set ignore_loglevel rw as boot args as is the case for the boards
> for the boards for other Renesas ARM/ARM64 based SoCs.
s/for the boards//
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
@ 2017-05-02 9:27 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2017-05-02 9:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Tue, May 2, 2017 at 11:24 AM, Simon Horman
<horms+renesas@verge.net.au> wrote:
> Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
> as per:
> * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
> * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
>
> Also set ignore_loglevel rw as boot args as is the case for the boards
> for the boards for other Renesas ARM/ARM64 based SoCs.
s/for the boards//
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
2017-05-02 9:27 ` Geert Uytterhoeven
@ 2017-11-30 9:43 ` Simon Horman
-1 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2017-11-30 9:43 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux-Renesas, linux-arm-kernel, Magnus Damm
On Tue, May 02, 2017 at 11:27:58AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 2, 2017 at 11:24 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
> > as per:
> > * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
> > * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
> >
> > Also set ignore_loglevel rw as boot args as is the case for the boards
> > for the boards for other Renesas ARM/ARM64 based SoCs.
>
> s/for the boards//
>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
Sergei has pointed out that bootargs has seems to have effect on ARM64
kernels. So I think this patch should be withdrawn and we should consider
removing bootargs from those ARM64 boards where it is present.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
@ 2017-11-30 9:43 ` Simon Horman
0 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2017-11-30 9:43 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 02, 2017 at 11:27:58AM +0200, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Tue, May 2, 2017 at 11:24 AM, Simon Horman
> <horms+renesas@verge.net.au> wrote:
> > Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
> > as per:
> > * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
> > * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
> >
> > Also set ignore_loglevel rw as boot args as is the case for the boards
> > for the boards for other Renesas ARM/ARM64 based SoCs.
>
> s/for the boards//
>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
Sergei has pointed out that bootargs has seems to have effect on ARM64
kernels. So I think this patch should be withdrawn and we should consider
removing bootargs from those ARM64 boards where it is present.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
2017-11-30 9:43 ` Simon Horman
@ 2017-11-30 12:52 ` Niklas Söderlund
-1 siblings, 0 replies; 12+ messages in thread
From: Niklas Söderlund @ 2017-11-30 12:52 UTC (permalink / raw)
To: Simon Horman
Cc: Geert Uytterhoeven, Linux-Renesas, linux-arm-kernel, Magnus Damm
Hi Simon,
On 2017-11-30 10:43:55 +0100, Simon Horman wrote:
> On Tue, May 02, 2017 at 11:27:58AM +0200, Geert Uytterhoeven wrote:
> > Hi Simon,
> >
> > On Tue, May 2, 2017 at 11:24 AM, Simon Horman
> > <horms+renesas@verge.net.au> wrote:
> > > Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
> > > as per:
> > > * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
> > > * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
> > >
> > > Also set ignore_loglevel rw as boot args as is the case for the boards
> > > for the boards for other Renesas ARM/ARM64 based SoCs.
> >
> > s/for the boards//
> >
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Gr{oetje,eeting}s,
>
> Sergei has pointed out that bootargs has seems to have effect on ARM64
> kernels. So I think this patch should be withdrawn and we should consider
> removing bootargs from those ARM64 boards where it is present.
>
I don't think this is true.
I just added a argument to bootargs to salvator-common.dtsi for some
hack testing and it took effect. Tested on-top of latest renesas-drivers
and H3 ES2.0.
>>> DIFF <<<
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 7b30044a55367d35..4cb4b44f8be42cb4 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -42,7 +42,7 @@
};
chosen {
- bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
+ bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1";
stdout-path = "serial0:115200n8";
};
>>> END DIFF <<<
# cat /sys/firmware/devicetree/base/chosen/bootargs
ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1
And the module parameter had the expected effect on the adv7482x driver.
Is there another issue here which I'm missing?
--
Regards,
Niklas S�derlund
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
@ 2017-11-30 12:52 ` Niklas Söderlund
0 siblings, 0 replies; 12+ messages in thread
From: Niklas Söderlund @ 2017-11-30 12:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On 2017-11-30 10:43:55 +0100, Simon Horman wrote:
> On Tue, May 02, 2017 at 11:27:58AM +0200, Geert Uytterhoeven wrote:
> > Hi Simon,
> >
> > On Tue, May 2, 2017 at 11:24 AM, Simon Horman
> > <horms+renesas@verge.net.au> wrote:
> > > Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
> > > as per:
> > > * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
> > > * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
> > >
> > > Also set ignore_loglevel rw as boot args as is the case for the boards
> > > for the boards for other Renesas ARM/ARM64 based SoCs.
> >
> > s/for the boards//
> >
> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Gr{oetje,eeting}s,
>
> Sergei has pointed out that bootargs has seems to have effect on ARM64
> kernels. So I think this patch should be withdrawn and we should consider
> removing bootargs from those ARM64 boards where it is present.
>
I don't think this is true.
I just added a argument to bootargs to salvator-common.dtsi for some
hack testing and it took effect. Tested on-top of latest renesas-drivers
and H3 ES2.0.
>>> DIFF <<<
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 7b30044a55367d35..4cb4b44f8be42cb4 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -42,7 +42,7 @@
};
chosen {
- bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
+ bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1";
stdout-path = "serial0:115200n8";
};
>>> END DIFF <<<
# cat /sys/firmware/devicetree/base/chosen/bootargs
ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1
And the module parameter had the expected effect on the adv7482x driver.
Is there another issue here which I'm missing?
--
Regards,
Niklas S?derlund
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
2017-11-30 12:52 ` Niklas Söderlund
@ 2017-11-30 13:45 ` Geert Uytterhoeven
-1 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2017-11-30 13:45 UTC (permalink / raw)
To: Niklas Söderlund
Cc: Simon Horman, Linux-Renesas, linux-arm-kernel, Magnus Damm
Hi Niklas,
On Thu, Nov 30, 2017 at 1:52 PM, Niklas Söderlund
<niklas.soderlund@ragnatech.se> wrote:
> On 2017-11-30 10:43:55 +0100, Simon Horman wrote:
>> On Tue, May 02, 2017 at 11:27:58AM +0200, Geert Uytterhoeven wrote:
>> > On Tue, May 2, 2017 at 11:24 AM, Simon Horman
>> > <horms+renesas@verge.net.au> wrote:
>> > > Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
>> > > as per:
>> > > * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
>> > > * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
>> > >
>> > > Also set ignore_loglevel rw as boot args as is the case for the boards
>> > > for the boards for other Renesas ARM/ARM64 based SoCs.
>> >
>> > s/for the boards//
>> >
>> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> >
>> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> >
>> > Gr{oetje,eeting}s,
>>
>> Sergei has pointed out that bootargs has seems to have effect on ARM64
>> kernels. So I think this patch should be withdrawn and we should consider
>> removing bootargs from those ARM64 boards where it is present.
>>
>
> I don't think this is true.
>
> I just added a argument to bootargs to salvator-common.dtsi for some
> hack testing and it took effect. Tested on-top of latest renesas-drivers
> and H3 ES2.0.
>
>>>> DIFF <<<
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index 7b30044a55367d35..4cb4b44f8be42cb4 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -42,7 +42,7 @@
> };
>
> chosen {
> - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
> + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1";
> stdout-path = "serial0:115200n8";
> };
>>>> END DIFF <<<
>
> # cat /sys/firmware/devicetree/base/chosen/bootargs
> ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1
>
> And the module parameter had the expected effect on the adv7482x driver.
> Is there another issue here which I'm missing?
1. It may depend on the U-Boot version
2. Anyone playing with CONFIG_CMDLINE and CONFIG_CMDLINE_FORCE?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
@ 2017-11-30 13:45 ` Geert Uytterhoeven
0 siblings, 0 replies; 12+ messages in thread
From: Geert Uytterhoeven @ 2017-11-30 13:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Niklas,
On Thu, Nov 30, 2017 at 1:52 PM, Niklas S?derlund
<niklas.soderlund@ragnatech.se> wrote:
> On 2017-11-30 10:43:55 +0100, Simon Horman wrote:
>> On Tue, May 02, 2017 at 11:27:58AM +0200, Geert Uytterhoeven wrote:
>> > On Tue, May 2, 2017 at 11:24 AM, Simon Horman
>> > <horms+renesas@verge.net.au> wrote:
>> > > Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
>> > > as per:
>> > > * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
>> > > * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
>> > >
>> > > Also set ignore_loglevel rw as boot args as is the case for the boards
>> > > for the boards for other Renesas ARM/ARM64 based SoCs.
>> >
>> > s/for the boards//
>> >
>> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>> >
>> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> >
>> > Gr{oetje,eeting}s,
>>
>> Sergei has pointed out that bootargs has seems to have effect on ARM64
>> kernels. So I think this patch should be withdrawn and we should consider
>> removing bootargs from those ARM64 boards where it is present.
>>
>
> I don't think this is true.
>
> I just added a argument to bootargs to salvator-common.dtsi for some
> hack testing and it took effect. Tested on-top of latest renesas-drivers
> and H3 ES2.0.
>
>>>> DIFF <<<
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index 7b30044a55367d35..4cb4b44f8be42cb4 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -42,7 +42,7 @@
> };
>
> chosen {
> - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
> + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1";
> stdout-path = "serial0:115200n8";
> };
>>>> END DIFF <<<
>
> # cat /sys/firmware/devicetree/base/chosen/bootargs
> ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1
>
> And the module parameter had the expected effect on the adv7482x driver.
> Is there another issue here which I'm missing?
1. It may depend on the U-Boot version
2. Anyone playing with CONFIG_CMDLINE and CONFIG_CMDLINE_FORCE?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
2017-11-30 13:45 ` Geert Uytterhoeven
@ 2017-11-30 19:57 ` Sergei Shtylyov
-1 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2017-11-30 19:57 UTC (permalink / raw)
To: Geert Uytterhoeven, Niklas Söderlund
Cc: Simon Horman, Linux-Renesas, linux-arm-kernel, Magnus Damm
On 11/30/2017 04:45 PM, Geert Uytterhoeven wrote:
>>>>> Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
>>>>> as per:
>>>>> * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
>>>>> * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
>>>>>
>>>>> Also set ignore_loglevel rw as boot args as is the case for the boards
>>>>> for the boards for other Renesas ARM/ARM64 based SoCs.
>>>>
>>>> s/for the boards//
>>>>
>>>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>>
>>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>
>>>> Gr{oetje,eeting}s,
>>>
>>> Sergei has pointed out that bootargs has seems to have effect on ARM64
>>> kernels. So I think this patch should be withdrawn and we should consider
>>> removing bootargs from those ARM64 boards where it is present.
>>>
>>
>> I don't think this is true.
>>
>> I just added a argument to bootargs to salvator-common.dtsi for some
>> hack testing and it took effect. Tested on-top of latest renesas-drivers
>> and H3 ES2.0.
>>
>>>>> DIFF <<<
>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> index 7b30044a55367d35..4cb4b44f8be42cb4 100644
>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> @@ -42,7 +42,7 @@
>> };
>>
>> chosen {
>> - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
>> + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1";
>> stdout-path = "serial0:115200n8";
>> };
>>>>> END DIFF <<<
>>
>> # cat /sys/firmware/devicetree/base/chosen/bootargs
>> ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1
>>
>> And the module parameter had the expected effect on the adv7482x driver.
>> Is there another issue here which I'm missing?
>
> 1. It may depend on the U-Boot version
It probably does! My U-Boot clearly copies its "bootargs" env. variable
into DT's "/chosen/bootargs" prop.
> 2. Anyone playing with CONFIG_CMDLINE and CONFIG_CMDLINE_FORCE?
Not me (before now). Tried it now and it works as expected.
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root
@ 2017-11-30 19:57 ` Sergei Shtylyov
0 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2017-11-30 19:57 UTC (permalink / raw)
To: linux-arm-kernel
On 11/30/2017 04:45 PM, Geert Uytterhoeven wrote:
>>>>> Enable NFS root on the r8a7795/h3ulcb and r8a7796/m3ulcb
>>>>> as per:
>>>>> * commit b2407c566ba29215 ("arm64: dts: r8a7795: enable nfs root on Salvator-X board").
>>>>> * commit 742a9dfb90f0 ("arm64: dts: r8a7796: salvator-x: Enable NFS root")
>>>>>
>>>>> Also set ignore_loglevel rw as boot args as is the case for the boards
>>>>> for the boards for other Renesas ARM/ARM64 based SoCs.
>>>>
>>>> s/for the boards//
>>>>
>>>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>>>>
>>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>>>>
>>>> Gr{oetje,eeting}s,
>>>
>>> Sergei has pointed out that bootargs has seems to have effect on ARM64
>>> kernels. So I think this patch should be withdrawn and we should consider
>>> removing bootargs from those ARM64 boards where it is present.
>>>
>>
>> I don't think this is true.
>>
>> I just added a argument to bootargs to salvator-common.dtsi for some
>> hack testing and it took effect. Tested on-top of latest renesas-drivers
>> and H3 ES2.0.
>>
>>>>> DIFF <<<
>> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> index 7b30044a55367d35..4cb4b44f8be42cb4 100644
>> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
>> @@ -42,7 +42,7 @@
>> };
>>
>> chosen {
>> - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
>> + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1";
>> stdout-path = "serial0:115200n8";
>> };
>>>>> END DIFF <<<
>>
>> # cat /sys/firmware/devicetree/base/chosen/bootargs
>> ignore_loglevel rw root=/dev/nfs ip=dhcp adv748x.txbvc=1
>>
>> And the module parameter had the expected effect on the adv7482x driver.
>> Is there another issue here which I'm missing?
>
> 1. It may depend on the U-Boot version
It probably does! My U-Boot clearly copies its "bootargs" env. variable
into DT's "/chosen/bootargs" prop.
> 2. Anyone playing with CONFIG_CMDLINE and CONFIG_CMDLINE_FORCE?
Not me (before now). Tried it now and it works as expected.
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-11-30 19:57 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 9:24 [PATCH/RFT renesas-devel] arm64: dts: ulcb: Enable NFS root Simon Horman
2017-05-02 9:24 ` Simon Horman
2017-05-02 9:27 ` Geert Uytterhoeven
2017-05-02 9:27 ` Geert Uytterhoeven
2017-11-30 9:43 ` Simon Horman
2017-11-30 9:43 ` Simon Horman
2017-11-30 12:52 ` Niklas Söderlund
2017-11-30 12:52 ` Niklas Söderlund
2017-11-30 13:45 ` Geert Uytterhoeven
2017-11-30 13:45 ` Geert Uytterhoeven
2017-11-30 19:57 ` Sergei Shtylyov
2017-11-30 19:57 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.