All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-pm@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org,
	"Antoine Tenart" <antoine.tenart@free-electrons.com>,
	"Miquèl Raynal" <miquel.raynal@free-electrons.com>,
	"Nadav Haklai" <nadavh@marvell.com>,
	"Victor Gu" <xigu@marvell.com>, "Marcin Wojtas" <mw@semihalf.com>,
	"Wilson Ding" <dingwei@marvell.com>,
	"Hua Jing" <jinghua@marvell.com>,
	"Neta Zur Hershkovits" <neta@marvell.com>,
	"Evan Wang" <xswang@marvell.com>
Subject: Re: [PATCH 3/6] cpufreq: sort the drivers in ARM part
Date: Mon, 4 Dec 2017 14:48:50 +0530	[thread overview]
Message-ID: <20171204091850.iamq5uslv3hv6bez@vireshk-mac-ubuntu> (raw)
In-Reply-To: <20171201112508.14121-4-gregory.clement@free-electrons.com>

On 01-12-17, 12:25, Gregory CLEMENT wrote:
> Keep the driver files alphabetically sorted.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/cpufreq/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 812f9e0d01a3..d762e76887e7 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -53,22 +53,24 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ)	+= arm_big_little.o
>  obj-$(CONFIG_ARM_DT_BL_CPUFREQ)		+= arm_big_little_dt.o
>  
>  obj-$(CONFIG_ARM_BRCMSTB_AVS_CPUFREQ)	+= brcmstb-avs-cpufreq.o
> +obj-$(CONFIG_ACPI_CPPC_CPUFREQ)		+= cppc_cpufreq.o

Shouldn't we add them in ascending order of the whole config name and not just
CPPC_CPUFREQ ?

-- 
viresh

WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] cpufreq: sort the drivers in ARM part
Date: Mon, 4 Dec 2017 14:48:50 +0530	[thread overview]
Message-ID: <20171204091850.iamq5uslv3hv6bez@vireshk-mac-ubuntu> (raw)
In-Reply-To: <20171201112508.14121-4-gregory.clement@free-electrons.com>

On 01-12-17, 12:25, Gregory CLEMENT wrote:
> Keep the driver files alphabetically sorted.
> 
> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/cpufreq/Makefile | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/cpufreq/Makefile b/drivers/cpufreq/Makefile
> index 812f9e0d01a3..d762e76887e7 100644
> --- a/drivers/cpufreq/Makefile
> +++ b/drivers/cpufreq/Makefile
> @@ -53,22 +53,24 @@ obj-$(CONFIG_ARM_BIG_LITTLE_CPUFREQ)	+= arm_big_little.o
>  obj-$(CONFIG_ARM_DT_BL_CPUFREQ)		+= arm_big_little_dt.o
>  
>  obj-$(CONFIG_ARM_BRCMSTB_AVS_CPUFREQ)	+= brcmstb-avs-cpufreq.o
> +obj-$(CONFIG_ACPI_CPPC_CPUFREQ)		+= cppc_cpufreq.o

Shouldn't we add them in ascending order of the whole config name and not just
CPPC_CPUFREQ ?

-- 
viresh

  reply	other threads:[~2017-12-04  9:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 11:25 [PATCH 0/6] Add CPU Frequency scaling support on Armada 37xx Gregory CLEMENT
2017-12-01 11:25 ` Gregory CLEMENT
2017-12-01 11:25 ` [PATCH 1/6] dt-bindings: marvell: Add documentation for the North Bridge PM " Gregory CLEMENT
2017-12-01 11:25   ` Gregory CLEMENT
2017-12-04 21:47   ` Rob Herring
2017-12-04 21:47     ` Rob Herring
2017-12-06 11:51     ` Gregory CLEMENT
2017-12-06 11:51       ` Gregory CLEMENT
2017-12-01 11:25 ` [PATCH 2/6] cpufreq: ARM: sort the Kconfig menu Gregory CLEMENT
2017-12-01 11:25   ` Gregory CLEMENT
2017-12-04  8:41   ` Viresh Kumar
2017-12-04  8:41     ` Viresh Kumar
2017-12-06 11:52     ` Gregory CLEMENT
2017-12-06 11:52       ` Gregory CLEMENT
2017-12-01 11:25 ` [PATCH 3/6] cpufreq: sort the drivers in ARM part Gregory CLEMENT
2017-12-01 11:25   ` Gregory CLEMENT
2017-12-04  9:18   ` Viresh Kumar [this message]
2017-12-04  9:18     ` Viresh Kumar
2017-12-06 12:09     ` Gregory CLEMENT
2017-12-06 12:09       ` Gregory CLEMENT
     [not found] ` <20171201112508.14121-1-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2017-12-01 11:25   ` [PATCH 4/6] MAINTAINERS: add new entries for Armada 37xx cpufreq driver Gregory CLEMENT
2017-12-01 11:25     ` Gregory CLEMENT
2017-12-01 11:25 ` [PATCH 5/6] cpufreq: Add DVFS support for Armada 37xx Gregory CLEMENT
2017-12-01 11:25   ` Gregory CLEMENT
2017-12-05  5:54   ` Viresh Kumar
2017-12-05  5:54     ` Viresh Kumar
2017-12-06 12:24     ` Gregory CLEMENT
2017-12-06 12:24       ` Gregory CLEMENT
2017-12-01 11:25 ` [PATCH 6/6] arm64: dts: marvell: armada-37xx: add nodes allowing cpufreq support Gregory CLEMENT
2017-12-01 11:25   ` Gregory CLEMENT
2017-12-03 12:23 ` [PATCH 0/6] Add CPU Frequency scaling support on Armada 37xx Andre Heider
2017-12-06 11:50   ` Gregory CLEMENT
2017-12-06 14:08     ` Andre Heider
2017-12-18 17:03       ` Gregory CLEMENT
2017-12-21  7:45         ` Andre Heider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204091850.iamq5uslv3hv6bez@vireshk-mac-ubuntu \
    --to=viresh.kumar@linaro.org \
    --cc=andrew@lunn.ch \
    --cc=antoine.tenart@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dingwei@marvell.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=jason@lakedaemon.net \
    --cc=jinghua@marvell.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=miquel.raynal@free-electrons.com \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=neta@marvell.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=xigu@marvell.com \
    --cc=xswang@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.