From: Jacob Pan <jacob.jun.pan@linux.intel.com> To: Jean-Philippe Brucker <jean-philippe.brucker@arm.com> Cc: "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>, LKML <linux-kernel@vger.kernel.org>, Joerg Roedel <joro@8bytes.org>, David Woodhouse <dwmw2@infradead.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Rafael Wysocki <rafael.j.wysocki@intel.com>, Alex Williamson <alex.williamson@redhat.com>, Lan Tianyu <tianyu.lan@intel.com>, Jean Delvare <khali@linux-fr.org>, jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v3 15/16] iommu: introduce page response function Date: Mon, 4 Dec 2017 13:37:15 -0800 [thread overview] Message-ID: <20171204133715.50c45136@jacob-builder> (raw) In-Reply-To: <93661c1c-2d3b-295f-0b9d-52e50ea9e1d0@arm.com> On Fri, 24 Nov 2017 12:03:50 +0000 Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote: > On 17/11/17 18:55, Jacob Pan wrote: > > When nested translation is turned on and guest owns the > > first level page tables, device page request can be forwared > > to the guest for handling faults. As the page response returns > > by the guest, IOMMU driver on the host need to process the > > response which informs the device and completes the page request > > transaction. > > > > This patch introduces generic API function for page response > > passing from the guest or other in-kernel users. The definitions of > > the generic data is based on PCI ATS specification not limited to > > any vendor.> > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > > --- > > drivers/iommu/iommu.c | 14 ++++++++++++++ > > include/linux/iommu.h | 42 > > ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 56 > > insertions(+) > > > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > > index 97b7990..7aefb40 100644 > > --- a/drivers/iommu/iommu.c > > +++ b/drivers/iommu/iommu.c > > @@ -1416,6 +1416,20 @@ int iommu_sva_invalidate(struct iommu_domain > > *domain, } > > EXPORT_SYMBOL_GPL(iommu_sva_invalidate); > > > > +int iommu_page_response(struct iommu_domain *domain, struct device > > *dev, > > + struct page_response_msg *msg) > > I think it's simpler, both for IOMMU and device drivers, to pass the > exact structure received in the fault handler back to the IOMMU > driver, along with a separate response status. So maybe > > int iommu_page_response(struct iommu_domain *domain, struct device > *dev, struct iommu_fault_event *event, u32 response) > > And then you'd just need to define the IOMMU_PAGE_RESPONSE_* values. > Apologize for the late response, I think the simpler interface works for in-kernel driver use case very well. But in case of VFIO, the callback function does not turn around send back page response. The page response comes from guest and qemu, where they don;t keep track of the the prq event data. > Thanks, > Jean [Jacob Pan]
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> To: Jean-Philippe Brucker <jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> Cc: Lan Tianyu <tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>, Rafael Wysocki <rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" <iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>, David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Subject: Re: [PATCH v3 15/16] iommu: introduce page response function Date: Mon, 4 Dec 2017 13:37:15 -0800 [thread overview] Message-ID: <20171204133715.50c45136@jacob-builder> (raw) In-Reply-To: <93661c1c-2d3b-295f-0b9d-52e50ea9e1d0-5wv7dgnIgG8@public.gmane.org> On Fri, 24 Nov 2017 12:03:50 +0000 Jean-Philippe Brucker <jean-philippe.brucker-5wv7dgnIgG8@public.gmane.org> wrote: > On 17/11/17 18:55, Jacob Pan wrote: > > When nested translation is turned on and guest owns the > > first level page tables, device page request can be forwared > > to the guest for handling faults. As the page response returns > > by the guest, IOMMU driver on the host need to process the > > response which informs the device and completes the page request > > transaction. > > > > This patch introduces generic API function for page response > > passing from the guest or other in-kernel users. The definitions of > > the generic data is based on PCI ATS specification not limited to > > any vendor.> > > Signed-off-by: Jacob Pan <jacob.jun.pan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> > > --- > > drivers/iommu/iommu.c | 14 ++++++++++++++ > > include/linux/iommu.h | 42 > > ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 56 > > insertions(+) > > > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > > index 97b7990..7aefb40 100644 > > --- a/drivers/iommu/iommu.c > > +++ b/drivers/iommu/iommu.c > > @@ -1416,6 +1416,20 @@ int iommu_sva_invalidate(struct iommu_domain > > *domain, } > > EXPORT_SYMBOL_GPL(iommu_sva_invalidate); > > > > +int iommu_page_response(struct iommu_domain *domain, struct device > > *dev, > > + struct page_response_msg *msg) > > I think it's simpler, both for IOMMU and device drivers, to pass the > exact structure received in the fault handler back to the IOMMU > driver, along with a separate response status. So maybe > > int iommu_page_response(struct iommu_domain *domain, struct device > *dev, struct iommu_fault_event *event, u32 response) > > And then you'd just need to define the IOMMU_PAGE_RESPONSE_* values. > Apologize for the late response, I think the simpler interface works for in-kernel driver use case very well. But in case of VFIO, the callback function does not turn around send back page response. The page response comes from guest and qemu, where they don;t keep track of the the prq event data. > Thanks, > Jean [Jacob Pan]
next prev parent reply other threads:[~2017-12-04 21:36 UTC|newest] Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-17 18:54 [PATCH v3 00/16] [PATCH v3 00/16] IOMMU driver support for SVM virtualization Jacob Pan 2017-11-17 18:54 ` Jacob Pan 2017-11-17 18:54 ` [PATCH v3 01/16] iommu: introduce bind_pasid_table API function Jacob Pan 2017-11-17 18:54 ` Jacob Pan 2017-11-24 12:04 ` Jean-Philippe Brucker 2017-11-29 22:01 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 02/16] iommu/vt-d: add bind_pasid_table function Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 03/16] iommu: introduce iommu invalidate API function Jacob Pan 2017-11-24 12:04 ` Jean-Philippe Brucker 2017-12-15 19:02 ` Jean-Philippe Brucker 2017-12-15 19:02 ` Jean-Philippe Brucker 2017-12-28 19:25 ` Jacob Pan 2017-12-28 19:25 ` Jacob Pan 2018-01-10 12:00 ` Jean-Philippe Brucker 2018-01-10 12:00 ` Jean-Philippe Brucker 2017-11-17 18:55 ` [PATCH v3 04/16] iommu/vt-d: move device_domain_info to header Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 05/16] iommu/vt-d: support flushing more TLB types Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-11-20 14:20 ` Lukoshkov, Maksim 2017-11-20 14:20 ` Lukoshkov, Maksim 2017-11-20 18:40 ` Jacob Pan 2017-11-20 18:40 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 06/16] iommu/vt-d: add svm/sva invalidate function Jacob Pan 2017-12-05 5:43 ` Lu Baolu 2017-12-05 5:43 ` Lu Baolu 2017-11-17 18:55 ` [PATCH v3 07/16] iommu/vt-d: assign PFSID in device TLB invalidation Jacob Pan 2017-12-05 5:45 ` Lu Baolu 2017-11-17 18:55 ` [PATCH v3 08/16] iommu: introduce device fault data Jacob Pan 2017-11-24 12:03 ` Jean-Philippe Brucker 2017-11-29 21:55 ` Jacob Pan 2017-11-29 21:55 ` Jacob Pan 2018-01-10 11:41 ` Jean-Philippe Brucker 2018-01-11 21:10 ` Jacob Pan 2018-01-11 21:10 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 09/16] driver core: add iommu device fault reporting data Jacob Pan 2017-12-18 14:37 ` Greg Kroah-Hartman 2017-12-18 14:37 ` Greg Kroah-Hartman 2017-11-17 18:55 ` [PATCH v3 10/16] iommu: introduce device fault report API Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-12-05 6:22 ` Lu Baolu 2017-12-08 21:22 ` Jacob Pan 2017-12-08 21:22 ` Jacob Pan 2017-12-07 21:27 ` Alex Williamson 2017-12-07 21:27 ` Alex Williamson 2017-12-08 20:23 ` Jacob Pan 2017-12-08 20:23 ` Jacob Pan 2017-12-08 20:59 ` Alex Williamson 2017-12-08 20:59 ` Alex Williamson 2017-12-08 21:22 ` Jacob Pan 2017-12-08 21:22 ` Jacob Pan 2018-01-10 12:39 ` Jean-Philippe Brucker 2018-01-18 19:24 ` Jean-Philippe Brucker 2018-01-23 20:01 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 11/16] iommu/vt-d: use threaded irq for dmar_fault Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 12/16] iommu/vt-d: report unrecoverable device faults Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-12-05 6:34 ` Lu Baolu 2017-12-05 6:34 ` Lu Baolu 2017-11-17 18:55 ` [PATCH v3 13/16] iommu/intel-svm: notify page request to guest Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-12-05 7:37 ` Lu Baolu 2017-12-05 7:37 ` Lu Baolu 2017-11-17 18:55 ` [PATCH v3 14/16] iommu/intel-svm: replace dev ops with fault report API Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-11-17 18:55 ` [PATCH v3 15/16] iommu: introduce page response function Jacob Pan 2017-11-17 18:55 ` Jacob Pan 2017-11-24 12:03 ` Jean-Philippe Brucker 2017-12-04 21:37 ` Jacob Pan [this message] 2017-12-04 21:37 ` Jacob Pan 2017-12-05 17:21 ` Jean-Philippe Brucker 2017-12-05 17:21 ` Jean-Philippe Brucker 2017-12-06 19:25 ` Jacob Pan 2017-12-06 19:25 ` Jacob Pan 2017-12-07 12:56 ` Jean-Philippe Brucker 2017-12-07 12:56 ` Jean-Philippe Brucker 2017-12-07 21:56 ` Alex Williamson 2017-12-08 13:51 ` Jean-Philippe Brucker 2017-12-08 13:51 ` Jean-Philippe Brucker 2017-12-08 1:17 ` Jacob Pan 2017-12-08 1:17 ` Jacob Pan 2017-12-08 13:51 ` Jean-Philippe Brucker 2017-12-08 13:51 ` Jean-Philippe Brucker 2017-12-07 21:51 ` Alex Williamson 2017-12-07 21:51 ` Alex Williamson 2017-12-08 13:52 ` Jean-Philippe Brucker 2017-12-08 20:40 ` Jacob Pan 2017-12-08 20:40 ` Jacob Pan 2017-12-08 23:01 ` Alex Williamson 2017-12-08 23:01 ` Alex Williamson 2017-11-17 18:55 ` [PATCH v3 16/16] iommu/vt-d: add intel iommu " Jacob Pan 2017-11-17 18:55 ` Jacob Pan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171204133715.50c45136@jacob-builder \ --to=jacob.jun.pan@linux.intel.com \ --cc=alex.williamson@redhat.com \ --cc=dwmw2@infradead.org \ --cc=gregkh@linuxfoundation.org \ --cc=iommu@lists.linux-foundation.org \ --cc=jean-philippe.brucker@arm.com \ --cc=joro@8bytes.org \ --cc=khali@linux-fr.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rafael.j.wysocki@intel.com \ --cc=tianyu.lan@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.