From: Christoffer Dall <cdall@kernel.org> To: kvmarm@lists.cs.columbia.edu Cc: kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>, Andre Przywara <andre.przywara@arm.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 1/8] KVM: arm/arm64: Remove redundant preemptible checks Date: Mon, 4 Dec 2017 21:04:59 +0100 [thread overview] Message-ID: <20171204200506.3224-2-cdall@kernel.org> (raw) In-Reply-To: <20171204200506.3224-1-cdall@kernel.org> From: Christoffer Dall <christoffer.dall@linaro.org> The __this_cpu_read() and __this_cpu_write() functions already implement checks for the required preemption levels when using CONFIG_DEBUG_PREEMPT which gives you nice error messages and such. Therefore there is no need to explicitly check this using a BUG_ON() in the code (which we don't do for other uses of per cpu variables either). Acked-by: Marc Zyngier <marc.zyngier@arm.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> --- virt/kvm/arm/arm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index a6524ff27de4..859ff7e3a1eb 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -71,7 +71,6 @@ static DEFINE_PER_CPU(unsigned char, kvm_arm_hardware_enabled); static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) { - BUG_ON(preemptible()); __this_cpu_write(kvm_arm_running_vcpu, vcpu); } @@ -81,7 +80,6 @@ static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) */ struct kvm_vcpu *kvm_arm_get_running_vcpu(void) { - BUG_ON(preemptible()); return __this_cpu_read(kvm_arm_running_vcpu); } -- 2.14.2
WARNING: multiple messages have this Message-ID (diff)
From: cdall@kernel.org (Christoffer Dall) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v6 1/8] KVM: arm/arm64: Remove redundant preemptible checks Date: Mon, 4 Dec 2017 21:04:59 +0100 [thread overview] Message-ID: <20171204200506.3224-2-cdall@kernel.org> (raw) In-Reply-To: <20171204200506.3224-1-cdall@kernel.org> From: Christoffer Dall <christoffer.dall@linaro.org> The __this_cpu_read() and __this_cpu_write() functions already implement checks for the required preemption levels when using CONFIG_DEBUG_PREEMPT which gives you nice error messages and such. Therefore there is no need to explicitly check this using a BUG_ON() in the code (which we don't do for other uses of per cpu variables either). Acked-by: Marc Zyngier <marc.zyngier@arm.com> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org> --- virt/kvm/arm/arm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index a6524ff27de4..859ff7e3a1eb 100644 --- a/virt/kvm/arm/arm.c +++ b/virt/kvm/arm/arm.c @@ -71,7 +71,6 @@ static DEFINE_PER_CPU(unsigned char, kvm_arm_hardware_enabled); static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) { - BUG_ON(preemptible()); __this_cpu_write(kvm_arm_running_vcpu, vcpu); } @@ -81,7 +80,6 @@ static void kvm_arm_set_running_vcpu(struct kvm_vcpu *vcpu) */ struct kvm_vcpu *kvm_arm_get_running_vcpu(void) { - BUG_ON(preemptible()); return __this_cpu_read(kvm_arm_running_vcpu); } -- 2.14.2
next prev parent reply other threads:[~2017-12-04 20:04 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-04 20:04 [PATCH v6 0/8] Handle forwarded level-triggered interrupts Christoffer Dall 2017-12-04 20:04 ` Christoffer Dall 2017-12-04 20:04 ` Christoffer Dall [this message] 2017-12-04 20:04 ` [PATCH v6 1/8] KVM: arm/arm64: Remove redundant preemptible checks Christoffer Dall 2017-12-04 20:05 ` [PATCH v6 2/8] KVM: arm/arm64: Factor out functionality to get vgic mmio requester_vcpu Christoffer Dall 2017-12-04 20:05 ` Christoffer Dall 2017-12-05 13:46 ` Yury Norov 2017-12-05 13:46 ` Yury Norov 2017-12-06 10:54 ` Christoffer Dall 2017-12-06 10:54 ` Christoffer Dall 2017-12-04 20:05 ` [PATCH v6 3/8] KVM: arm/arm64: Don't cache the timer IRQ level Christoffer Dall 2017-12-04 20:05 ` Christoffer Dall 2017-12-04 20:05 ` [PATCH v6 4/8] KVM: arm/arm64: vgic: Support level-triggered mapped interrupts Christoffer Dall 2017-12-04 20:05 ` Christoffer Dall 2017-12-04 20:05 ` [PATCH v6 5/8] KVM: arm/arm64: Support a vgic interrupt line level sample function Christoffer Dall 2017-12-04 20:05 ` Christoffer Dall 2017-12-04 20:05 ` [PATCH v6 6/8] KVM: arm/arm64: Support VGIC dist pend/active changes for mapped IRQs Christoffer Dall 2017-12-04 20:05 ` Christoffer Dall 2017-12-05 12:43 ` Andrew Jones 2017-12-05 12:43 ` Andrew Jones 2017-12-05 15:03 ` Yury Norov 2017-12-05 15:03 ` Yury Norov 2017-12-05 16:47 ` Marc Zyngier 2017-12-05 16:47 ` Marc Zyngier 2017-12-05 22:39 ` Yury Norov 2017-12-05 22:39 ` Yury Norov 2017-12-06 8:56 ` Marc Zyngier 2017-12-06 8:56 ` Marc Zyngier 2017-12-04 20:05 ` [PATCH v6 7/8] KVM: arm/arm64: Provide a get_input_level for the arch timer Christoffer Dall 2017-12-04 20:05 ` Christoffer Dall 2017-12-05 15:24 ` Yury Norov 2017-12-05 15:24 ` Yury Norov 2017-12-06 10:59 ` Christoffer Dall 2017-12-06 10:59 ` Christoffer Dall 2017-12-06 14:17 ` Yury Norov 2017-12-06 14:17 ` Yury Norov 2017-12-06 16:38 ` Christoffer Dall 2017-12-06 16:38 ` Christoffer Dall 2017-12-04 20:05 ` [PATCH v6 8/8] KVM: arm/arm64: Avoid work when userspace iqchips are not used Christoffer Dall 2017-12-04 20:05 ` Christoffer Dall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171204200506.3224-2-cdall@kernel.org \ --to=cdall@kernel.org \ --cc=andre.przywara@arm.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.