All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] sunxi: Fix UART console index for A33-OLinuXino
@ 2017-12-05  6:00 Chen-Yu Tsai
  2017-12-05  9:41 ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2017-12-05  6:00 UTC (permalink / raw)
  To: u-boot

The A33-OLinuXino defconfig was using the default CONS_INDEX value for
A33, which actually points to the R_UART, which is routed to the GPIO
header without proper pull-ups or diodes. The board has a separate
header for UART0, which are routed to pins PB0 and PB1. This header
is properly marked and is likely the first pins any user would try
to get a console.

Fix CONS_INDEX in the defconfig so the console appears on UART0.

Fixes: ca5c37026be4 ("sunxi: Add support for A33-OLinuXino board")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 configs/A33-OLinuXino_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/A33-OLinuXino_defconfig b/configs/A33-OLinuXino_defconfig
index c11991de7e5a..894bb19cf0bd 100644
--- a/configs/A33-OLinuXino_defconfig
+++ b/configs/A33-OLinuXino_defconfig
@@ -1,5 +1,6 @@
 CONFIG_ARM=y
 CONFIG_ARCH_SUNXI=y
+CONFIG_CONS_INDEX=1
 CONFIG_MACH_SUN8I_A33=y
 CONFIG_DRAM_CLK=432
 CONFIG_DRAM_ZQ=15291
-- 
2.15.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] sunxi: Fix UART console index for A33-OLinuXino
  2017-12-05  6:00 [U-Boot] [PATCH] sunxi: Fix UART console index for A33-OLinuXino Chen-Yu Tsai
@ 2017-12-05  9:41 ` Maxime Ripard
  2017-12-07  5:38   ` Jagan Teki
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2017-12-05  9:41 UTC (permalink / raw)
  To: u-boot

On Tue, Dec 05, 2017 at 02:00:07PM +0800, Chen-Yu Tsai wrote:
> The A33-OLinuXino defconfig was using the default CONS_INDEX value for
> A33, which actually points to the R_UART, which is routed to the GPIO
> header without proper pull-ups or diodes. The board has a separate
> header for UART0, which are routed to pins PB0 and PB1. This header
> is properly marked and is likely the first pins any user would try
> to get a console.
> 
> Fix CONS_INDEX in the defconfig so the console appears on UART0.
> 
> Fixes: ca5c37026be4 ("sunxi: Add support for A33-OLinuXino board")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20171205/3508747b/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] sunxi: Fix UART console index for A33-OLinuXino
  2017-12-05  9:41 ` Maxime Ripard
@ 2017-12-07  5:38   ` Jagan Teki
  0 siblings, 0 replies; 3+ messages in thread
From: Jagan Teki @ 2017-12-07  5:38 UTC (permalink / raw)
  To: u-boot

On Tue, Dec 5, 2017 at 3:11 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Tue, Dec 05, 2017 at 02:00:07PM +0800, Chen-Yu Tsai wrote:
>> The A33-OLinuXino defconfig was using the default CONS_INDEX value for
>> A33, which actually points to the R_UART, which is routed to the GPIO
>> header without proper pull-ups or diodes. The board has a separate
>> header for UART0, which are routed to pins PB0 and PB1. This header
>> is properly marked and is likely the first pins any user would try
>> to get a console.
>>
>> Fix CONS_INDEX in the defconfig so the console appears on UART0.
>>
>> Fixes: ca5c37026be4 ("sunxi: Add support for A33-OLinuXino board")
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>

Applied to u-boot-sunxi/master

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-12-07  5:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-05  6:00 [U-Boot] [PATCH] sunxi: Fix UART console index for A33-OLinuXino Chen-Yu Tsai
2017-12-05  9:41 ` Maxime Ripard
2017-12-07  5:38   ` Jagan Teki

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.