* [PATCH] crypto: exynos - Icrease the priority of the driver
[not found] <CGME20171205162048eucas1p241590a1f62f8c49af8a7fb9282daed80@eucas1p2.samsung.com>
@ 2017-12-05 16:20 ` Łukasz Stelmach
2017-12-05 16:31 ` Stephan Mueller
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Łukasz Stelmach @ 2017-12-05 16:20 UTC (permalink / raw)
To: Krzysztof Kozlowski, robh+dt, Stephan Mueller, Herbert Xu,
David S. Miller, Kukjin Kim, linux-crypto, linux-samsung-soc,
linux-kernel
Cc: Łukasz Stelmach, m.szyprowski, b.zolnierkie
exynos-rng is one of many implementations of stdrng. With priority as
low as 100 it isn't selected, if software implementations (DRBG) are
available. The value 300 was selected to give the PRNG priority before
software implementations, but allow them to be selected in FIPS-mode
(fips=1 in the kernel command line).
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
Thank you Stephan Mueller for explanations.
drivers/crypto/exynos-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/exynos-rng.c b/drivers/crypto/exynos-rng.c
index 4b2ed1d178af..5a37397fb1c5 100644
--- a/drivers/crypto/exynos-rng.c
+++ b/drivers/crypto/exynos-rng.c
@@ -256,7 +256,7 @@ static struct rng_alg exynos_rng_alg = {
.base = {
.cra_name = "stdrng",
.cra_driver_name = "exynos_rng",
- .cra_priority = 100,
+ .cra_priority = 300,
.cra_ctxsize = sizeof(struct exynos_rng_ctx),
.cra_module = THIS_MODULE,
.cra_init = exynos_rng_kcapi_init,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: exynos - Icrease the priority of the driver
2017-12-05 16:20 ` [PATCH] crypto: exynos - Icrease the priority of the driver Łukasz Stelmach
@ 2017-12-05 16:31 ` Stephan Mueller
2017-12-05 17:55 ` Krzysztof Kozlowski
2017-12-22 8:38 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Stephan Mueller @ 2017-12-05 16:31 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Krzysztof Kozlowski, robh+dt, Herbert Xu, David S. Miller,
Kukjin Kim, linux-crypto, linux-samsung-soc, linux-kernel,
m.szyprowski, b.zolnierkie
Am Dienstag, 5. Dezember 2017, 17:20:46 CET schrieb Łukasz Stelmach:
Hi Łukasz,
> exynos-rng is one of many implementations of stdrng. With priority as
> low as 100 it isn't selected, if software implementations (DRBG) are
> available. The value 300 was selected to give the PRNG priority before
> software implementations, but allow them to be selected in FIPS-mode
> (fips=1 in the kernel command line).
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Reviewed-by: Stephan Mueller <smueller@chronox.de>
Ciao
Stephan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: exynos - Icrease the priority of the driver
2017-12-05 16:20 ` [PATCH] crypto: exynos - Icrease the priority of the driver Łukasz Stelmach
2017-12-05 16:31 ` Stephan Mueller
@ 2017-12-05 17:55 ` Krzysztof Kozlowski
2017-12-22 8:38 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2017-12-05 17:55 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: robh+dt, Stephan Mueller, Herbert Xu, David S. Miller,
Kukjin Kim, linux-crypto, linux-samsung-soc, linux-kernel,
m.szyprowski, b.zolnierkie
On Tue, Dec 05, 2017 at 05:20:46PM +0100, Łukasz Stelmach wrote:
> exynos-rng is one of many implementations of stdrng. With priority as
> low as 100 it isn't selected, if software implementations (DRBG) are
> available. The value 300 was selected to give the PRNG priority before
> software implementations, but allow them to be selected in FIPS-mode
> (fips=1 in the kernel command line).
Typo in subject ("Increase").
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: exynos - Icrease the priority of the driver
2017-12-05 16:20 ` [PATCH] crypto: exynos - Icrease the priority of the driver Łukasz Stelmach
2017-12-05 16:31 ` Stephan Mueller
2017-12-05 17:55 ` Krzysztof Kozlowski
@ 2017-12-22 8:38 ` Herbert Xu
2 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2017-12-22 8:38 UTC (permalink / raw)
To: Łukasz Stelmach
Cc: Krzysztof Kozlowski, robh+dt, Stephan Mueller, David S. Miller,
Kukjin Kim, linux-crypto, linux-samsung-soc, linux-kernel,
m.szyprowski, b.zolnierkie
On Tue, Dec 05, 2017 at 05:20:46PM +0100, Łukasz Stelmach wrote:
> exynos-rng is one of many implementations of stdrng. With priority as
> low as 100 it isn't selected, if software implementations (DRBG) are
> available. The value 300 was selected to give the PRNG priority before
> software implementations, but allow them to be selected in FIPS-mode
> (fips=1 in the kernel command line).
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-22 8:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171205162048eucas1p241590a1f62f8c49af8a7fb9282daed80@eucas1p2.samsung.com>
2017-12-05 16:20 ` [PATCH] crypto: exynos - Icrease the priority of the driver Łukasz Stelmach
2017-12-05 16:31 ` Stephan Mueller
2017-12-05 17:55 ` Krzysztof Kozlowski
2017-12-22 8:38 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.