* [PATCH resend] Fix grub-mkconfig detecting .sig files as system images
@ 2017-11-29 13:35 Jordan Glover
2017-11-30 12:55 ` Daniel Kiper
0 siblings, 1 reply; 3+ messages in thread
From: Jordan Glover @ 2017-11-29 13:35 UTC (permalink / raw)
To: The development of GNU GRUB, daniel.kiper
[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]
grub-mkconfig detects detached RSA signatures for kernel images used for signature checking as valid images and adds them to grub.cfg
as separate menuentries. This patch adds .sig extension to common blacklist.
Signed-off-by: Jordan Glover <Golden_Miller83@protonmail.ch>
---
util/grub-mkconfig_lib.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in
index 60b31ca..0f801ca 100644
--- a/util/grub-mkconfig_lib.in
+++ b/util/grub-mkconfig_lib.in
@@ -188,6 +188,7 @@ grub_file_is_not_garbage ()
*.dpkg-*) return 1 ;; # debian dpkg
*.rpmsave|*.rpmnew) return 1 ;;
README*|*/README*) return 1 ;; # documentation
+ *.sig) return 1 ;; # signatures
esac
else
return 1
--
2.15.0
[-- Attachment #1.2: Type: text/html, Size: 1042 bytes --]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: grub-mkconfig-add-.sig-files-to-garbage-blacklist.patch --]
[-- Type: text/x-patch; name="grub-mkconfig-add-.sig-files-to-garbage-blacklist.patch", Size: 1001 bytes --]
From cbb9d14dd5328d29decaa2b057cba1593742b6b2 Mon Sep 17 00:00:00 2001
From: Jordan Glover <Golden_Miller83@protonmail.ch>
Date: Wed, 1 Nov 2017 19:45:52 +0100
Subject: [PATCH] grub-mkconfig: add .sig files to garbage blacklist
grub-mkconfig detects detached RSA signatures for kernel images used for signature checking as valid images and adds them to grub.cfg
as separete menuentries. This patch adds .sig extension to common blacklist.
Signed-off-by: Jordan Glover <Golden_Miller83@protonmail.ch>
---
util/grub-mkconfig_lib.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/grub-mkconfig_lib.in b/util/grub-mkconfig_lib.in
index 60b31ca..0f801ca 100644
--- a/util/grub-mkconfig_lib.in
+++ b/util/grub-mkconfig_lib.in
@@ -188,6 +188,7 @@ grub_file_is_not_garbage ()
*.dpkg-*) return 1 ;; # debian dpkg
*.rpmsave|*.rpmnew) return 1 ;;
README*|*/README*) return 1 ;; # documentation
+ *.sig) return 1 ;; # signatures
esac
else
return 1
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH resend] Fix grub-mkconfig detecting .sig files as system images
2017-11-29 13:35 [PATCH resend] Fix grub-mkconfig detecting .sig files as system images Jordan Glover
@ 2017-11-30 12:55 ` Daniel Kiper
2017-12-06 12:15 ` Daniel Kiper
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Kiper @ 2017-11-30 12:55 UTC (permalink / raw)
To: Jordan Glover; +Cc: The development of GNU GRUB
On Wed, Nov 29, 2017 at 08:35:37AM -0500, Jordan Glover wrote:
> grub-mkconfig detects detached RSA signatures for kernel images used for signature checking as valid images and adds them to grub.cfg
> as separate menuentries. This patch adds .sig extension to common blacklist.
>
> Signed-off-by: Jordan Glover <Golden_Miller83@protonmail.ch>
LGTM, I will apply this next week.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH resend] Fix grub-mkconfig detecting .sig files as system images
2017-11-30 12:55 ` Daniel Kiper
@ 2017-12-06 12:15 ` Daniel Kiper
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Kiper @ 2017-12-06 12:15 UTC (permalink / raw)
To: Jordan Glover; +Cc: The development of GNU GRUB
On Thu, Nov 30, 2017 at 01:55:52PM +0100, Daniel Kiper wrote:
> On Wed, Nov 29, 2017 at 08:35:37AM -0500, Jordan Glover wrote:
> > grub-mkconfig detects detached RSA signatures for kernel images used for signature checking as valid images and adds them to grub.cfg
> > as separate menuentries. This patch adds .sig extension to common blacklist.
> >
> > Signed-off-by: Jordan Glover <Golden_Miller83@protonmail.ch>
>
> LGTM, I will apply this next week.
Pushed!
Thanks,
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-06 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-29 13:35 [PATCH resend] Fix grub-mkconfig detecting .sig files as system images Jordan Glover
2017-11-30 12:55 ` Daniel Kiper
2017-12-06 12:15 ` Daniel Kiper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.