* [PATCH 1/2] libxslt: use HTTP instead of FTP in SRC_URI
@ 2017-12-06 14:59 Ross Burton
2017-12-06 14:59 ` [PATCH 2/2] libxslt: remove inappropriate patch Ross Burton
2017-12-06 15:02 ` ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more Patchwork
0 siblings, 2 replies; 6+ messages in thread
From: Ross Burton @ 2017-12-06 14:59 UTC (permalink / raw)
To: openembedded-core
FTP isn't as reliable as HTTP.
[ YOCTO #12398 ]
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
meta/recipes-support/libxslt/libxslt_1.1.32.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-support/libxslt/libxslt_1.1.32.bb b/meta/recipes-support/libxslt/libxslt_1.1.32.bb
index e8b1409d79b..b8951ab3a8b 100644
--- a/meta/recipes-support/libxslt/libxslt_1.1.32.bb
+++ b/meta/recipes-support/libxslt/libxslt_1.1.32.bb
@@ -8,7 +8,7 @@ LIC_FILES_CHKSUM = "file://Copyright;md5=0cd9a07afbeb24026c9b03aecfeba458"
SECTION = "libs"
DEPENDS = "libxml2"
-SRC_URI = "ftp://xmlsoft.org/libxslt/libxslt-${PV}.tar.gz \
+SRC_URI = "http://xmlsoft.org/sources/libxslt-${PV}.tar.gz \
file://pkgconfig_fix.patch \
"
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] libxslt: remove inappropriate patch
2017-12-06 14:59 [PATCH 1/2] libxslt: use HTTP instead of FTP in SRC_URI Ross Burton
@ 2017-12-06 14:59 ` Ross Burton
2017-12-06 15:02 ` ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more Patchwork
1 sibling, 0 replies; 6+ messages in thread
From: Ross Burton @ 2017-12-06 14:59 UTC (permalink / raw)
To: openembedded-core
This was patching -lxslt directly into the pkgconfig file, but XSLT_LIBS already
contains this so the patch is redundant.
Signed-off-by: Ross Burton <ross.burton@intel.com>
---
.../libxslt/libxslt/pkgconfig_fix.patch | 24 ----------------------
meta/recipes-support/libxslt/libxslt_1.1.32.bb | 5 +----
2 files changed, 1 insertion(+), 28 deletions(-)
delete mode 100644 meta/recipes-support/libxslt/libxslt/pkgconfig_fix.patch
diff --git a/meta/recipes-support/libxslt/libxslt/pkgconfig_fix.patch b/meta/recipes-support/libxslt/libxslt/pkgconfig_fix.patch
deleted file mode 100644
index 16a801010ca..00000000000
--- a/meta/recipes-support/libxslt/libxslt/pkgconfig_fix.patch
+++ /dev/null
@@ -1,24 +0,0 @@
-Upstream-Status: Inappropriate [configuration]
-
-Index: libxslt-1.1.27/libexslt.pc.in
-===================================================================
---- libxslt-1.1.27.orig/libexslt.pc.in
-+++ libxslt-1.1.27/libexslt.pc.in
-@@ -8,5 +8,5 @@ Name: libexslt
- Version: @LIBEXSLT_VERSION@
- Description: EXSLT Extension library
- Requires: libxml-2.0
--Libs: @EXSLT_LIBDIR@ @EXSLT_LIBS@
-+Libs: -lexslt @EXSLT_LIBDIR@ @EXSLT_LIBS@
- Cflags: @EXSLT_INCLUDEDIR@
-Index: libxslt-1.1.27/libxslt.pc.in
-===================================================================
---- libxslt-1.1.27.orig/libxslt.pc.in
-+++ libxslt-1.1.27/libxslt.pc.in
-@@ -8,5 +8,5 @@ Name: libxslt
- Version: @VERSION@
- Description: XSLT library version 2.
- Requires: libxml-2.0
--Libs: @XSLT_LIBDIR@ @XSLT_LIBS@ @EXTRA_LIBS@
-+Libs: -lxslt @XSLT_LIBDIR@ @XSLT_LIBS@ @EXTRA_LIBS@
- Cflags: @XSLT_INCLUDEDIR@
diff --git a/meta/recipes-support/libxslt/libxslt_1.1.32.bb b/meta/recipes-support/libxslt/libxslt_1.1.32.bb
index b8951ab3a8b..6a03f776992 100644
--- a/meta/recipes-support/libxslt/libxslt_1.1.32.bb
+++ b/meta/recipes-support/libxslt/libxslt_1.1.32.bb
@@ -8,10 +8,7 @@ LIC_FILES_CHKSUM = "file://Copyright;md5=0cd9a07afbeb24026c9b03aecfeba458"
SECTION = "libs"
DEPENDS = "libxml2"
-SRC_URI = "http://xmlsoft.org/sources/libxslt-${PV}.tar.gz \
- file://pkgconfig_fix.patch \
- "
-
+SRC_URI = "http://xmlsoft.org/sources/libxslt-${PV}.tar.gz"
SRC_URI[md5sum] = "1fc72f98e98bf4443f1651165f3aa146"
SRC_URI[sha256sum] = "526ecd0abaf4a7789041622c3950c0e7f2c4c8835471515fd77eec684a355460"
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more
2017-12-06 14:59 [PATCH 1/2] libxslt: use HTTP instead of FTP in SRC_URI Ross Burton
2017-12-06 14:59 ` [PATCH 2/2] libxslt: remove inappropriate patch Ross Burton
@ 2017-12-06 15:02 ` Patchwork
2017-12-06 16:00 ` Leonardo Sandoval
1 sibling, 1 reply; 6+ messages in thread
From: Patchwork @ 2017-12-06 15:02 UTC (permalink / raw)
To: Ross Burton; +Cc: openembedded-core
== Series Details ==
Series: "libxslt: use HTTP instead of F..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/10099/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Issue SRC_URI changed but checksums are the same [test_src_uri_checksums_not_changed]
Suggested fix Include the SRC_URI's checksums changes into your patch
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more
2017-12-06 15:02 ` ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more Patchwork
@ 2017-12-06 16:00 ` Leonardo Sandoval
2017-12-06 16:03 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: Leonardo Sandoval @ 2017-12-06 16:00 UTC (permalink / raw)
To: Patchwork; +Cc: openembedded-core
On Wed, 06 Dec 2017 15:02:57 -0000
Patchwork <patchwork@patchwork.openembedded.org> wrote:
> == Series Details ==
>
> Series: "libxslt: use HTTP instead of F..." and 1 more
> Revision: 1
> URL : https://patchwork.openembedded.org/series/10099/
> State : failure
>
> == Summary ==
>
>
> Thank you for submitting this patch series to OpenEmbedded Core. This is
> an automated response. Several tests have been executed on the proposed
> series by patchtest resulting in the following failures:
>
>
>
> * Issue SRC_URI changed but checksums are the same [test_src_uri_checksums_not_changed]
> Suggested fix Include the SRC_URI's checksums changes into your patch
I believe we need to improve this check. checksums do not necessary change if URL changes.
>
>
>
> If you believe any of these test results are incorrect, please reply to the
> mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
> Otherwise we would appreciate you correcting the issues and submitting a new
> version of the patchset if applicable. Please ensure you add/increment the
> version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
> [PATCH v3] -> ...).
>
> ---
> Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
> Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
> Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more
2017-12-06 16:00 ` Leonardo Sandoval
@ 2017-12-06 16:03 ` Burton, Ross
2017-12-06 16:31 ` Leonardo Sandoval
0 siblings, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2017-12-06 16:03 UTC (permalink / raw)
To: Leonardo Sandoval; +Cc: Patchwork, OE-core
[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]
On 6 December 2017 at 16:00, Leonardo Sandoval <
leonardo.sandoval.gonzalez@linux.intel.com> wrote:
> On Wed, 06 Dec 2017 15:02:57 -0000
> Patchwork <patchwork@patchwork.openembedded.org> wrote:
>
> > == Series Details ==
> >
> > Series: "libxslt: use HTTP instead of F..." and 1 more
> > Revision: 1
> > URL : https://patchwork.openembedded.org/series/10099/
> > State : failure
> >
> > == Summary ==
> >
> >
> > Thank you for submitting this patch series to OpenEmbedded Core. This is
> > an automated response. Several tests have been executed on the proposed
> > series by patchtest resulting in the following failures:
> >
> >
> >
> > * Issue SRC_URI changed but checksums are the same
> [test_src_uri_checksums_not_changed]
> > Suggested fix Include the SRC_URI's checksums changes into your
> patch
>
>
> I believe we need to improve this check. checksums do not necessary change
> if URL changes.
>
Not sure how to improve it. Maybe making the wording vague, as that is a
common mistake and the URL changing but checksums not changing is not
common.
Ross
[-- Attachment #2: Type: text/html, Size: 1770 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more
2017-12-06 16:03 ` Burton, Ross
@ 2017-12-06 16:31 ` Leonardo Sandoval
0 siblings, 0 replies; 6+ messages in thread
From: Leonardo Sandoval @ 2017-12-06 16:31 UTC (permalink / raw)
To: Burton, Ross; +Cc: Patchwork, OE-core
On Wed, 6 Dec 2017 16:03:13 +0000
"Burton, Ross" <ross.burton@intel.com> wrote:
> On 6 December 2017 at 16:00, Leonardo Sandoval <
> leonardo.sandoval.gonzalez@linux.intel.com> wrote:
>
> > On Wed, 06 Dec 2017 15:02:57 -0000
> > Patchwork <patchwork@patchwork.openembedded.org> wrote:
> >
> > > == Series Details ==
> > >
> > > Series: "libxslt: use HTTP instead of F..." and 1 more
> > > Revision: 1
> > > URL : https://patchwork.openembedded.org/series/10099/
> > > State : failure
> > >
> > > == Summary ==
> > >
> > >
> > > Thank you for submitting this patch series to OpenEmbedded Core. This is
> > > an automated response. Several tests have been executed on the proposed
> > > series by patchtest resulting in the following failures:
> > >
> > >
> > >
> > > * Issue SRC_URI changed but checksums are the same
> > [test_src_uri_checksums_not_changed]
> > > Suggested fix Include the SRC_URI's checksums changes into your
> > patch
> >
> >
> > I believe we need to improve this check. checksums do not necessary change
> > if URL changes.
> >
>
> Not sure how to improve it. Maybe making the wording vague, as that is a
> common mistake and the URL changing but checksums not changing is not
> common.
Rigth. Also bitbake fails if downloaded tarball does not match its checksums with the ones defined on recipe. Time to disable this check.
>
> Ross
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-12-06 16:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-06 14:59 [PATCH 1/2] libxslt: use HTTP instead of FTP in SRC_URI Ross Burton
2017-12-06 14:59 ` [PATCH 2/2] libxslt: remove inappropriate patch Ross Burton
2017-12-06 15:02 ` ✗ patchtest: failure for "libxslt: use HTTP instead of F..." and 1 more Patchwork
2017-12-06 16:00 ` Leonardo Sandoval
2017-12-06 16:03 ` Burton, Ross
2017-12-06 16:31 ` Leonardo Sandoval
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.