* [PATCH] drm/i915: Increase max texture to 16k for gen9+
@ 2017-12-07 9:26 ` Alex Tu
0 siblings, 0 replies; 13+ messages in thread
From: Alex Tu @ 2017-12-07 9:26 UTC (permalink / raw)
Cc: Alex Tu, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, intel-gfx, dri-devel, linux-kernel
Rrefer to another patch [1] on mesa to extend width/height to 16384.
For issue :
- https://bugs.freedesktop.org/show_bug.cgi?id=102508
- LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
[1] https://patchwork.freedesktop.org/patch/124918/
Signed-off-by: Alex Tu <alex.tu@canonical.com>
---
drivers/gpu/drm/i915/intel_display.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index 47a2f6acee50..556fa57b18b8 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
/* "The stride in bytes must not exceed the of the size of 8K
* pixels and 32K bytes."
*/
- return min(8192 * cpp, 32768);
+ return min(16384 * cpp, 65536);
} else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
return 32*1024;
} else if (gen >= 4) {
@@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
dev->mode_config.max_width = 4096;
dev->mode_config.max_height = 4096;
} else {
- dev->mode_config.max_width = 8192;
- dev->mode_config.max_height = 8192;
+ dev->mode_config.max_width = 16384;
+ dev->mode_config.max_height = 16384;
}
if (IS_I845G(dev_priv) || IS_I865G(dev_priv)) {
--
2.11.0
^ permalink raw reply related [flat|nested] 13+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+
2017-12-07 9:26 ` Alex Tu
(?)
@ 2017-12-07 9:32 ` Chris Wilson
2017-12-07 10:09 ` Alex Tu
-1 siblings, 1 reply; 13+ messages in thread
From: Chris Wilson @ 2017-12-07 9:32 UTC (permalink / raw)
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi, Alex Tu
Quoting Alex Tu (2017-12-07 09:26:00)
> Rrefer to another patch [1] on mesa to extend width/height to 16384.
> For issue :
> - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
>
> [1] https://patchwork.freedesktop.org/patch/124918/
>
> Signed-off-by: Alex Tu <alex.tu@canonical.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 47a2f6acee50..556fa57b18b8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
> /* "The stride in bytes must not exceed the of the size of 8K
> * pixels and 32K bytes."
> */
> - return min(8192 * cpp, 32768);
> + return min(16384 * cpp, 65536);
> } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> return 32*1024;
> } else if (gen >= 4) {
> @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> dev->mode_config.max_width = 4096;
> dev->mode_config.max_height = 4096;
> } else {
> - dev->mode_config.max_width = 8192;
> - dev->mode_config.max_height = 8192;
> + dev->mode_config.max_width = 16384;
> + dev->mode_config.max_height = 16384;
These are nothing to do with texture size, but single CRTC bounds.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm/i915: Increase max texture to 16k for gen9+
2017-12-07 9:32 ` [Intel-gfx] " Chris Wilson
@ 2017-12-07 10:09 ` Alex Tu
2017-12-07 11:03 ` Daniel Vetter
0 siblings, 1 reply; 13+ messages in thread
From: Alex Tu @ 2017-12-07 10:09 UTC (permalink / raw)
To: Chris Wilson
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi
[-- Attachment #1.1: Type: text/plain, Size: 2023 bytes --]
Thanks for comment.
I'm not familiar with that, so just followed the patch in mes
https://patchwork.freedesktop.org/patch/124918/a.
How about change subtitle to "drm/i915: Increase max CRTC bounds to 16k for
gen9+"?
On Thu, Dec 7, 2017 at 5:32 PM, Chris Wilson <chris@chris-wilson.co.uk>
wrote:
> Quoting Alex Tu (2017-12-07 09:26:00)
> > Rrefer to another patch [1] on mesa to extend width/height to 16384.
> > For issue :
> > - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
> >
> > [1] https://patchwork.freedesktop.org/patch/124918/
> >
> > Signed-off-by: Alex Tu <alex.tu@canonical.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> > index 47a2f6acee50..556fa57b18b8 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private
> *dev_priv,
> > /* "The stride in bytes must not exceed the of the size
> of 8K
> > * pixels and 32K bytes."
> > */
> > - return min(8192 * cpp, 32768);
> > + return min(16384 * cpp, 65536);
> > } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> > return 32*1024;
> > } else if (gen >= 4) {
> > @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> > dev->mode_config.max_width = 4096;
> > dev->mode_config.max_height = 4096;
> > } else {
> > - dev->mode_config.max_width = 8192;
> > - dev->mode_config.max_height = 8192;
> > + dev->mode_config.max_width = 16384;
> > + dev->mode_config.max_height = 16384;
>
> These are nothing to do with texture size, but single CRTC bounds.
> -Chris
>
[-- Attachment #1.2: Type: text/html, Size: 3169 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+
2017-12-07 10:09 ` Alex Tu
@ 2017-12-07 11:03 ` Daniel Vetter
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2017-12-07 11:03 UTC (permalink / raw)
To: Alex Tu
Cc: Chris Wilson, David Airlie, intel-gfx, linux-kernel, dri-devel,
Rodrigo Vivi
On Thu, Dec 07, 2017 at 06:09:17PM +0800, Alex Tu wrote:
> Thanks for comment.
> I'm not familiar with that, so just followed the patch in mes
> https://patchwork.freedesktop.org/patch/124918/a.
>
> How about change subtitle to "drm/i915: Increase max CRTC bounds to 16k for
> gen9+"?
The render side of the gpu has nothing to do with the display side. Just
because render has higher limits doesn't mean the same limits apply to the
display side. We've had plenty of chips where they don't match.
So trying to justify a CRTC limit change with a mesa change is bogus.
-Daniel
> On Thu, Dec 7, 2017 at 5:32 PM, Chris Wilson <chris@chris-wilson.co.uk>
> wrote:
>
> > Quoting Alex Tu (2017-12-07 09:26:00)
> > > Rrefer to another patch [1] on mesa to extend width/height to 16384.
> > > For issue :
> > > - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> > > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
> > >
> > > [1] https://patchwork.freedesktop.org/patch/124918/
> > >
> > > Signed-off-by: Alex Tu <alex.tu@canonical.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_display.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > > index 47a2f6acee50..556fa57b18b8 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private
> > *dev_priv,
> > > /* "The stride in bytes must not exceed the of the size
> > of 8K
> > > * pixels and 32K bytes."
> > > */
> > > - return min(8192 * cpp, 32768);
> > > + return min(16384 * cpp, 65536);
> > > } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> > > return 32*1024;
> > > } else if (gen >= 4) {
> > > @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> > > dev->mode_config.max_width = 4096;
> > > dev->mode_config.max_height = 4096;
> > > } else {
> > > - dev->mode_config.max_width = 8192;
> > > - dev->mode_config.max_height = 8192;
> > > + dev->mode_config.max_width = 16384;
> > > + dev->mode_config.max_height = 16384;
> >
> > These are nothing to do with texture size, but single CRTC bounds.
> > -Chris
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+
@ 2017-12-07 11:03 ` Daniel Vetter
0 siblings, 0 replies; 13+ messages in thread
From: Daniel Vetter @ 2017-12-07 11:03 UTC (permalink / raw)
To: Alex Tu; +Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi
On Thu, Dec 07, 2017 at 06:09:17PM +0800, Alex Tu wrote:
> Thanks for comment.
> I'm not familiar with that, so just followed the patch in mes
> https://patchwork.freedesktop.org/patch/124918/a.
>
> How about change subtitle to "drm/i915: Increase max CRTC bounds to 16k for
> gen9+"?
The render side of the gpu has nothing to do with the display side. Just
because render has higher limits doesn't mean the same limits apply to the
display side. We've had plenty of chips where they don't match.
So trying to justify a CRTC limit change with a mesa change is bogus.
-Daniel
> On Thu, Dec 7, 2017 at 5:32 PM, Chris Wilson <chris@chris-wilson.co.uk>
> wrote:
>
> > Quoting Alex Tu (2017-12-07 09:26:00)
> > > Rrefer to another patch [1] on mesa to extend width/height to 16384.
> > > For issue :
> > > - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> > > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
> > >
> > > [1] https://patchwork.freedesktop.org/patch/124918/
> > >
> > > Signed-off-by: Alex Tu <alex.tu@canonical.com>
> > > ---
> > > drivers/gpu/drm/i915/intel_display.c | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > > index 47a2f6acee50..556fa57b18b8 100644
> > > --- a/drivers/gpu/drm/i915/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/intel_display.c
> > > @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private
> > *dev_priv,
> > > /* "The stride in bytes must not exceed the of the size
> > of 8K
> > > * pixels and 32K bytes."
> > > */
> > > - return min(8192 * cpp, 32768);
> > > + return min(16384 * cpp, 65536);
> > > } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> > > return 32*1024;
> > > } else if (gen >= 4) {
> > > @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> > > dev->mode_config.max_width = 4096;
> > > dev->mode_config.max_height = 4096;
> > > } else {
> > > - dev->mode_config.max_width = 8192;
> > > - dev->mode_config.max_height = 8192;
> > > + dev->mode_config.max_width = 16384;
> > > + dev->mode_config.max_height = 16384;
> >
> > These are nothing to do with texture size, but single CRTC bounds.
> > -Chris
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH] drm/i915: Increase max texture to 16k for gen9+
2017-12-07 9:26 ` Alex Tu
(?)
(?)
@ 2017-12-07 11:11 ` Chris Wilson
-1 siblings, 0 replies; 13+ messages in thread
From: Chris Wilson @ 2017-12-07 11:11 UTC (permalink / raw)
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi, Alex Tu
Quoting Alex Tu (2017-12-07 09:26:00)
> Rrefer to another patch [1] on mesa to extend width/height to 16384.
> For issue :
> - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
>
> [1] https://patchwork.freedesktop.org/patch/124918/
>
> Signed-off-by: Alex Tu <alex.tu@canonical.com>
For -intel, I just used RandR to split the fb into per-crtc-pixmaps.
However, Kristian has suggested another approach where we carve
per-crtc-pixmaps/-fb out of the global frontbuffer, which allows us to
completely get around the stride limits of scanout and have no
synchronisation penalty. We still have to create new per-crtc-fb for a
flip, just like with RandR but we can avoid the extra blit.
How one feeds such details through gbm into -modesetting, I have no
idea.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Increase max texture to 16k for gen9+
2017-12-07 9:26 ` Alex Tu
` (2 preceding siblings ...)
(?)
@ 2017-12-07 11:59 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2017-12-07 11:59 UTC (permalink / raw)
To: Alex Tu; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase max texture to 16k for gen9+
URL : https://patchwork.freedesktop.org/series/35016/
State : success
== Summary ==
Series 35016v1 drm/i915: Increase max texture to 16k for gen9+
https://patchwork.freedesktop.org/api/1.0/series/35016/revisions/1/mbox/
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:441s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:383s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:512s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:281s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:508s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:504s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:490s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:473s
fi-gdg-551 total:288 pass:179 dwarn:1 dfail:0 fail:0 skip:108 time:268s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:534s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:383s
fi-hsw-4770r total:288 pass:224 dwarn:0 dfail:0 fail:0 skip:64 time:259s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:391s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:480s
fi-ivb-3770 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:445s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:490s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:526s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:476s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:534s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:585s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:458s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:538s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:563s
fi-skl-6700k total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:524s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:496s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:444s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:414s
Blacklisted hosts:
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:611s
fi-glk-dsi total:288 pass:257 dwarn:0 dfail:0 fail:1 skip:30 time:493s
628d1a2176a1ff6ddc4aa282aeb42c526bc64e8a drm-tip: 2017y-12m-07d-10h-57m-50s UTC integration manifest
645b40fc37d4 drm/i915: Increase max texture to 16k for gen9+
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7435/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm/i915: Increase max texture to 16k for gen9+
2017-12-07 9:26 ` Alex Tu
@ 2017-12-07 13:25 ` Joonas Lahtinen
-1 siblings, 0 replies; 13+ messages in thread
From: Joonas Lahtinen @ 2017-12-07 13:25 UTC (permalink / raw)
To: Alex Tu, Ville Syrjälä
Cc: Jani Nikula, Rodrigo Vivi, David Airlie, intel-gfx, dri-devel,
linux-kernel
+ Ville as Jani is OoO
On Thu, 2017-12-07 at 17:26 +0800, Alex Tu wrote:
> Rrefer to another patch [1] on mesa to extend width/height to 16384.
> For issue :
> - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
>
> [1] https://patchwork.freedesktop.org/patch/124918/
>
> Signed-off-by: Alex Tu <alex.tu@canonical.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 47a2f6acee50..556fa57b18b8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
> /* "The stride in bytes must not exceed the of the size of 8K
> * pixels and 32K bytes."
> */
> - return min(8192 * cpp, 32768);
> + return min(16384 * cpp, 65536);
> } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> return 32*1024;
> } else if (gen >= 4) {
> @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> dev->mode_config.max_width = 4096;
> dev->mode_config.max_height = 4096;
> } else {
> - dev->mode_config.max_width = 8192;
> - dev->mode_config.max_height = 8192;
> + dev->mode_config.max_width = 16384;
> + dev->mode_config.max_height = 16384;
> }
>
> if (IS_I845G(dev_priv) || IS_I865G(dev_priv)) {
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm/i915: Increase max texture to 16k for gen9+
@ 2017-12-07 13:25 ` Joonas Lahtinen
0 siblings, 0 replies; 13+ messages in thread
From: Joonas Lahtinen @ 2017-12-07 13:25 UTC (permalink / raw)
To: Alex Tu, Ville Syrjälä
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi
+ Ville as Jani is OoO
On Thu, 2017-12-07 at 17:26 +0800, Alex Tu wrote:
> Rrefer to another patch [1] on mesa to extend width/height to 16384.
> For issue :
> - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
>
> [1] https://patchwork.freedesktop.org/patch/124918/
>
> Signed-off-by: Alex Tu <alex.tu@canonical.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 47a2f6acee50..556fa57b18b8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
> /* "The stride in bytes must not exceed the of the size of 8K
> * pixels and 32K bytes."
> */
> - return min(8192 * cpp, 32768);
> + return min(16384 * cpp, 65536);
> } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> return 32*1024;
> } else if (gen >= 4) {
> @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> dev->mode_config.max_width = 4096;
> dev->mode_config.max_height = 4096;
> } else {
> - dev->mode_config.max_width = 8192;
> - dev->mode_config.max_height = 8192;
> + dev->mode_config.max_width = 16384;
> + dev->mode_config.max_height = 16384;
> }
>
> if (IS_I845G(dev_priv) || IS_I865G(dev_priv)) {
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Increase max texture to 16k for gen9+
2017-12-07 9:26 ` Alex Tu
` (4 preceding siblings ...)
(?)
@ 2017-12-07 15:32 ` Ville Syrjälä
2017-12-08 3:24 ` Alex Tu
-1 siblings, 1 reply; 13+ messages in thread
From: Ville Syrjälä @ 2017-12-07 15:32 UTC (permalink / raw)
To: Alex Tu; +Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi
On Thu, Dec 07, 2017 at 05:26:00PM +0800, Alex Tu wrote:
> Rrefer to another patch [1] on mesa to extend width/height to 16384.
> For issue :
> - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
>
> [1] https://patchwork.freedesktop.org/patch/124918/
>
> Signed-off-by: Alex Tu <alex.tu@canonical.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 47a2f6acee50..556fa57b18b8 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private *dev_priv,
> /* "The stride in bytes must not exceed the of the size of 8K
> * pixels and 32K bytes."
The spec queote clearly says the patch is wrong. Either that or the spec
quote is outdated.
> */
> - return min(8192 * cpp, 32768);
> + return min(16384 * cpp, 65536);
> } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> return 32*1024;
> } else if (gen >= 4) {
> @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> dev->mode_config.max_width = 4096;
> dev->mode_config.max_height = 4096;
> } else {
> - dev->mode_config.max_width = 8192;
> - dev->mode_config.max_height = 8192;
> + dev->mode_config.max_width = 16384;
> + dev->mode_config.max_height = 16384;
Even if this would be correct (which it's not for most platforms at
least, not quite sure about the very latest hardware), anyone doing
this should at least do a cursory check of the relevant math in the
driver to make seure we don't end up with integer overflows.
> }
>
> if (IS_I845G(dev_priv) || IS_I865G(dev_priv)) {
> --
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
^ permalink raw reply [flat|nested] 13+ messages in thread* Re: [PATCH] drm/i915: Increase max texture to 16k for gen9+
2017-12-07 15:32 ` [Intel-gfx] " Ville Syrjälä
@ 2017-12-08 3:24 ` Alex Tu
0 siblings, 0 replies; 13+ messages in thread
From: Alex Tu @ 2017-12-08 3:24 UTC (permalink / raw)
To: Ville Syrjälä
Cc: David Airlie, intel-gfx, linux-kernel, dri-devel, Rodrigo Vivi
[-- Attachment #1.1: Type: text/plain, Size: 3263 bytes --]
looks it's not that easy as I thought.
This change is for https://bugs.freedesktop.org/show_bug.cgi?id=102508 ,
and the hardware configuration is
* 00:02.0 VGA compatible controller [0300]: Intel Corporation Device
[8086:591d] (rev 04)
* Dell Thunderbolt BME dock :
http://www.dell.com/support/article/us/en/04/sln301105/dell-thunderbolt-dock--tb16--information-and-specifications?lang=en
* internal native monitor is 4K, another 2 4K monitors are plugged behind
BME dock
This patch could let this setting work, but looks it not the correct way.
Not see the the relevant math in original code of commit b321803dfb and
ac484963f9 .
Does someone know how the original value 8192 be calculated out?
So that the way might could be followed for this new change.
Thanks.
On Thu, Dec 7, 2017 at 11:32 PM, Ville Syrjälä <
ville.syrjala@linux.intel.com> wrote:
> On Thu, Dec 07, 2017 at 05:26:00PM +0800, Alex Tu wrote:
> > Rrefer to another patch [1] on mesa to extend width/height to 16384.
> > For issue :
> > - https://bugs.freedesktop.org/show_bug.cgi?id=102508
> > - LP: #1714178 Triple monitor display failed with Dell Dock (HiDPI)
> >
> > [1] https://patchwork.freedesktop.org/patch/124918/
> >
> > Signed-off-by: Alex Tu <alex.tu@canonical.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/drivers/gpu/drm/i915/intel_display.c
> > index 47a2f6acee50..556fa57b18b8 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -13905,7 +13905,7 @@ u32 intel_fb_pitch_limit(struct drm_i915_private
> *dev_priv,
> > /* "The stride in bytes must not exceed the of the size of
> 8K
> > * pixels and 32K bytes."
>
> The spec queote clearly says the patch is wrong. Either that or the spec
> quote is outdated.
>
> > */
> > - return min(8192 * cpp, 32768);
> > + return min(16384 * cpp, 65536);
> > } else if (gen >= 5 && !HAS_GMCH_DISPLAY(dev_priv)) {
> > return 32*1024;
> > } else if (gen >= 4) {
> > @@ -14604,8 +14604,8 @@ int intel_modeset_init(struct drm_device *dev)
> > dev->mode_config.max_width = 4096;
> > dev->mode_config.max_height = 4096;
> > } else {
> > - dev->mode_config.max_width = 8192;
> > - dev->mode_config.max_height = 8192;
> > + dev->mode_config.max_width = 16384;
> > + dev->mode_config.max_height = 16384;
>
> Even if this would be correct (which it's not for most platforms at
> least, not quite sure about the very latest hardware), anyone doing
> this should at least do a cursory check of the relevant math in the
> driver to make seure we don't end up with integer overflows.
>
> > }
> >
> > if (IS_I845G(dev_priv) || IS_I865G(dev_priv)) {
> > --
> > 2.11.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
>
[-- Attachment #1.2: Type: text/html, Size: 4988 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Increase max texture to 16k for gen9+
2017-12-07 9:26 ` Alex Tu
` (5 preceding siblings ...)
(?)
@ 2017-12-07 16:16 ` Patchwork
-1 siblings, 0 replies; 13+ messages in thread
From: Patchwork @ 2017-12-07 16:16 UTC (permalink / raw)
To: Alex Tu; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Increase max texture to 16k for gen9+
URL : https://patchwork.freedesktop.org/series/35016/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-shrfb-draw-render:
fail -> PASS (shard-snb) fdo#101623 +1
Test drv_module_reload:
Subgroup basic-reload-inject:
pass -> DMESG-WARN (shard-snb) fdo#102707
Test gem_tiled_swapping:
Subgroup non-threaded:
incomplete -> PASS (shard-snb) fdo#104009
fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623
fdo#102707 https://bugs.freedesktop.org/show_bug.cgi?id=102707
fdo#104009 https://bugs.freedesktop.org/show_bug.cgi?id=104009
shard-hsw total:2679 pass:1535 dwarn:2 dfail:0 fail:10 skip:1132 time:9486s
shard-snb total:2679 pass:1308 dwarn:2 dfail:0 fail:11 skip:1358 time:8122s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7435/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 13+ messages in thread