[PATCH] spi: jcore: disable clock when registering spi conroller failed

[PATCH] spi: jcore: disable clock when registering spi conroller failed

[Takuo Koguchi]

 When probe function fails in registering the spi controller, the clock
 should remain disabled.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Takuo Koguchi <takuo.koguchi.sw@hitachi.com>
---
 Compiled test only, no runtime test done.
 
 drivers/spi/spi-jcore.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-jcore.c b/drivers/spi/spi-jcore.c
index cebfea5..dafed62 100644
--- a/drivers/spi/spi-jcore.c
+++ b/drivers/spi/spi-jcore.c
@@ -198,8 +198,10 @@ static int jcore_spi_probe(struct platform_device *pdev)
 
 	/* Register our spi controller */
 	err = devm_spi_register_master(&pdev->dev, master);
-	if (err)
+	if (err) {
+		clk_disable(clk);
 		goto exit;
+	}
 
 	return 0;
 
-- 
2.7.4

Re: [PATCH] spi: jcore: disable clock when registering spi conroller failed

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

On Thu, Dec 07, 2017 at 07:11:41PM +0900, Takuo Koguchi wrote:
>  When probe function fails in registering the spi controller, the clock
>  should remain disabled.
> 
> Found by Linux Driver Verification project (linuxtesting.org).

I seem to have got three copies of this from you in a very short time?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] spi: jcore: disable clock when registering spi conroller failed

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

On Thu, Dec 07, 2017 at 07:11:41PM +0900, Takuo Koguchi wrote:
>  When probe function fails in registering the spi controller, the clock
>  should remain disabled.
> 
> Found by Linux Driver Verification project (linuxtesting.org).

I seem to have got three copies of this from you in a very short time?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]