From: Jason Yan <yanaijie@huawei.com> To: <martin.petersen@oracle.com>, <jejb@linux.vnet.ibm.com> Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <john.garry@huawei.com>, <zhaohongjiang@huawei.com>, <hare@suse.com>, <dan.j.williams@intel.com>, <jthumshirn@suse.de>, <Raj.Dinesh@microsemi.com>, <hch@lst.de>, <huangdaode@hisilicon.com>, <chenxiang66@hisilicon.com>, <xiyou.wangcong@gmail.com>, Jason Yan <yanaijie@huawei.com>, Ewan Milne <emilne@redhat.com>, Tomas Henzl <thenzl@redhat.com> Subject: [PATCH v5 5/7] scsi: libsas: use flush_workqueue to process disco events synchronously Date: Fri, 8 Dec 2017 17:42:08 +0800 [thread overview] Message-ID: <20171208094210.24887-6-yanaijie@huawei.com> (raw) In-Reply-To: <20171208094210.24887-1-yanaijie@huawei.com> Now we are processing sas event and discover event in different workqueues. It's safe to wait the discover event done in the sas event work. Use flush_workqueue() to insure the disco and revalidate events processed synchronously so that the whole discover and revalidate process will not be interrupted by other events. Signed-off-by: Jason Yan <yanaijie@huawei.com> CC: John Garry <john.garry@huawei.com> CC: Johannes Thumshirn <jthumshirn@suse.de> CC: Ewan Milne <emilne@redhat.com> CC: Christoph Hellwig <hch@lst.de> CC: Tomas Henzl <thenzl@redhat.com> CC: Dan Williams <dan.j.williams@intel.com> --- drivers/scsi/libsas/sas_port.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c index 9326628..64722f4 100644 --- a/drivers/scsi/libsas/sas_port.c +++ b/drivers/scsi/libsas/sas_port.c @@ -192,6 +192,7 @@ static void sas_form_port(struct asd_sas_phy *phy) si->dft->lldd_port_formed(phy); sas_discover_event(phy->port, DISCE_DISCOVER_DOMAIN); + flush_workqueue(sas_ha->disco_q); } /** @@ -277,6 +278,9 @@ void sas_porte_broadcast_rcvd(struct work_struct *work) SAS_DPRINTK("broadcast received: %d\n", prim); sas_discover_event(phy->port, DISCE_REVALIDATE_DOMAIN); + + if (phy->port) + flush_workqueue(phy->port->ha->disco_q); } void sas_porte_link_reset_err(struct work_struct *work) -- 2.9.5
WARNING: multiple messages have this Message-ID (diff)
From: Jason Yan <yanaijie@huawei.com> To: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, zhaohongjiang@huawei.com, hare@suse.com, dan.j.williams@intel.com, jthumshirn@suse.de, Raj.Dinesh@microsemi.com, hch@lst.de, huangdaode@hisilicon.com, chenxiang66@hisilicon.com, xiyou.wangcong@gmail.com, Jason Yan <yanaijie@huawei.com>, Ewan Milne <emilne@redhat.com>, Tomas Henzl <thenzl@redhat.com> Subject: [PATCH v5 5/7] scsi: libsas: use flush_workqueue to process disco events synchronously Date: Fri, 8 Dec 2017 17:42:08 +0800 [thread overview] Message-ID: <20171208094210.24887-6-yanaijie@huawei.com> (raw) In-Reply-To: <20171208094210.24887-1-yanaijie@huawei.com> Now we are processing sas event and discover event in different workqueues. It's safe to wait the discover event done in the sas event work. Use flush_workqueue() to insure the disco and revalidate events processed synchronously so that the whole discover and revalidate process will not be interrupted by other events. Signed-off-by: Jason Yan <yanaijie@huawei.com> CC: John Garry <john.garry@huawei.com> CC: Johannes Thumshirn <jthumshirn@suse.de> CC: Ewan Milne <emilne@redhat.com> CC: Christoph Hellwig <hch@lst.de> CC: Tomas Henzl <thenzl@redhat.com> CC: Dan Williams <dan.j.williams@intel.com> --- drivers/scsi/libsas/sas_port.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/libsas/sas_port.c b/drivers/scsi/libsas/sas_port.c index 9326628..64722f4 100644 --- a/drivers/scsi/libsas/sas_port.c +++ b/drivers/scsi/libsas/sas_port.c @@ -192,6 +192,7 @@ static void sas_form_port(struct asd_sas_phy *phy) si->dft->lldd_port_formed(phy); sas_discover_event(phy->port, DISCE_DISCOVER_DOMAIN); + flush_workqueue(sas_ha->disco_q); } /** @@ -277,6 +278,9 @@ void sas_porte_broadcast_rcvd(struct work_struct *work) SAS_DPRINTK("broadcast received: %d\n", prim); sas_discover_event(phy->port, DISCE_REVALIDATE_DOMAIN); + + if (phy->port) + flush_workqueue(phy->port->ha->disco_q); } void sas_porte_link_reset_err(struct work_struct *work) -- 2.9.5
next prev parent reply other threads:[~2017-12-08 10:08 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-08 9:42 [PATCH v5 0/7] Enhance libsas hotplug feature Jason Yan 2017-12-08 9:42 ` Jason Yan 2017-12-08 9:42 ` [PATCH v5 1/7] scsi: libsas: Use dynamic alloced work to avoid sas event lost Jason Yan 2017-12-08 9:42 ` Jason Yan 2017-12-15 12:14 ` Hannes Reinecke 2017-12-08 9:42 ` [PATCH v5 2/7] scsi: libsas: shut down the PHY if events reached the threshold Jason Yan 2017-12-08 9:42 ` Jason Yan 2017-12-15 12:18 ` Hannes Reinecke 2018-01-08 7:38 ` Hannes Reinecke 2017-12-08 9:42 ` [PATCH v5 3/7] scsi: libsas: make the event threshold configurable Jason Yan 2017-12-08 9:42 ` Jason Yan 2017-12-08 12:09 ` John Garry 2017-12-08 12:09 ` John Garry 2017-12-15 12:19 ` Hannes Reinecke 2018-01-04 10:04 ` John Garry 2018-01-04 10:04 ` John Garry 2017-12-08 9:42 ` [PATCH v5 4/7] scsi: libsas: Use new workqueue to run sas event and disco event Jason Yan 2017-12-08 9:42 ` Jason Yan 2017-12-15 12:20 ` Hannes Reinecke 2017-12-08 9:42 ` Jason Yan [this message] 2017-12-08 9:42 ` [PATCH v5 5/7] scsi: libsas: use flush_workqueue to process disco events synchronously Jason Yan 2017-12-15 12:21 ` Hannes Reinecke 2017-12-08 9:42 ` [PATCH v5 6/7] scsi: libsas: direct call probe and destruct Jason Yan 2017-12-08 9:42 ` Jason Yan 2017-12-15 12:23 ` Hannes Reinecke 2017-12-08 9:42 ` [PATCH v5 7/7] scsi: libsas: notify event PORTE_BROADCAST_RCVD in sas_enable_revalidation() Jason Yan 2017-12-08 9:42 ` Jason Yan 2017-12-15 12:26 ` Hannes Reinecke 2018-01-02 11:06 ` [PATCH v5 0/7] Enhance libsas hotplug feature John Garry 2018-01-02 11:06 ` John Garry 2018-01-04 6:01 ` Martin K. Petersen 2018-01-04 6:01 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171208094210.24887-6-yanaijie@huawei.com \ --to=yanaijie@huawei.com \ --cc=Raj.Dinesh@microsemi.com \ --cc=chenxiang66@hisilicon.com \ --cc=dan.j.williams@intel.com \ --cc=emilne@redhat.com \ --cc=hare@suse.com \ --cc=hch@lst.de \ --cc=huangdaode@hisilicon.com \ --cc=jejb@linux.vnet.ibm.com \ --cc=john.garry@huawei.com \ --cc=jthumshirn@suse.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=thenzl@redhat.com \ --cc=xiyou.wangcong@gmail.com \ --cc=zhaohongjiang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.